Linux Media Controller development
 help / color / mirror / Atom feed
From: Ruslan Koreev <koreev.r@gmail.com>
To: Sakari Ailus <sakari.ailus@linux.intel.com>,
	Dan Scally <dan.scally@ideasonboard.com>
Cc: Hans de Goede <hansg@kernel.org>,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
	Rillian Grant <rillian.grant@gmail.com>,
	linux-media@vger.kernel.org
Subject: media: ipu-bridge: lifetime of retained software-node properties
Date: Mon, 26 Oct 2026 12:12:52 +0300	[thread overview]
Message-ID: <20261026091252.676350-1-koreev.r@gmail.com> (raw)

Hi Sakari, Dan,

While moving the LM3643 board description into ipu-bridge, I noticed an
existing property lifetime issue in media next d7e7bca71698.

The bridge deliberately keeps its software-node graph after module unload,
but link-frequencies still points at cfg->link_freqs in module storage.
The lens-focus property name is also a module string literal.
software_node_register() retains these pointers without copying them.

This predates my local flash integration, whose new nodes own their backing
storage. This finding is from source review; I have not yet tested unloading
a populated sensor graph.

I propose a separate media fix that copies the remaining names and values
into graph-owned storage, with a VM unload/reload test. Would you prefer
that as a prerequisite to the flash integration, or handled independently?

Regards,
Ruslan

             reply	other threads:[~2026-10-26  9:12 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-26  9:12 Ruslan Koreev [this message]
2026-10-26 11:11 ` media: ipu-bridge: lifetime of retained software-node properties Fernando Rimoli
2026-10-26 17:19   ` D. Manresa
2026-10-27 14:30     ` Ruslan Koreev
2026-10-27 19:21       ` D. Manresa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261026091252.676350-1-koreev.r@gmail.com \
    --to=koreev.r@gmail.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=dan.scally@ideasonboard.com \
    --cc=hansg@kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=rillian.grant@gmail.com \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox