From: Vladimir Zapolskiy <vz@kernel.org>
To: Bryan O'Donoghue <bryan.odonoghue@linaro.org>,
Loic Poulain <loic.poulain@oss.qualcomm.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>
Cc: Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Abel Vesa <abelvesa@kernel.org>,
linux-media@vger.kernel.org, linux-arm-msm@vger.kernel.org,
devicetree@vger.kernel.org
Subject: [PATCH 2/4] media: qcom: camss: Select Titan 480 CSID offset by VFE type
Date: Thu, 5 Nov 2026 01:45:31 +0200 [thread overview]
Message-ID: <20261104234533.3044265-3-vz@kernel.org> (raw)
In-Reply-To: <20261104234533.3044265-1-vz@kernel.org>
On Titan 480 CSID register spaces are placed inside VFE register spaces,
and the offset of CSID registers differs between VFE and VFE lite blocks.
Instead of the assumption that all VFEs starting from the third one are
VFE lite blocks, check the VFE type in the platform VFE resources.
Signed-off-by: Vladimir Zapolskiy <vz@kernel.org>
---
drivers/media/platform/qcom/camss/camss-csid.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/qcom/camss/camss-csid.c b/drivers/media/platform/qcom/camss/camss-csid.c
index a00791b00feb..9e64e8d44926 100644
--- a/drivers/media/platform/qcom/camss/camss-csid.c
+++ b/drivers/media/platform/qcom/camss/camss-csid.c
@@ -1119,7 +1119,7 @@ int msm_csid_subdev_init(struct camss *camss, struct csid_device *csid,
* between the VFE "top" and "bus" registers. this requires
* VFE to be initialized before CSID
*/
- if (id >= 2) /* VFE/CSID lite */
+ if (camss->res->vfe_res[id].vfe.is_lite)
csid->base = csid->res->parent_dev_ops->get_base_address(camss, id)
+ VFE_480_LITE_CSID_OFFSET;
else
--
2.51.0
next prev parent reply other threads:[~2026-11-04 23:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-04 23:45 [PATCH 0/4] media: qcom: camss: Add SM8350 CAMSS support Vladimir Zapolskiy
2026-11-04 23:45 ` [PATCH 1/4] dt-bindings: media: Add Qualcomm SM8350 CAMSS Vladimir Zapolskiy
2026-11-05 9:54 ` Bryan O'Donoghue
2026-11-05 11:13 ` Krzysztof Kozlowski
2026-11-04 23:45 ` Vladimir Zapolskiy [this message]
2026-11-05 9:51 ` [PATCH 2/4] media: qcom: camss: Select Titan 480 CSID offset by VFE type Bryan O'Donoghue
2026-11-04 23:45 ` [PATCH 3/4] media: qcom: camss: Add SM8350 CAMSS support Vladimir Zapolskiy
2026-11-05 9:53 ` Bryan O'Donoghue
2026-11-04 23:45 ` [PATCH 4/4] arm64: dts: qcom: sm8350: Add CAMSS device tree node Vladimir Zapolskiy
2026-11-05 9:56 ` Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261104234533.3044265-3-vz@kernel.org \
--to=vz@kernel.org \
--cc=abelvesa@kernel.org \
--cc=andersson@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=loic.poulain@oss.qualcomm.com \
--cc=mchehab@kernel.org \
--cc=robh@kernel.org \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox