From: Michal Pecio <michal.pecio@gmail.com>
To: Jeffrey Hein <jp@jphein.com>
Cc: Mathias Nyman <mathias.nyman@linux.intel.com>,
Ricardo Ribalda <ribalda@chromium.org>,
Alan Stern <stern@rowland.harvard.edu>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Hans de Goede <hansg@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-media@vger.kernel.org, linux-usb@vger.kernel.org
Subject: Re: [PATCH v5 2/3] media: uvcvideo: add UVC_QUIRK_CTRL_THROTTLE for fragile firmware
Date: Sun, 15 Nov 2026 11:01:32 +0100 [thread overview]
Message-ID: <20261115110132.2b0bda47.michal.pecio@gmail.com> (raw)
In-Reply-To: <CAD5VvzC3ySh=fgdPsuftQt_C3kf8Ww5TYGbWTmx5E4S3FmaSbg@mail.gmail.com>
Hi,
FYI, I had a *broken* Kiyo Pro available for a few days in October.
Starting a stream or autosuspend made it stop working altogether, but
it was responding to control requests normally until then. Under such
conditions, your stress test script ran at a rate of 2-3 iterations
per second for thousands of iterations without issues.
The only exception was ASMedia host controllers, where the script
triggered a known HW bug related to repeated restarting of interrupt
endpoints. Same bug is also triggered by toggling USB3 NICs up and
down and on a different USB3 UVC camera, but only if I slow down its
interrupt endpoint polling rate to match Kiyo Pro.
So I found no evidence of HW bugs in this specific broken Kiyo Pro
under my limited testing, but I found that UVC triggers HC bugs.
I'm curious if you could check how this camera works on 7.3 and newer
releases, because commit 7c0c31c66a7f solved most cases of the ASMedia
interrupt bug - it was caused not just by any repeated restarting of
the endpoint, but by repeated restarting while on a link TRB. It also
solved crashes of VL805 on repeated USB3 isochronous restarts. Looks
like some HW may not be handling No-Op and Link TRBs 100% right.
> - What has kept calls working in practice is never stopping the
> stream: an always-on OBS instance holds the camera open and
> applications read a v4l2loopback virtual camera, so stream
> stop/reconfigure never reaches the firmware. One stall under that
> setup was absorbed by a hub VBUS cycle with no visible interruption.
Well, that's possibly an HC bug triggered by stopping UVC streaming,
like on VL805 but with different symptoms.
> - The two cameras now sit on two hosts (Intel Cannon Lake 00:14.0 on
> the desktop; a Titan Ridge Thunderbolt xHCI on a laptop) with the
> same stack on both, so a remaining desktop-only failure isolates the
> host.
Not sure what you mean, is the Titan Ridge free of problems?
> Still open from my side: the A/B on your xhci-test patch. Is there a
> 7.x rebase, or should I run the 6.17 pair with the version skew?
Are you referring to what I posted on April 9th? Both parts of that
patch (fix soft retry after short transfers and override bogus
wBytesPerInterval values) are now in mainline.
OTOH, you could try the patch below, which is not in mainline. It makes
stopping UVC streams less stressful for buggy HCs and it worked for
those VL806 crashes which seem to be solved in 7.3 now.
Regards,
Michal
---
diff --git a/drivers/media/usb/uvc/uvc_video.c b/drivers/media/usb/uvc/uvc_video.c
index fc3536a4399f..bc03e4b205e2 100644
--- a/drivers/media/usb/uvc/uvc_video.c
+++ b/drivers/media/usb/uvc/uvc_video.c
@@ -1901,7 +1901,13 @@ static void uvc_video_stop_transfer(struct uvc_streaming *stream,
* will be prevented from resubmitting the URBs.
*/
for_each_uvc_urb(uvc_urb, stream)
- usb_poison_urb(uvc_urb->urb);
+ usb_block_urb(uvc_urb->urb);
+
+ for_each_uvc_urb(uvc_urb, stream)
+ usb_unlink_urb(uvc_urb->urb);
+
+ for_each_uvc_urb(uvc_urb, stream)
+ usb_kill_urb(uvc_urb->urb);
flush_workqueue(stream->async_wq);
next prev parent reply other threads:[~2026-11-16 10:01 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-31 0:38 [PATCH v5 0/3] USB/UVC: Add quirks to prevent Razer Kiyo Pro xHCI cascade failure JP Hein
2026-03-31 0:38 ` [PATCH v5 1/3] USB: core: add NO_LPM quirk for Razer Kiyo Pro webcam JP Hein
2026-03-31 0:38 ` [PATCH v5 2/3] media: uvcvideo: add UVC_QUIRK_CTRL_THROTTLE for fragile firmware JP Hein
2026-04-09 6:45 ` Ricardo Ribalda
[not found] ` <CAD5VvzAu8+Qz7hEEBzuKvO11X=YD-wrtX3_Tk77g2Cq5rZZD0Q@mail.gmail.com>
2026-04-09 7:51 ` Jeffrey Hein
2026-04-09 8:02 ` Michal Pecio
2026-04-09 8:15 ` Jeffrey Hein
2026-04-09 20:17 ` Michal Pecio
2026-04-10 0:01 ` Jeffrey Hein
2026-04-10 0:24 ` Jeffrey Hein
2026-04-10 4:47 ` Michal Pecio
2026-04-10 21:48 ` Mathias Nyman
2026-04-10 23:06 ` Jeffrey Hein
2026-04-13 8:05 ` Michal Pecio
2026-04-27 6:35 ` Michal Pecio
2026-05-03 22:54 ` Jeffrey Hein
2026-08-26 13:45 ` JP Hein
2026-11-14 13:24 ` Jeffrey Hein
2026-11-15 10:01 ` Michal Pecio [this message]
2026-04-13 20:24 ` Michal Pecio
2026-04-11 13:39 ` Michal Pecio
2026-03-31 0:38 ` [PATCH v5 3/3] media: uvcvideo: add quirks for Razer Kiyo Pro webcam JP Hein
2026-04-09 6:49 ` Ricardo Ribalda
2026-04-09 7:38 ` Jeffrey Hein
2026-04-09 7:42 ` [PATCH v6 0/2] media: uvcvideo: Add quirks to prevent Razer Kiyo Pro xHCI cascade failure JP Hein
2026-04-09 7:42 ` [PATCH v6 1/2] media: uvcvideo: add UVC_QUIRK_CTRL_THROTTLE for fragile USB firmware JP Hein
2026-04-09 7:57 ` Ricardo Ribalda
2026-04-09 8:12 ` Jeffrey Hein
2026-04-09 7:42 ` [PATCH v6 2/2] media: uvcvideo: add Razer Kiyo Pro to device info table JP Hein
2026-04-09 7:57 ` Ricardo Ribalda
2026-04-09 8:13 ` Jeffrey Hein
2026-04-10 0:28 ` [PATCH v7 0/2] media: uvcvideo: Add quirks to prevent Razer Kiyo Pro xHCI cascade failure JP Hein
2026-04-10 0:28 ` [PATCH v7 1/2] media: uvcvideo: add UVC_QUIRK_CTRL_THROTTLE for fragile USB firmware JP Hein
2026-04-10 0:28 ` [PATCH v7 2/2] media: uvcvideo: add Razer Kiyo Pro to device info table JP Hein
2026-04-13 20:40 ` [PATCH v7 0/2] media: uvcvideo: Add quirks to prevent Razer Kiyo Pro xHCI cascade failure Michal Pecio
2026-04-18 17:26 ` Jeffrey Hein
2026-05-03 23:24 ` [PATCH v8 0/2] media: uvcvideo: Quirks for Razer Kiyo Pro firmware lockup JP Hein
2026-05-03 23:25 ` [PATCH v8 1/2] media: uvcvideo: add UVC_QUIRK_CTRL_THROTTLE for fragile USB firmware JP Hein
2026-05-03 23:25 ` [PATCH v8 2/2] media: uvcvideo: add Razer Kiyo Pro to device info table JP Hein
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261115110132.2b0bda47.michal.pecio@gmail.com \
--to=michal.pecio@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hansg@kernel.org \
--cc=jp@jphein.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@linux.intel.com \
--cc=ribalda@chromium.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox