Linux Media Controller development
 help / color / mirror / Atom feed
From: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>
To: Pawel Zalewski <pzalewski@thegoodpenguin.co.uk>
Cc: Ettore Chimenti <ek5.chimenti@gmail.com>,
	Hans Verkuil <hverkuil@kernel.org>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Sakari Ailus <sakari.ailus@linux.intel.com>,
	Miguel Vadillo <miguel.vadillo@intel.com>,
	Antti Laakso <antti.laakso@linux.intel.com>,
	Hans de Goede <hansg@kernel.org>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Bingbu Cao <bingbu.cao@amd.com>,
	Bryan O'Donoghue <bod@kernel.org>, Jimmy Su <jimmy.su@intel.com>,
	Matthias Fend <matthias.fend@emfend.at>,
	Arec Kao <arec.kao@intel.com>,
	Rui Miguel Silva <rmfrfs@gmail.com>,
	Daniel Scally <dan.scally@ideasonboard.com>,
	Kate Hsuan <hpa@redhat.com>,
	linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/5] media: cec: seco: Use named initializers for acpi_device_id
Date: Thu, 19 Nov 2026 16:09:19 +0100	[thread overview]
Message-ID: <20261119160919.16261a11@foz.lan> (raw)
In-Reply-To: <20261029-acpi-media-v1-1-eb50f0a34e36@thegoodpenguin.co.uk>

On Thu, 29 Oct 2026 16:54:13 +0000
Pawel Zalewski <pzalewski@thegoodpenguin.co.uk> wrote:

> Use a designated initializer for the acpi_device_id fields which makes the
> code more readable and consistent with how lists are initialized in the
> rest of the kernel code base. Also drop explicitly setting fields to 0
> where it is redundant.
> 
> Unify the list terminator to have a single space between the brackets and
> no trailing comma.
> 
> Signed-off-by: Pawel Zalewski <pzalewski@thegoodpenguin.co.uk>

LGTM.

Reviewed-by: Mauro Carvalho Chehab <mchehab+huawei@kernel.org>

> ---
>  drivers/media/cec/platform/seco/seco-cec.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/media/cec/platform/seco/seco-cec.c b/drivers/media/cec/platform/seco/seco-cec.c
> index 12db6dca602b..2d7ee5638eba 100644
> --- a/drivers/media/cec/platform/seco/seco-cec.c
> +++ b/drivers/media/cec/platform/seco/seco-cec.c
> @@ -768,8 +768,8 @@ static SIMPLE_DEV_PM_OPS(secocec_pm_ops, secocec_suspend, secocec_resume);
>  
>  #ifdef CONFIG_ACPI
>  static const struct acpi_device_id secocec_acpi_match[] = {
> -	{"CEC00001", 0},
> -	{},
> +	{ .id = "CEC00001" },
> +	{ }
>  };
>  
>  MODULE_DEVICE_TABLE(acpi, secocec_acpi_match);
> 



Thanks,
Mauro

  reply	other threads:[~2026-11-19 15:09 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-29 16:54 [PATCH 0/5] media: use designated initializers for acpi_device_id Pawel Zalewski
2026-10-29 16:54 ` [PATCH 1/5] media: cec: seco: Use named " Pawel Zalewski
2026-11-19 15:09   ` Mauro Carvalho Chehab [this message]
2026-10-29 16:54 ` [PATCH 2/5] media: i2c: ccs: Unify list terminator " Pawel Zalewski
2026-10-29 16:54 ` [PATCH 3/5] media: i2c: cvs: Use named initializers " Pawel Zalewski
2026-10-29 16:54 ` [PATCH 4/5] media: i2c: " Pawel Zalewski
2026-10-29 16:54 ` [PATCH 5/5] media: pci: intel: " Pawel Zalewski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261119160919.16261a11@foz.lan \
    --to=mchehab+huawei@kernel.org \
    --cc=antti.laakso@linux.intel.com \
    --cc=arec.kao@intel.com \
    --cc=bingbu.cao@amd.com \
    --cc=bod@kernel.org \
    --cc=dan.scally@ideasonboard.com \
    --cc=ek5.chimenti@gmail.com \
    --cc=hansg@kernel.org \
    --cc=hpa@redhat.com \
    --cc=hverkuil@kernel.org \
    --cc=jimmy.su@intel.com \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=matthias.fend@emfend.at \
    --cc=mchehab@kernel.org \
    --cc=miguel.vadillo@intel.com \
    --cc=pzalewski@thegoodpenguin.co.uk \
    --cc=rmfrfs@gmail.com \
    --cc=sakari.ailus@linux.intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox