From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from perceval.ideasonboard.com ([95.142.166.194]:53072 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752366AbaCGOXw (ORCPT ); Fri, 7 Mar 2014 09:23:52 -0500 From: Laurent Pinchart To: Hans Verkuil Cc: Hans Verkuil , linux-media@vger.kernel.org, marbugge@cisco.com, Hans Verkuil Subject: Re: [REVIEWv1 PATCH 5/5] DocBook v4l2: update the G/S_EDID documentation Date: Fri, 07 Mar 2014 15:25:22 +0100 Message-ID: <2043205.LIW4DDJa2A@avalon> In-Reply-To: <5319D55B.6080202@cisco.com> References: <1394187679-7345-1-git-send-email-hverkuil@xs4all.nl> <1636382.IFSev3egjD@avalon> <5319D55B.6080202@cisco.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-media-owner@vger.kernel.org List-ID: Hi Hans, On Friday 07 March 2014 15:19:07 Hans Verkuil wrote: > On 03/07/2014 03:09 PM, Laurent Pinchart wrote: > > Hi Hans, > > > > Thank you for the patch. > > > > On Friday 07 March 2014 11:21:19 Hans Verkuil wrote: > >> From: Hans Verkuil > >> > >> Document that it is now possible to call G/S_EDID from video nodes, not > >> just sub-device nodes. Add a note that -EINVAL will be returned if > >> the pad does not support EDIDs. > >> > >> Signed-off-by: Hans Verkuil > >> --- > >> > >> Documentation/DocBook/media/v4l/v4l2.xml | 2 +- > >> .../DocBook/media/v4l/vidioc-subdev-g-edid.xml | 152 > >> ------------------ > >> 2 files changed, 1 insertion(+), 153 deletions(-) > >> delete mode 100644 > >> Documentation/DocBook/media/v4l/vidioc-subdev-g-edid.xml > > > > The patch just removes the EDID ioctls documentation, I highly doubt that > > this is what you intended :-) > > Let's try again: Much better :-) Acked-by: Laurent Pinchart with a minor nitpicking comment below. > Document that it is now possible to call G/S_EDID from video nodes, not > just sub-device nodes. Add a note that -EINVAL will be returned if > the pad does not support EDIDs. > > Signed-off-by: Hans Verkuil > --- > Documentation/DocBook/media/v4l/v4l2.xml | 2 +- > ...{vidioc-subdev-g-edid.xml => vidioc-g-edid.xml} | 36 +++++++++++-------- > 2 files changed, 24 insertions(+), 14 deletions(-) > rename Documentation/DocBook/media/v4l/{vidioc-subdev-g-edid.xml => > vidioc-g-edid.xml} (77%) [snip] > diff --git a/Documentation/DocBook/media/v4l/vidioc-subdev-g-edid.xml > b/Documentation/DocBook/media/v4l/vidioc-g-edid.xml similarity index 77% > rename from Documentation/DocBook/media/v4l/vidioc-subdev-g-edid.xml > rename to Documentation/DocBook/media/v4l/vidioc-g-edid.xml > index bbd18f0..becd7cb 100644 > --- a/Documentation/DocBook/media/v4l/vidioc-subdev-g-edid.xml > +++ b/Documentation/DocBook/media/v4l/vidioc-g-edid.xml [snip] > @@ -56,12 +56,20 @@ > > > Description > - These ioctls can be used to get or set an EDID associated with an > input pad > - from a receiver or an output pad of a transmitter subdevice. > + These ioctls can be used to get or set an EDID associated with an > input > + from a receiver or an output of a transmitter device. These ioctls can I would s/These ioctls/They/ here to avoid repeating "These ioctls" at the beginning of the two sentences. > be > + used with subdevice nodes (/dev/v4l-subdevX) or with video nodes > (/dev/videoX). > + -- Regards, Laurent Pinchart