Re: [RFC PATCH v3 2/2] staging: media: cedrus: Rename H265 to HEVC

Jernej Škrabec
2022-03-28T17:09:19Z

Hi Sebastian!

Dne nedelja, 27. marec 2022 ob 10:43:10 CEST je Sebastian Fricke napisal(a):
> Rename all instances where the identifier H265 is used with HEVC.
> The codec has multiple identifiers H.265 (ITU-T), MPEG-H Part 2 (ISO),
> but the actual name of the codec is HEVC (High Efficiency Video Coding).
> Also nearly all other related drivers use the term HEVC instead of H265.
>
> Signed-off-by: Sebastian Fricke <sebastian.fricke@collabora.com>

This patch is not constructive. I admit, it's unfortunate it's not using same
name as other drivers, but anyone dealing with HEVC will know H265 is synonym
for it. This patch doesn't improve anything and actually makes any fix harder
to backport, if something cames up. According to diffstat, this rewrites more
than 50% of cedrus_h265.c, including renaming the file. Additionally, it's easy
to miss something to rename and we could play this game in the future too, for
no real benefit.

So NAK.

Best regard,
Jernej

P.S. Please wait at least few days before resending patches, even if you find
something. After all, RFC patches are meant to get some response, it's not
expected they will be perfect.

> ---
> drivers/staging/media/sunxi/cedrus/Makefile | 2 +-
> drivers/staging/media/sunxi/cedrus/cedrus.c | 30 +-
> drivers/staging/media/sunxi/cedrus/cedrus.h | 14 +-
> .../staging/media/sunxi/cedrus/cedrus_dec.c | 10 +-
> .../cedrus/{cedrus_h265.c => cedrus_hevc.c} | 438 +++++++++---------
> .../staging/media/sunxi/cedrus/cedrus_hw.c | 4 +-
> .../staging/media/sunxi/cedrus/cedrus_regs.h | 394 ++++++++--------
> .../staging/media/sunxi/cedrus/cedrus_video.c | 4 +-
> 8 files changed, 448 insertions(+), 448 deletions(-)
> rename drivers/staging/media/sunxi/cedrus/{cedrus_h265.c => cedrus_hevc.c}
> (53%)