Linux Media Controller development
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>
Cc: linux-media@vger.kernel.org
Subject: Re: [PATCH 1/2] [media] v4l: vsp1: Fix VI6_DISP_IRQ_ENB_LNEE macro
Date: Thu, 22 Jan 2015 13:48:29 +0200	[thread overview]
Message-ID: <2102436.0XzGPfAmkn@avalon> (raw)
In-Reply-To: <1420616274-15018-1-git-send-email-nobuhiro.iwamatsu.yj@renesas.com>

Hi Iwamatsu-san,

Thank you for the patches.

On Wednesday 07 January 2015 16:37:53 Nobuhiro Iwamatsu wrote:
> LNEE bit in VI6_DISP_IRQ_ENB register are from the 0 bit to 4 bit.
> This fixes bit position specified by VI6_DISP_IRQ_ENB_LNEE.
> 
> Signed-off-by: Nobuhiro Iwamatsu <nobuhiro.iwamatsu.yj@renesas.com>

For the whole series,

Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

I've applied the patches to my tree.

> ---
>  drivers/media/platform/vsp1/vsp1_regs.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/platform/vsp1/vsp1_regs.h
> b/drivers/media/platform/vsp1/vsp1_regs.h index 55f163d..79d4063 100644
> --- a/drivers/media/platform/vsp1/vsp1_regs.h
> +++ b/drivers/media/platform/vsp1/vsp1_regs.h
> @@ -43,7 +43,7 @@
>  #define VI6_DISP_IRQ_ENB		0x0078
>  #define VI6_DISP_IRQ_ENB_DSTE		(1 << 8)
>  #define VI6_DISP_IRQ_ENB_MAEE		(1 << 5)
> -#define VI6_DISP_IRQ_ENB_LNEE(n)	(1 << ((n) + 4))
> +#define VI6_DISP_IRQ_ENB_LNEE(n)	(1 << (n))
> 
>  #define VI6_DISP_IRQ_STA		0x007c
>  #define VI6_DISP_IRQ_STA_DSE		(1 << 8)

-- 
Regards,

Laurent Pinchart


      parent reply	other threads:[~2015-01-22 11:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-01-07  7:37 [PATCH 1/2] [media] v4l: vsp1: Fix VI6_DISP_IRQ_ENB_LNEE macro Nobuhiro Iwamatsu
2015-01-07  7:37 ` [PATCH 2/2] [media] v4l: vsp1: Fix VI6_DISP_IRQ_STA_LNE macro Nobuhiro Iwamatsu
2015-01-22 11:48 ` Laurent Pinchart [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2102436.0XzGPfAmkn@avalon \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=linux-media@vger.kernel.org \
    --cc=nobuhiro.iwamatsu.yj@renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox