Re: [PATCH v9 19/28] rcar-vin: use different v4l2 operations in media controller mode

Laurent Pinchart
2017-12-08T19:31:59Z

Hi Hans,

On Friday, 8 December 2017 12:24:26 EET Hans Verkuil wrote:
> Hi Laurent,
>
> >> +static const struct v4l2_ioctl_ops rvin_mc_ioctl_ops = {
> >> + .vidioc_querycap = rvin_querycap,
> >> + .vidioc_try_fmt_vid_cap = rvin_mc_try_fmt_vid_cap,
> >> + .vidioc_g_fmt_vid_cap = rvin_g_fmt_vid_cap,
> >> + .vidioc_s_fmt_vid_cap = rvin_mc_s_fmt_vid_cap,
> >> + .vidioc_enum_fmt_vid_cap = rvin_enum_fmt_vid_cap,
> >> +
> >> + .vidioc_enum_input = rvin_mc_enum_input,
> >> + .vidioc_g_input = rvin_g_input,
> >> + .vidioc_s_input = rvin_s_input,
> >
> > The input API makes no sense for MC-based devices.
>
> We've had this discussion before:
>
> https://patchwork.linuxtv.org/patch/41857/
>
> There was never a v3 of that patch, so nothing was done with it.
>
> The issue here is that the spec requires G/S_INPUT to be present for
> video nodes. There currently is no exception for MC devices.

I think we both agree that we should fix the spec :-) It shouldn't be a big
deal as MC-enabled applications running with an MC-enabled driver don't use
the input API anyway.

--
Regards,

Laurent Pinchart