From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <linux-media-owner@vger.kernel.org>
Received: from galahad.ideasonboard.com ([185.26.127.97]:52631 "EHLO
	galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751042AbbHSWWi (ORCPT
	<rfc822;linux-media@vger.kernel.org>);
	Wed, 19 Aug 2015 18:22:38 -0400
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Tony Lindgren <tony@atomide.com>
Cc: Michael Allwright <michael.allwright@upb.de>,
	linux-media@vger.kernel.org, Sakari Ailus <sakari.ailus@iki.fi>,
	Mauro Carvalho Chehab <mchehab@osg.samsung.com>,
	Arnd Bergmann <arnd@arndb.de>, Tero Kristo <t-kristo@ti.com>
Subject: Re: [PATCH RFC] DT support for omap4-iss
Date: Thu, 20 Aug 2015 01:23:41 +0300
Message-ID: <2114848.PHKoY9GOpi@avalon>
In-Reply-To: <20150811111604.GD10928@atomide.com>
References: <CALcgO_6UXp-Xqwim8WpLXz7XWAEpejipR7JNQc0TdH0ETL4JYQ@mail.gmail.com> <20150811111604.GD10928@atomide.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Sender: linux-media-owner@vger.kernel.org
List-ID: <linux-media.vger.kernel.org>

Hi Tony,

On Tuesday 11 August 2015 04:16:04 Tony Lindgren wrote:
> * Michael Allwright <michael.allwright@upb.de> [150810 08:19]:
> > +
> > +/*
> > +We need a better solution for this
> > +*/
> > +#include <../arch/arm/mach-omap2/omap-pm.h>
> 
> Please let's not do things like this, I end up having to deal with
> all these eventually :(
> 
> > +static void iss_set_constraints(struct iss_device *iss, bool enable)
> > +{
> > +    if (!iss)
> > +        return;
> > +
> > +    /* FIXME: Look for something more precise as a good throughtput limit
> > */ +    omap_pm_set_min_bus_tput(iss->dev, OCP_INITIATOR_AGENT,
> > +                 enable ? 800000 : -1);
> > +}
> > +
> > +static struct iss_platform_data iss_dummy_pdata = {
> > +    .set_constraints = iss_set_constraints,
> > +};
> 
> If this is one time setting, you could do it based on the
> compatible string using arch/arm/mach-omap2/pdata-quirks.c.
> 
> If you need to toggle it, you could populate a function pointer
> in pdata-quirks.c. Those are easy to fix once there is some Linux
> generic API available :)

Isn't this a good candidate for the PM QoS API ? Does OMAP4 implement it ?

-- 
Regards,

Laurent Pinchart