public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Paulo Assis <pj.assis@gmail.com>
Cc: Pawel Osciak <posciak@chromium.org>,
	Linux Media Mailing List <linux-media@vger.kernel.org>
Subject: Re: [PATCH v1 00/19] UVC 1.5 VP8 support for uvcvideo
Date: Mon, 11 Nov 2013 03:05:08 +0100	[thread overview]
Message-ID: <2118858.3GAjxvYvyO@avalon> (raw)
In-Reply-To: <CAPueXH7+tU7L2dU_CoLJ5gx3phKRUuRsXWW=ztDNrAZ2TjaSbg@mail.gmail.com>

Hi Paulo,

On Thursday 10 October 2013 11:27:37 Paulo Assis wrote:
> Hi,
> just want t know the current state on this series.
> 
> I'm currently adding h264 stream preview support to guvcview.
> It's already working fine on uvc 1.1 cameras like the BCC950

Great ! Is the code already available ?

> but for uvc 1.5 devices like the c930e it could really use some driver
> support.

I'm nearly done reviewing the patches (although 19/19 is a huge beast that 
will take a bit of time to tame :-)). Getting the code to mainline will still 
need some time, but it seems to be going in the right direction. We'll get 
hardware compression support for UVC 1.5 in the driver one way or another, it 
won't be left to userspace to implement (you will of course have to adapt 
existing applications to use the new features, but it should hopefully not be 
too complex).

> 2013/8/30 Pawel Osciak <posciak@chromium.org>:
> > Hello everyone,
> > 
> > This series adds support for UVC 1.5 and VP8 encoding cameras to the
> > uvcvideo driver. The official specification for the new standard can be
> > found here: http://www.usb.org/developers/devclass_docs.
> > 
> > The main change in 1.5 is support for encoding cameras. Those cameras
> > contain additional UVC entities, called Encoding Units, with their own
> > set of controls governing encode parameters. Typical encoding cameras
> > (see examples in class spec) expose two USB Video Streaming Interfaces
> > (VSIs): one for raw stream formats and one for encoded streams.
> > Typically, both get their source stream from a single sensor, producing
> > raw and encoded versions of the video feed simultaneously.
> > Encoding Units may also support the so-called "simulcast" formats, which
> > allow additional sub-streams, or layers, used to achieve temporal
> > scalability. The spec allows up to 4 simulcast layers. Those layers are
> > encoded in the same format, but encoding parameters, such as resolution,
> > bitrate, etc., may, depending on the camera capabilities, be changed
> > independently for each layer, and their streaming state may also be
> > controlled independently as well. The layers are streamed from the same
> > USB VSI, and the information which layer a frame belongs to is contained
> > in its payload header.
> > 
> > In V4L2 API, a separate video node is created for each VSI: one for raw
> > formats VSI and another for the encoded formats VSI. Both can operate
> > completely independently from each other. In addition, if the Encoding
> > Unit supports simulcast, one V4L2 node is created for each stream layer
> > instead, and each can be controlled independently, including
> > streamon/streamoff state, setting resolution and controls. Once a
> > simulcast format is successfully set for one of the simulcast video nodes
> > however, it cannot be changed, unless all connected nodes are idle, i.e.
> > they are not streaming and their buffers are freed.
> > 
> > The userspace can discover if a set of nodes belongs to one encoding unit
> > by traversing media controller topology of the camera.
> > 
> > 
> > I will be gradually posting documentation changes for new features after
> > initial rounds of reviews. This is a relatively major change to the UVC
> > driver and although I tried to keep the existing logic for UVC <1.5
> > cameras intact as much as possible, I would very much appreciate it if
> > these patches could get some testing from you as well, on your own
> > devices/systems.
> > 
> > Thanks,
> > Pawel Osciak
> > 
> > Pawel Osciak (19):
> >       uvcvideo: Add UVC query tracing.
> >       uvcvideo: Return 0 when setting probe control succeeds.
> >       uvcvideo: Add support for multiple chains with common roots.
> >       uvcvideo: Create separate debugfs entries for each streaming
> >       interface.
> >       uvcvideo: Add support for UVC1.5 P&C control.
> >       uvcvideo: Recognize UVC 1.5 encoding units.
> >       uvcvideo: Unify error reporting during format descriptor parsing.
> >       uvcvideo: Add UVC1.5 VP8 format support.
> >       uvcvideo: Reorganize uvc_{get,set}_le_value.
> >       uvcvideo: Support UVC 1.5 runtime control property.
> >       uvcvideo: Support V4L2_CTRL_TYPE_BITMASK controls.
> >       uvcvideo: Reorganize next buffer handling.
> >       uvcvideo: Unify UVC payload header parsing.
> >       v4l: Add v4l2_buffer flags for VP8-specific special frames.
> >       uvcvideo: Add support for VP8 special frame flags.
> >       v4l: Add encoding camera controls.
> >       uvcvideo: Add UVC 1.5 Encoding Unit controls.
> >       v4l: Add V4L2_PIX_FMT_VP8_SIMULCAST format.
> >       uvcvideo: Add support for UVC 1.5 VP8 simulcast.
> >  
> >  drivers/media/usb/uvc/uvc_ctrl.c     | 960 +++++++++++++++++++++++++++---
> >  drivers/media/usb/uvc/uvc_debugfs.c  |   3 +-
> >  drivers/media/usb/uvc/uvc_driver.c   | 604 ++++++++++++++--------
> >  drivers/media/usb/uvc/uvc_entity.c   | 129 ++++-
> >  drivers/media/usb/uvc/uvc_isight.c   |  12 +-
> >  drivers/media/usb/uvc/uvc_queue.c    |  25 +-
> >  drivers/media/usb/uvc/uvc_v4l2.c     | 284 +++++++++--
> >  drivers/media/usb/uvc/uvc_video.c    | 704 ++++++++++++++++---------
> >  drivers/media/usb/uvc/uvcvideo.h     | 214 +++++++-
> >  drivers/media/v4l2-core/v4l2-ctrls.c |  29 ++
> >  include/uapi/linux/usb/video.h       |  45 ++
> >  include/uapi/linux/v4l2-controls.h   |  31 ++
> >  include/uapi/linux/videodev2.h       |   8 +
> >  13 files changed, 2421 insertions(+), 627 deletions(-)

-- 
Regards,

Laurent Pinchart


  reply	other threads:[~2013-11-11  2:04 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-30  2:16 [PATCH v1 00/19] UVC 1.5 VP8 support for uvcvideo Pawel Osciak
2013-08-30  2:17 ` [PATCH v1 01/19] uvcvideo: Add UVC query tracing Pawel Osciak
2013-09-03 20:17   ` Laurent Pinchart
2013-08-30  2:17 ` [PATCH v1 02/19] uvcvideo: Return 0 when setting probe control succeeds Pawel Osciak
2013-09-03 20:21   ` Laurent Pinchart
2013-08-30  2:17 ` [PATCH v1 03/19] uvcvideo: Add support for multiple chains with common roots Pawel Osciak
2013-11-10 20:37   ` Laurent Pinchart
2013-11-11 13:55     ` Paulo Assis
2013-08-30  2:17 ` [PATCH v1 04/19] uvcvideo: Create separate debugfs entries for each streaming interface Pawel Osciak
2013-09-03 20:28   ` Laurent Pinchart
2013-08-30  2:17 ` [PATCH v1 05/19] uvcvideo: Add support for UVC1.5 P&C control Pawel Osciak
2013-09-03 20:42   ` Laurent Pinchart
2013-08-30  2:17 ` [PATCH v1 06/19] uvcvideo: Recognize UVC 1.5 encoding units Pawel Osciak
2013-11-10 21:46   ` Laurent Pinchart
2013-08-30  2:17 ` [PATCH v1 07/19] uvcvideo: Unify error reporting during format descriptor parsing Pawel Osciak
2013-09-03 20:55   ` Laurent Pinchart
2013-08-30  2:17 ` [PATCH v1 08/19] uvcvideo: Add UVC1.5 VP8 format support Pawel Osciak
2013-11-10 22:30   ` Laurent Pinchart
2013-08-30  2:17 ` [PATCH v1 09/19] uvcvideo: Reorganize uvc_{get,set}_le_value Pawel Osciak
2013-11-10 22:34   ` Laurent Pinchart
2013-08-30  2:17 ` [PATCH v1 10/19] uvcvideo: Support UVC 1.5 runtime control property Pawel Osciak
2013-08-30  6:36   ` Hans Verkuil
2013-11-10 22:51   ` Laurent Pinchart
2013-08-30  2:17 ` [PATCH v1 11/19] uvcvideo: Support V4L2_CTRL_TYPE_BITMASK controls Pawel Osciak
2013-11-10 22:57   ` Laurent Pinchart
2013-08-30  2:17 ` [PATCH v1 12/19] uvcvideo: Reorganize next buffer handling Pawel Osciak
2013-11-10 23:43   ` Laurent Pinchart
2013-08-30  2:17 ` [PATCH v1 13/19] uvcvideo: Unify UVC payload header parsing Pawel Osciak
2013-11-11  1:27   ` Laurent Pinchart
2013-11-11  1:46   ` Laurent Pinchart
2013-08-30  2:17 ` [PATCH v1 14/19] v4l: Add v4l2_buffer flags for VP8-specific special frames Pawel Osciak
2013-08-30  6:42   ` Hans Verkuil
     [not found]     ` <CACHYQ-pUhmPhMrbE8QWM+r6OWbBnOx7g6vjQvOxBSoodnPk4+Q@mail.gmail.com>
2013-08-30  8:12       ` Hans Verkuil
2013-08-31 17:42         ` Sakari Ailus
2013-08-31 17:44   ` Sakari Ailus
2013-11-11  1:27   ` Laurent Pinchart
2013-08-30  2:17 ` [PATCH v1 15/19] uvcvideo: Add support for VP8 special frame flags Pawel Osciak
2013-11-11  1:49   ` Laurent Pinchart
2013-08-30  2:17 ` [PATCH v1 16/19] v4l: Add encoding camera controls Pawel Osciak
2013-08-30  6:48   ` Hans Verkuil
2013-09-09  3:48     ` Pawel Osciak
2013-09-09  7:52       ` Hans Verkuil
2013-09-09  7:59         ` Pawel Osciak
2013-09-09  9:00           ` Kamil Debski
2013-09-09  9:09             ` Sylwester Nawrocki
2013-09-10  9:17               ` Hans Verkuil
2013-09-12  1:10                 ` Pawel Osciak
2013-09-12  4:20                   ` Hans Verkuil
2013-11-11  1:53   ` Laurent Pinchart
2013-08-30  2:17 ` [PATCH v1 17/19] uvcvideo: Add UVC 1.5 Encoding Unit controls Pawel Osciak
2013-11-11  2:33   ` Laurent Pinchart
2013-08-30  2:17 ` [PATCH v1 18/19] v4l: Add V4L2_PIX_FMT_VP8_SIMULCAST format Pawel Osciak
2013-08-31 17:52   ` Sakari Ailus
2013-08-30  2:17 ` [PATCH v1 19/19] uvcvideo: Add support for UVC 1.5 VP8 simulcast Pawel Osciak
2013-10-10 10:27 ` [PATCH v1 00/19] UVC 1.5 VP8 support for uvcvideo Paulo Assis
2013-11-11  2:05   ` Laurent Pinchart [this message]
2013-11-11 10:00     ` Paulo Assis

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2118858.3GAjxvYvyO@avalon \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=linux-media@vger.kernel.org \
    --cc=pj.assis@gmail.com \
    --cc=posciak@chromium.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox