From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Cc: linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
kieran.bingham@ideasonboard.com
Subject: Re: [PATCH 1/8] v4l: vsp1: Provide UDS register updates
Date: Mon, 13 Feb 2017 23:30:21 +0200 [thread overview]
Message-ID: <2133199.0UdPgKqoXa@avalon> (raw)
In-Reply-To: <bf28e7e9bf28ff60c505592072a234f8dd568f71.1486758327.git-series.kieran.bingham+renesas@ideasonboard.com>
Hi Kieran,
Thank you for the patch.
On Friday 10 Feb 2017 20:27:29 Kieran Bingham wrote:
> Provide register definitions required for UDS phase and partition
> algorithm support
I would mention here that those registers and bits are available on Gen3 only.
>
> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> ---
> drivers/media/platform/vsp1/vsp1_regs.h | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
> diff --git a/drivers/media/platform/vsp1/vsp1_regs.h
> b/drivers/media/platform/vsp1/vsp1_regs.h index 47b1dee044fb..1ad819680e2f
> 100644
> --- a/drivers/media/platform/vsp1/vsp1_regs.h
> +++ b/drivers/media/platform/vsp1/vsp1_regs.h
> @@ -388,6 +388,7 @@
> #define VI6_UDS_CTRL_NE_RCR (1 << 18)
> #define VI6_UDS_CTRL_NE_GY (1 << 17)
> #define VI6_UDS_CTRL_NE_BCB (1 << 16)
> +#define VI6_UDS_CTRL_AMDSLH (1 << 2)
> #define VI6_UDS_CTRL_TDIPC (1 << 1)
>
> #define VI6_UDS_SCALE 0x2304
> @@ -420,11 +421,24 @@
> #define VI6_UDS_PASS_BWIDTH_V_MASK (0x7f << 0)
> #define VI6_UDS_PASS_BWIDTH_V_SHIFT 0
>
> +#define VI6_UDS_HPHASE 0x2314
> +#define VI6_UDS_HPHASE_HSTP_MASK (0xfff << 16)
> +#define VI6_UDS_HPHASE_HSTP_SHIFT 16
> +#define VI6_UDS_HPHASE_HEDP_MASK (0xfff << 0)
> +#define VI6_UDS_HPHASE_HEDP_SHIFT 0
> +
> #define VI6_UDS_IPC 0x2318
> #define VI6_UDS_IPC_FIELD (1 << 27)
> #define VI6_UDS_IPC_VEDP_MASK (0xfff << 0)
> #define VI6_UDS_IPC_VEDP_SHIFT 0
>
> +#define VI6_UDS_HSZCLIP 0x231c
> +#define VI6_UDS_HSZCLIP_HCEN (1 << 28)
> +#define VI6_UDS_HSZCLIP_HCL_OFST_MASK (0x1ff << 16)
This field spans 8 bits, not 9.
With that fixed,
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> +#define VI6_UDS_HSZCLIP_HCL_OFST_SHIFT 16
> +#define VI6_UDS_HSZCLIP_HCL_SIZE_MASK (0x1fff << 0)
> +#define VI6_UDS_HSZCLIP_HCL_SIZE_SHIFT 0
> +
> #define VI6_UDS_CLIP_SIZE 0x2324
> #define VI6_UDS_CLIP_SIZE_HSIZE_MASK (0x1fff << 16)
> #define VI6_UDS_CLIP_SIZE_HSIZE_SHIFT 16
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2017-02-13 21:29 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-10 20:27 [PATCH 0/8] v4l: vsp1: Partition phase developments Kieran Bingham
2017-02-10 20:27 ` [PATCH 1/8] v4l: vsp1: Provide UDS register updates Kieran Bingham
2017-02-13 21:30 ` Laurent Pinchart [this message]
2017-02-10 20:27 ` [PATCH 2/8] v4l: vsp1: Track the SRU entity in the pipeline Kieran Bingham
2017-02-13 21:36 ` Laurent Pinchart
2017-02-10 20:27 ` [PATCH 3/8] v4l: vsp1: Correct image partition parameters Kieran Bingham
2017-02-13 21:45 ` Laurent Pinchart
2017-02-10 20:27 ` [PATCH 4/8] v4l: vsp1: Move partition rectangles to struct Kieran Bingham
2017-02-13 21:52 ` Laurent Pinchart
2017-02-10 20:27 ` [PATCH 5/8] v4l: vsp1: Operate on partition struct data directly Kieran Bingham
2017-02-13 22:05 ` Laurent Pinchart
2017-02-10 20:27 ` [PATCH 6/8] v4l: vsp1: Allow entities to participate in the partition algorithm Kieran Bingham
2017-02-13 22:51 ` Laurent Pinchart
2017-02-13 23:03 ` Laurent Pinchart
2017-02-10 20:27 ` [PATCH 7/8] v4l: vsp1: Calculate UDS phase for partitions Kieran Bingham
2017-02-13 23:21 ` Laurent Pinchart
2017-02-10 20:27 ` [PATCH 8/8] v4l: vsp1: Implement left edge partition algorithm overlap Kieran Bingham
2017-02-13 23:30 ` Laurent Pinchart
2017-02-14 0:01 ` [PATCH 0/8] v4l: vsp1: Partition phase developments Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2133199.0UdPgKqoXa@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=kieran.bingham@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox