Re: [PATCH v1 04/15] media: i2c: imx290: Access link_freq_index directly

Alexander Stein
2022-11-23T07:56:13Z

Hello Laurent,

thanks for working on this.

Am Dienstag, 22. November 2022, 23:32:39 CET schrieb Laurent Pinchart:
> The imx290_get_link_freq_index() function hides the fact that it relies
> on the imx290 current_mode field, which obfuscates the code instead of
> making it more readable. Inline it in the callers, and use the mode
> pointer we already have in imx290_ctrl_update() instead of using the
> current_mode field.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/media/i2c/imx290.c | 10 ++--------
> 1 file changed, 2 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/media/i2c/imx290.c b/drivers/media/i2c/imx290.c
> index eb295502d0c3..2d198b167853 100644
> --- a/drivers/media/i2c/imx290.c
> +++ b/drivers/media/i2c/imx290.c
> @@ -547,14 +547,9 @@ static int imx290_write_current_format(struct imx290
> *imx290) return 0;
> }
>
> -static inline u8 imx290_get_link_freq_index(struct imx290 *imx290)
> -{
> - return imx290->current_mode->link_freq_index;
> -}
> -
> static s64 imx290_get_link_freq(struct imx290 *imx290)
> {
> - u8 index = imx290_get_link_freq_index(imx290);
> + u8 index = imx290->current_mode->link_freq_index;
>
> return *(imx290_link_freqs_ptr(imx290) + index);
> }
> @@ -645,8 +640,7 @@ static void imx290_ctrl_update(struct imx290 *imx290,
> unsigned int hblank = mode->hmax - mode->width;
> unsigned int vblank = IMX290_VMAX_DEFAULT - mode->height;
>
> - __v4l2_ctrl_s_ctrl(imx290->link_freq,
> - imx290_get_link_freq_index(imx290));
> + __v4l2_ctrl_s_ctrl(imx290->link_freq, mode->link_freq_index);
> __v4l2_ctrl_s_ctrl_int64(imx290->pixel_rate,
> imx290_calc_pixel_rate(imx290));

Reviewed-by: Alexander Stein <alexander.stein@ew.tq-group.com>