From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <linux-media-owner@vger.kernel.org>
Received: from galahad.ideasonboard.com ([185.26.127.97]:37353 "EHLO
        galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1751099AbcI3LI5 (ORCPT
        <rfc822;linux-media@vger.kernel.org>);
        Fri, 30 Sep 2016 07:08:57 -0400
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
Cc: horms@verge.net.au, geert@linux-m68k.org, hans.verkuil@cisco.com,
        niklas.soderlund@ragnatech.se, linux-media@vger.kernel.org,
        linux-renesas-soc@vger.kernel.org, magnus.damm@gmail.com
Subject: Re: [PATCH 1/3] ARM: dts: r8a7793: Enable VIN0, VIN1
Date: Fri, 30 Sep 2016 14:08:53 +0300
Message-ID: <2139972.htm5G2lxOE@avalon>
In-Reply-To: <1961479.Ly4IFObGfR@avalon>
References: <20160916130935.21292-1-ulrich.hecht+renesas@gmail.com> <20160916130935.21292-2-ulrich.hecht+renesas@gmail.com> <1961479.Ly4IFObGfR@avalon>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Sender: linux-media-owner@vger.kernel.org
List-ID: <linux-media.vger.kernel.org>

Hi Ulrich,

On Friday 30 Sep 2016 13:55:50 Laurent Pinchart wrote:
> On Friday 16 Sep 2016 15:09:33 Ulrich Hecht wrote:
> > Signed-off-by: Ulrich Hecht <ulrich.hecht+renesas@gmail.com>
> > ---
> > 
> >  arch/arm/boot/dts/r8a7793.dtsi | 20 ++++++++++++++++++++
> >  1 file changed, 20 insertions(+)
> > 
> > diff --git a/arch/arm/boot/dts/r8a7793.dtsi
> > b/arch/arm/boot/dts/r8a7793.dtsi index 8d02aac..0898668 100644
> > --- a/arch/arm/boot/dts/r8a7793.dtsi
> > +++ b/arch/arm/boot/dts/r8a7793.dtsi
> > @@ -30,6 +30,8 @@
> >  		i2c7 = &i2c7;
> >  		i2c8 = &i2c8;
> >  		spi0 = &qspi;
> > +		vin0 = &vin0;
> > +		vin1 = &vin1;
> 
> Why is this needed ?
> 
> >  	};
> >  	
> >  	cpus {
> > @@ -852,6 +854,24 @@
> >  		status = "disabled";
> >  	};
> > 
> > +	vin0: video@e6ef0000 {
> > +		compatible = "renesas,vin-r8a7793";

Additionally, should this be

	compatiable = "renesas,vin-r8a7793", "renesas,rcar-gen2-vin";

?

> > +		reg = <0 0xe6ef0000 0 0x1000>;
> > +		interrupts = <GIC_SPI 188 IRQ_TYPE_LEVEL_HIGH>;
> > +		clocks = <&mstp8_clks R8A7793_CLK_VIN0>;
> > +		power-domains = <&sysc R8A7793_PD_ALWAYS_ON>;
> > +		status = "disabled";
> > +	};
> > +
> > +	vin1: video@e6ef1000 {
> > +		compatible = "renesas,vin-r8a7793";
> > +		reg = <0 0xe6ef1000 0 0x1000>;
> > +		interrupts = <GIC_SPI 189 IRQ_TYPE_LEVEL_HIGH>;
> > +		clocks = <&mstp8_clks R8A7793_CLK_VIN1>;
> > +		power-domains = <&sysc R8A7793_PD_ALWAYS_ON>;
> > +		status = "disabled";
> > +	};
> > +
> 
> As Geert mentioned, you should add vin2 here.
> 
> >  	qspi: spi@e6b10000 {
> >  	
> >  		compatible = "renesas,qspi-r8a7793", "renesas,qspi";
> >  		reg = <0 0xe6b10000 0 0x2c>;

-- 
Regards,

Laurent Pinchart