From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Rohit Athavale <rohit.athavale@xilinx.com>
Cc: linux-media@vger.kernel.org, hyun.kwon@xilinx.com,
Rohit Athavale <rathaval@xilinx.com>
Subject: Re: [PATCH 1/3] uapi: media-bus-format: Add Xilinx specific YCbCr 4:2:0 media bus format
Date: Fri, 18 Aug 2017 12:17:16 +0300 [thread overview]
Message-ID: <214739951.lpc3CT9Zau@avalon> (raw)
In-Reply-To: <1502303274-40609-2-git-send-email-rathaval@xilinx.com>
Hi Rohit,
Thank you for the patch.
On Wednesday 09 Aug 2017 11:27:52 Rohit Athavale wrote:
> This commit adds Xilinx Video IP specific 8-bit color depth YCbCr 4:2:0
> to the media bus format uapi.
>
> Signed-off-by: Rohit Athavale <rathaval@xilinx.com>
> ---
> include/uapi/linux/media-bus-format.h | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/include/uapi/linux/media-bus-format.h
> b/include/uapi/linux/media-bus-format.h index ef6fb30..6f65607 100644
> --- a/include/uapi/linux/media-bus-format.h
> +++ b/include/uapi/linux/media-bus-format.h
> @@ -143,10 +143,12 @@
> /* JPEG compressed formats - next is 0x4002 */
> #define MEDIA_BUS_FMT_JPEG_1X8 0x4001
>
> -/* Vendor specific formats - next is 0x5002 */
> +/* Vendor specific formats - next is 0x5003 */
>
> /* S5C73M3 sensor specific interleaved UYVY and JPEG */
> #define MEDIA_BUS_FMT_S5C_UYVY_JPEG_1X8 0x5001
> +/* Xilinx IP Specific 8-bit YCbCr 4:2:0 */
> +#define MEDIA_BUS_FMT_XLNX8_VUY420_1X24 0x5002
Is this really a Xilinx-specific format ? I think it would make sense to
define it as a standard YUV format.
> /* HSV - next is 0x6002 */
> #define MEDIA_BUS_FMT_AHSV8888_1X32 0x6001
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2017-08-18 9:16 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-08-09 18:27 [PATCH 0/3] Xilinx 8-bit color depth YCbCr 4:2:0 media bus format Rohit Athavale
2017-08-09 18:27 ` [PATCH 1/3] uapi: media-bus-format: Add Xilinx specific " Rohit Athavale
2017-08-18 9:17 ` Laurent Pinchart [this message]
2017-08-09 18:27 ` [PATCH 2/3] media: xilinx-vip: Add 8-bit YCbCr 4:2:0 to formats table Rohit Athavale
2017-08-18 9:16 ` Laurent Pinchart
2017-08-09 18:27 ` [PATCH 3/3] Documentation: subdev-formats: Add Xilinx YCbCr to Vendor specific area Rohit Athavale
2017-08-18 9:18 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=214739951.lpc3CT9Zau@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=hyun.kwon@xilinx.com \
--cc=linux-media@vger.kernel.org \
--cc=rathaval@xilinx.com \
--cc=rohit.athavale@xilinx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).