From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
Cc: Hans Verkuil <hverkuil@xs4all.nl>,
linux-media <linux-media@vger.kernel.org>,
Hans Verkuil <hansverk@cisco.com>
Subject: Re: [PATCHv5 05/12] media: rename MEDIA_ENT_F_DTV_DECODER to MEDIA_ENT_F_DV_DECODER
Date: Mon, 09 Jul 2018 16:00:08 +0300 [thread overview]
Message-ID: <2187896.B0EHAgUiIi@avalon> (raw)
In-Reply-To: <CAAEAJfAmHZD2sjw9NF2Fyv6j+Z-usKJL4YNG5pgfZuyBSqLZkQ@mail.gmail.com>
Hello,
On Friday, 29 June 2018 20:40:49 EEST Ezequiel Garcia wrote:
> On 29 June 2018 at 08:43, Hans Verkuil <hverkuil@xs4all.nl> wrote:
> > From: Hans Verkuil <hansverk@cisco.com>
> >
> > The use of 'DTV' is very confusing since it normally refers to Digital
> > TV e.g. DVB etc.
> >
> > Instead use 'DV' (Digital Video), which nicely corresponds to the
> > DV Timings API used to configure such receivers and transmitters.
> >
> > We keep an alias to avoid breaking userspace applications.
> >
> > Signed-off-by: Hans Verkuil <hansverk@cisco.com>
> > ---
> >
> > Documentation/media/uapi/mediactl/media-types.rst | 2 +-
> > drivers/media/i2c/adv7604.c | 1 +
> > drivers/media/i2c/adv7842.c | 1 +
>
> It would be nice to mention in the commit log
> that this patch also sets the function for these drivers.
That's also my only concern with this patch (alternatively that change could
be split to a separate patch).
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2018-07-09 12:59 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-06-29 11:43 [PATCHv5 00/12] media/mc: fix inconsistencies Hans Verkuil
2018-06-29 11:43 ` [PATCHv5 01/12] media: add 'index' to struct media_v2_pad Hans Verkuil
2018-07-09 12:55 ` Laurent Pinchart
2018-07-09 13:40 ` Hans Verkuil
2018-07-11 11:33 ` Laurent Pinchart
2018-07-11 11:45 ` Hans Verkuil
2018-08-03 12:34 ` Sakari Ailus
2018-08-03 14:47 ` Mauro Carvalho Chehab
2018-06-29 11:43 ` [PATCHv5 02/12] media-ioc-g-topology.rst: document new 'index' field Hans Verkuil
2018-07-09 12:57 ` Laurent Pinchart
2018-06-29 11:43 ` [PATCHv5 03/12] media: add flags field to struct media_v2_entity Hans Verkuil
2018-07-09 12:58 ` Laurent Pinchart
2018-06-29 11:43 ` [PATCHv5 04/12] media-ioc-g-topology.rst: document new 'flags' field Hans Verkuil
2018-06-29 11:43 ` [PATCHv5 05/12] media: rename MEDIA_ENT_F_DTV_DECODER to MEDIA_ENT_F_DV_DECODER Hans Verkuil
2018-06-29 17:40 ` Ezequiel Garcia
2018-07-09 13:00 ` Laurent Pinchart [this message]
2018-07-09 13:42 ` Hans Verkuil
2018-07-11 11:36 ` Laurent Pinchart
2018-06-29 11:43 ` [PATCHv5 06/12] media.h: add MEDIA_ENT_F_DV_ENCODER Hans Verkuil
2018-07-09 13:02 ` Laurent Pinchart
2018-06-29 11:43 ` [PATCHv5 07/12] media.h: reorder video en/decoder functions Hans Verkuil
2018-07-09 13:02 ` Laurent Pinchart
2018-06-29 11:43 ` [PATCHv5 08/12] ad9389b/adv7511: set proper media entity function Hans Verkuil
2018-07-09 13:04 ` Laurent Pinchart
2018-07-09 13:44 ` Hans Verkuil
2018-06-29 11:43 ` [PATCHv5 09/12] adv7180/tvp514x/tvp7002: fix " Hans Verkuil
2018-07-09 13:04 ` Laurent Pinchart
2018-06-29 11:43 ` [PATCHv5 10/12] media/i2c: add missing entity functions Hans Verkuil
2018-07-09 13:05 ` Laurent Pinchart
2018-06-29 11:43 ` [PATCHv5 11/12] media-ioc-enum-links.rst: improve pad index description Hans Verkuil
2018-07-09 13:10 ` Laurent Pinchart
2018-07-09 13:47 ` Hans Verkuil
2018-06-29 11:43 ` [PATCHv5 12/12] media-ioc-enum-entities.rst/-g-topology.rst: clarify ID/name usage Hans Verkuil
2018-07-09 13:12 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2187896.B0EHAgUiIi@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=hansverk@cisco.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).