From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from perceval.ideasonboard.com ([213.167.242.64]:34844 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932571AbeGIM7f (ORCPT ); Mon, 9 Jul 2018 08:59:35 -0400 From: Laurent Pinchart To: Ezequiel Garcia Cc: Hans Verkuil , linux-media , Hans Verkuil Subject: Re: [PATCHv5 05/12] media: rename MEDIA_ENT_F_DTV_DECODER to MEDIA_ENT_F_DV_DECODER Date: Mon, 09 Jul 2018 16:00:08 +0300 Message-ID: <2187896.B0EHAgUiIi@avalon> In-Reply-To: References: <20180629114331.7617-1-hverkuil@xs4all.nl> <20180629114331.7617-6-hverkuil@xs4all.nl> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-media-owner@vger.kernel.org List-ID: Hello, On Friday, 29 June 2018 20:40:49 EEST Ezequiel Garcia wrote: > On 29 June 2018 at 08:43, Hans Verkuil wrote: > > From: Hans Verkuil > > > > The use of 'DTV' is very confusing since it normally refers to Digital > > TV e.g. DVB etc. > > > > Instead use 'DV' (Digital Video), which nicely corresponds to the > > DV Timings API used to configure such receivers and transmitters. > > > > We keep an alias to avoid breaking userspace applications. > > > > Signed-off-by: Hans Verkuil > > --- > > > > Documentation/media/uapi/mediactl/media-types.rst | 2 +- > > drivers/media/i2c/adv7604.c | 1 + > > drivers/media/i2c/adv7842.c | 1 + > > It would be nice to mention in the commit log > that this patch also sets the function for these drivers. That's also my only concern with this patch (alternatively that change could be split to a separate patch). -- Regards, Laurent Pinchart