Re: [PATCH 2/2] omap3isp: Don't use GFP_DMA

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

Hi Sakari,

Thank you for the patch.

On Monday, 7 May 2018 15:47:23 EEST Sakari Ailus wrote:
> The isp stat driver allocates memory for DMA and uses GFP_DMA flag for
> dev_alloc_coherent. The flag is no longer needed as the DMA mask is used
> for the purpose. Remove it.
> 
> Reported-by: Mauro Carvalho Chehab <mchehab+samsung@kernel.org>
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  drivers/media/platform/omap3isp/ispstat.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/platform/omap3isp/ispstat.c
> b/drivers/media/platform/omap3isp/ispstat.c index
> 34a91125da36..c68562189961 100644
> --- a/drivers/media/platform/omap3isp/ispstat.c
> +++ b/drivers/media/platform/omap3isp/ispstat.c
> @@ -371,7 +371,7 @@ static int isp_stat_bufs_alloc_one(struct device *dev,
>  	int ret;
> 
>  	buf->virt_addr = dma_alloc_coherent(dev, size, &buf->dma_addr,
> -					    GFP_KERNEL | GFP_DMA);
> +					    GFP_KERNEL);
>  	if (!buf->virt_addr)
>  		return -ENOMEM;

-- 
Regards,

Laurent Pinchart