public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Cc: "linux-media @ vger . kernel . org" <linux-media@vger.kernel.org>,
	David Cohen <dacohen@gmail.com>
Subject: Re: [PATCH] media: video: append $(srctree) to -I parameters
Date: Thu, 16 Feb 2012 07:22:33 +0100	[thread overview]
Message-ID: <2218117.VoHfpPQjC4@avalon> (raw)
In-Reply-To: <1329318481-8530-1-git-send-email-andriy.shevchenko@linux.intel.com>

Hi Andy,

Thanks for the patch.

On Wednesday 15 February 2012 17:08:01 Andy Shevchenko wrote:
> Without this we have got the warnings like following if build with "make W=1
> O=/var/tmp":
>    CHECK   drivers/media/video/videobuf-vmalloc.c
>    CC [M]  drivers/media/video/videobuf-vmalloc.o
>  +cc1: warning: drivers/media/dvb/dvb-core: No such file or directory
> [enabled by default] +cc1: warning: drivers/media/dvb/frontends: No such
> file or directory [enabled by default] +cc1: warning:
> drivers/media/dvb/dvb-core: No such file or directory [enabled by default]
> +cc1: warning: drivers/media/dvb/frontends: No such file or directory
> [enabled by default] LD      drivers/media/built-in.o
> 
> Some details could be found in [1] as well.
> 
> [1] http://comments.gmane.org/gmane.linux.kbuild.devel/7733

There are several occurencies if the same issue throughout drivers/. Could you 
send a patch that fixes them all in one go ?
 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  drivers/media/video/Makefile |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/media/video/Makefile b/drivers/media/video/Makefile
> index 3541388..3bf0aa8 100644
> --- a/drivers/media/video/Makefile
> +++ b/drivers/media/video/Makefile
> @@ -199,6 +199,6 @@ obj-y	+= davinci/
> 
>  obj-$(CONFIG_ARCH_OMAP)	+= omap/
> 
> -ccflags-y += -Idrivers/media/dvb/dvb-core
> -ccflags-y += -Idrivers/media/dvb/frontends
> -ccflags-y += -Idrivers/media/common/tuners
> +ccflags-y += -I$(srctree)/drivers/media/dvb/dvb-core
> +ccflags-y += -I$(srctree)/drivers/media/dvb/frontends
> +ccflags-y += -I$(srctree)/drivers/media/common/tuners

The above link mentions $(src). Is that different than $(srctree) ?

-- 
Regards,

Laurent Pinchart

  reply	other threads:[~2012-02-16  6:22 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-02-15 15:08 [PATCH] media: video: append $(srctree) to -I parameters Andy Shevchenko
2012-02-16  6:22 ` Laurent Pinchart [this message]
2012-02-16  9:57   ` Andy Shevchenko
2012-02-17  8:57   ` [PATCHv2 1/7] " Andy Shevchenko
2012-02-17  8:57     ` [PATCHv2 2/7] media: tuners: " Andy Shevchenko
2012-02-17  8:57     ` [PATCHv2 3/7] media: gspca: " Andy Shevchenko
2012-02-17  8:57     ` [PATCHv2 4/7] media: dvb: " Andy Shevchenko
2012-02-17  8:57     ` [PATCHv2 5/7] media: ivtv: " Andy Shevchenko
2012-02-17  8:57     ` [PATCHv2 6/7] media: saa7164: " Andy Shevchenko
2012-02-17  8:57     ` [PATCHv2 7/7] media: saa7134: " Andy Shevchenko
2012-02-17 18:19     ` [PATCHv2 1/7] media: video: " Laurent Pinchart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2218117.VoHfpPQjC4@avalon \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=dacohen@gmail.com \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox