[PATCH] media: video: append $(srctree) to -I parameters

public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed

* [PATCH] media: video: append $(srctree) to -I parameters
@ 2012-02-15 15:08 Andy Shevchenko
  2012-02-16  6:22 ` Laurent Pinchart
  0 siblings, 1 reply; 11+ messages in thread
From: Andy Shevchenko @ 2012-02-15 15:08 UTC (permalink / raw)
  To: linux-media @ vger . kernel . org, Laurent Pinchart, David Cohen
  Cc: Andy Shevchenko

Without this we have got the warnings like following if build with "make W=1
O=/var/tmp":
   CHECK   drivers/media/video/videobuf-vmalloc.c
   CC [M]  drivers/media/video/videobuf-vmalloc.o
 +cc1: warning: drivers/media/dvb/dvb-core: No such file or directory [enabled by default]
 +cc1: warning: drivers/media/dvb/frontends: No such file or directory [enabled by default]
 +cc1: warning: drivers/media/dvb/dvb-core: No such file or directory [enabled by default]
 +cc1: warning: drivers/media/dvb/frontends: No such file or directory [enabled by default]
   LD      drivers/media/built-in.o

Some details could be found in [1] as well.

[1] http://comments.gmane.org/gmane.linux.kbuild.devel/7733

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/media/video/Makefile |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/media/video/Makefile b/drivers/media/video/Makefile
index 3541388..3bf0aa8 100644
--- a/drivers/media/video/Makefile
+++ b/drivers/media/video/Makefile
@@ -199,6 +199,6 @@ obj-y	+= davinci/
 
 obj-$(CONFIG_ARCH_OMAP)	+= omap/
 
-ccflags-y += -Idrivers/media/dvb/dvb-core
-ccflags-y += -Idrivers/media/dvb/frontends
-ccflags-y += -Idrivers/media/common/tuners
+ccflags-y += -I$(srctree)/drivers/media/dvb/dvb-core
+ccflags-y += -I$(srctree)/drivers/media/dvb/frontends
+ccflags-y += -I$(srctree)/drivers/media/common/tuners
-- 
1.7.9


^ permalink raw reply related	[flat|nested] 11+ messages in thread

* Re: [PATCH] media: video: append $(srctree) to -I parameters
  2012-02-15 15:08 [PATCH] media: video: append $(srctree) to -I parameters Andy Shevchenko
@ 2012-02-16  6:22 ` Laurent Pinchart
  2012-02-16  9:57   ` Andy Shevchenko
  2012-02-17  8:57   ` [PATCHv2 1/7] " Andy Shevchenko
  0 siblings, 2 replies; 11+ messages in thread
From: Laurent Pinchart @ 2012-02-16  6:22 UTC (permalink / raw)
  To: Andy Shevchenko; +Cc: linux-media @ vger . kernel . org, David Cohen

Hi Andy,

Thanks for the patch.

On Wednesday 15 February 2012 17:08:01 Andy Shevchenko wrote:
> Without this we have got the warnings like following if build with "make W=1
> O=/var/tmp":
>    CHECK   drivers/media/video/videobuf-vmalloc.c
>    CC [M]  drivers/media/video/videobuf-vmalloc.o
>  +cc1: warning: drivers/media/dvb/dvb-core: No such file or directory
> [enabled by default] +cc1: warning: drivers/media/dvb/frontends: No such
> file or directory [enabled by default] +cc1: warning:
> drivers/media/dvb/dvb-core: No such file or directory [enabled by default]
> +cc1: warning: drivers/media/dvb/frontends: No such file or directory
> [enabled by default] LD      drivers/media/built-in.o
> 
> Some details could be found in [1] as well.
> 
> [1] http://comments.gmane.org/gmane.linux.kbuild.devel/7733

There are several occurencies if the same issue throughout drivers/. Could you 
send a patch that fixes them all in one go ?
 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
>  drivers/media/video/Makefile |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/media/video/Makefile b/drivers/media/video/Makefile
> index 3541388..3bf0aa8 100644
> --- a/drivers/media/video/Makefile
> +++ b/drivers/media/video/Makefile
> @@ -199,6 +199,6 @@ obj-y	+= davinci/
> 
>  obj-$(CONFIG_ARCH_OMAP)	+= omap/
> 
> -ccflags-y += -Idrivers/media/dvb/dvb-core
> -ccflags-y += -Idrivers/media/dvb/frontends
> -ccflags-y += -Idrivers/media/common/tuners
> +ccflags-y += -I$(srctree)/drivers/media/dvb/dvb-core
> +ccflags-y += -I$(srctree)/drivers/media/dvb/frontends
> +ccflags-y += -I$(srctree)/drivers/media/common/tuners

The above link mentions $(src). Is that different than $(srctree) ?

-- 
Regards,

Laurent Pinchart

^ permalink raw reply	[flat|nested] 11+ messages in thread

* Re: [PATCH] media: video: append $(srctree) to -I parameters
  2012-02-16  6:22 ` Laurent Pinchart
@ 2012-02-16  9:57   ` Andy Shevchenko
  2012-02-17  8:57   ` [PATCHv2 1/7] " Andy Shevchenko
  1 sibling, 0 replies; 11+ messages in thread
From: Andy Shevchenko @ 2012-02-16  9:57 UTC (permalink / raw)
  To: Laurent Pinchart; +Cc: linux-media @ vger . kernel . org, David Cohen

On Thu, 2012-02-16 at 07:22 +0100, Laurent Pinchart wrote: 
> Hi Andy,
> 
> Thanks for the patch.
> 
> On Wednesday 15 February 2012 17:08:01 Andy Shevchenko wrote:
> > Without this we have got the warnings like following if build with "make W=1
> > O=/var/tmp":
> >    CHECK   drivers/media/video/videobuf-vmalloc.c
> >    CC [M]  drivers/media/video/videobuf-vmalloc.o
> >  +cc1: warning: drivers/media/dvb/dvb-core: No such file or directory
> > [enabled by default] +cc1: warning: drivers/media/dvb/frontends: No such
> > file or directory [enabled by default] +cc1: warning:
> > drivers/media/dvb/dvb-core: No such file or directory [enabled by default]
> > +cc1: warning: drivers/media/dvb/frontends: No such file or directory
> > [enabled by default] LD      drivers/media/built-in.o
> > 
> > Some details could be found in [1] as well.
> > 
> > [1] http://comments.gmane.org/gmane.linux.kbuild.devel/7733
> 
> There are several occurencies if the same issue throughout drivers/. Could you 
> send a patch that fixes them all in one go ?
I guess it should be a patch series anyway to help with bisecting.
Okay, I will check it and make a patches if there any issue is found.

> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > ---
> >  drivers/media/video/Makefile |    6 +++---
> >  1 files changed, 3 insertions(+), 3 deletions(-)
> > 
> > diff --git a/drivers/media/video/Makefile b/drivers/media/video/Makefile
> > index 3541388..3bf0aa8 100644
> > --- a/drivers/media/video/Makefile
> > +++ b/drivers/media/video/Makefile
> > @@ -199,6 +199,6 @@ obj-y	+= davinci/
> > 
> >  obj-$(CONFIG_ARCH_OMAP)	+= omap/
> > 
> > -ccflags-y += -Idrivers/media/dvb/dvb-core
> > -ccflags-y += -Idrivers/media/dvb/frontends
> > -ccflags-y += -Idrivers/media/common/tuners
> > +ccflags-y += -I$(srctree)/drivers/media/dvb/dvb-core
> > +ccflags-y += -I$(srctree)/drivers/media/dvb/frontends
> > +ccflags-y += -I$(srctree)/drivers/media/common/tuners
> 
> The above link mentions $(src). Is that different than $(srctree) ?
If I remember correctly $srctree points always to the root of the linux
kernel sources, but $src to the path of a certain Makefile.
In this case it seems $(src) == drivers/media/video. 

Moment...

Aha, the Documentation/kbuild/makefiles.txt clearly tells us:
    $(src)
        $(src) is a relative path which points to the directory
        where the Makefile is located. Always use $(src) when
        referring to files located in the src tree.


-- 
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy

^ permalink raw reply	[flat|nested] 11+ messages in thread

* [PATCHv2 1/7] media: video: append $(srctree) to -I parameters
  2012-02-16  6:22 ` Laurent Pinchart
  2012-02-16  9:57   ` Andy Shevchenko
@ 2012-02-17  8:57   ` Andy Shevchenko
  2012-02-17  8:57     ` [PATCHv2 2/7] media: tuners: " Andy Shevchenko
                       ` (6 more replies)
  1 sibling, 7 replies; 11+ messages in thread
From: Andy Shevchenko @ 2012-02-17  8:57 UTC (permalink / raw)
  To: Laurent Pinchart, linux-media; +Cc: Andy Shevchenko

Without this we have got the warnings like following if build with "make W=1
O=/var/tmp":
   CHECK   drivers/media/video/videobuf-vmalloc.c
   CC [M]  drivers/media/video/videobuf-vmalloc.o
 +cc1: warning: drivers/media/dvb/dvb-core: No such file or directory [enabled by default]
 +cc1: warning: drivers/media/dvb/frontends: No such file or directory [enabled by default]
 +cc1: warning: drivers/media/dvb/dvb-core: No such file or directory [enabled by default]
 +cc1: warning: drivers/media/dvb/frontends: No such file or directory [enabled by default]
   LD      drivers/media/built-in.o

Some details could be found in [1] as well.

[1] http://comments.gmane.org/gmane.linux.kbuild.devel/7733

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/media/video/Makefile |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/media/video/Makefile b/drivers/media/video/Makefile
index 3541388..3bf0aa8 100644
--- a/drivers/media/video/Makefile
+++ b/drivers/media/video/Makefile
@@ -199,6 +199,6 @@ obj-y	+= davinci/
 
 obj-$(CONFIG_ARCH_OMAP)	+= omap/
 
-ccflags-y += -Idrivers/media/dvb/dvb-core
-ccflags-y += -Idrivers/media/dvb/frontends
-ccflags-y += -Idrivers/media/common/tuners
+ccflags-y += -I$(srctree)/drivers/media/dvb/dvb-core
+ccflags-y += -I$(srctree)/drivers/media/dvb/frontends
+ccflags-y += -I$(srctree)/drivers/media/common/tuners
-- 
1.7.9


^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [PATCHv2 2/7] media: tuners: append $(srctree) to -I parameters
  2012-02-17  8:57   ` [PATCHv2 1/7] " Andy Shevchenko
@ 2012-02-17  8:57     ` Andy Shevchenko
  2012-02-17  8:57     ` [PATCHv2 3/7] media: gspca: " Andy Shevchenko
                       ` (5 subsequent siblings)
  6 siblings, 0 replies; 11+ messages in thread
From: Andy Shevchenko @ 2012-02-17  8:57 UTC (permalink / raw)
  To: Laurent Pinchart, linux-media; +Cc: Andy Shevchenko

Without this we have got the warnings like following if build with "make W=1
O=/var/tmp":
  cc1: warning: drivers/media/dvb/dvb-core: No such file or directory [enabled by default]

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/media/common/tuners/Makefile |    4 ++--
 1 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/media/common/tuners/Makefile b/drivers/media/common/tuners/Makefile
index 8295854..f80407e 100644
--- a/drivers/media/common/tuners/Makefile
+++ b/drivers/media/common/tuners/Makefile
@@ -29,5 +29,5 @@ obj-$(CONFIG_MEDIA_TUNER_MAX2165) += max2165.o
 obj-$(CONFIG_MEDIA_TUNER_TDA18218) += tda18218.o
 obj-$(CONFIG_MEDIA_TUNER_TDA18212) += tda18212.o
 
-ccflags-y += -Idrivers/media/dvb/dvb-core
-ccflags-y += -Idrivers/media/dvb/frontends
+ccflags-y += -I$(srctree)/drivers/media/dvb/dvb-core
+ccflags-y += -I$(srctree)/drivers/media/dvb/frontends
-- 
1.7.9


^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [PATCHv2 3/7] media: gspca: append $(srctree) to -I parameters
  2012-02-17  8:57   ` [PATCHv2 1/7] " Andy Shevchenko
  2012-02-17  8:57     ` [PATCHv2 2/7] media: tuners: " Andy Shevchenko
@ 2012-02-17  8:57     ` Andy Shevchenko
  2012-02-17  8:57     ` [PATCHv2 4/7] media: dvb: " Andy Shevchenko
                       ` (4 subsequent siblings)
  6 siblings, 0 replies; 11+ messages in thread
From: Andy Shevchenko @ 2012-02-17  8:57 UTC (permalink / raw)
  To: Laurent Pinchart, linux-media; +Cc: Andy Shevchenko

Without this we have got the warnings like following if build with "make W=1
O=/var/tmp":
  cc1: warning: drivers/media/dvb/dvb-core: No such file or directory [enabled by default]

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/media/video/gspca/gl860/Makefile   |    2 +-
 drivers/media/video/gspca/m5602/Makefile   |    2 +-
 drivers/media/video/gspca/stv06xx/Makefile |    2 +-
 3 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/media/video/gspca/gl860/Makefile b/drivers/media/video/gspca/gl860/Makefile
index f511ecc..773ea34 100644
--- a/drivers/media/video/gspca/gl860/Makefile
+++ b/drivers/media/video/gspca/gl860/Makefile
@@ -6,5 +6,5 @@ gspca_gl860-objs := gl860.o \
 		    gl860-ov9655.o \
 		    gl860-mi2020.o
 
-ccflags-y += -Idrivers/media/video/gspca
+ccflags-y += -I$(srctree)/drivers/media/video/gspca
 
diff --git a/drivers/media/video/gspca/m5602/Makefile b/drivers/media/video/gspca/m5602/Makefile
index 7f52961..575b75b 100644
--- a/drivers/media/video/gspca/m5602/Makefile
+++ b/drivers/media/video/gspca/m5602/Makefile
@@ -8,4 +8,4 @@ gspca_m5602-objs := m5602_core.o \
 		    m5602_s5k83a.o \
 		    m5602_s5k4aa.o
 
-ccflags-y += -Idrivers/media/video/gspca
+ccflags-y += -I$(srctree)/drivers/media/video/gspca
diff --git a/drivers/media/video/gspca/stv06xx/Makefile b/drivers/media/video/gspca/stv06xx/Makefile
index 5b318fa..38bc410 100644
--- a/drivers/media/video/gspca/stv06xx/Makefile
+++ b/drivers/media/video/gspca/stv06xx/Makefile
@@ -6,5 +6,5 @@ gspca_stv06xx-objs := stv06xx.o \
 		      stv06xx_pb0100.o \
 		      stv06xx_st6422.o
 
-ccflags-y += -Idrivers/media/video/gspca
+ccflags-y += -I$(srctree)/drivers/media/video/gspca
 
-- 
1.7.9


^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [PATCHv2 4/7] media: dvb: append $(srctree) to -I parameters
  2012-02-17  8:57   ` [PATCHv2 1/7] " Andy Shevchenko
  2012-02-17  8:57     ` [PATCHv2 2/7] media: tuners: " Andy Shevchenko
  2012-02-17  8:57     ` [PATCHv2 3/7] media: gspca: " Andy Shevchenko
@ 2012-02-17  8:57     ` Andy Shevchenko
  2012-02-17  8:57     ` [PATCHv2 5/7] media: ivtv: " Andy Shevchenko
                       ` (3 subsequent siblings)
  6 siblings, 0 replies; 11+ messages in thread
From: Andy Shevchenko @ 2012-02-17  8:57 UTC (permalink / raw)
  To: Laurent Pinchart, linux-media; +Cc: Andy Shevchenko

Without this we have got the warnings like following if build with "make W=1
O=/var/tmp":
  cc1: warning: drivers/media/dvb/dvb-core: No such file or directory [enabled by default]

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/media/dvb/dvb-usb/Makefile   |    7 ++++---
 drivers/media/dvb/frontends/Makefile |    4 ++--
 2 files changed, 6 insertions(+), 5 deletions(-)

diff --git a/drivers/media/dvb/dvb-usb/Makefile b/drivers/media/dvb/dvb-usb/Makefile
index d9549cb..2e64f84 100644
--- a/drivers/media/dvb/dvb-usb/Makefile
+++ b/drivers/media/dvb/dvb-usb/Makefile
@@ -107,8 +107,9 @@ obj-$(CONFIG_DVB_USB_MXL111SF) += dvb-usb-mxl111sf.o
 obj-$(CONFIG_DVB_USB_MXL111SF) += mxl111sf-demod.o
 obj-$(CONFIG_DVB_USB_MXL111SF) += mxl111sf-tuner.o
 
-ccflags-y += -Idrivers/media/dvb/dvb-core/ -Idrivers/media/dvb/frontends/
+ccflags-y += -I$(srctree)/drivers/media/dvb/dvb-core
+ccflags-y += -I$(srctree)/drivers/media/dvb/frontends/
 # due to tuner-xc3028
-ccflags-y += -Idrivers/media/common/tuners
-EXTRA_CFLAGS += -Idrivers/media/dvb/ttpci
+ccflags-y += -I$(srctree)/drivers/media/common/tuners
+ccflags-y += -I$(srctree)/drivers/media/dvb/ttpci
 
diff --git a/drivers/media/dvb/frontends/Makefile b/drivers/media/dvb/frontends/Makefile
index 00a2063..90320f1 100644
--- a/drivers/media/dvb/frontends/Makefile
+++ b/drivers/media/dvb/frontends/Makefile
@@ -2,8 +2,8 @@
 # Makefile for the kernel DVB frontend device drivers.
 #
 
-ccflags-y += -Idrivers/media/dvb/dvb-core/
-ccflags-y += -Idrivers/media/common/tuners/
+ccflags-y += -I$(srctree)/drivers/media/dvb/dvb-core/
+ccflags-y += -I$(srctree)/drivers/media/common/tuners/
 
 stb0899-objs = stb0899_drv.o stb0899_algo.o
 stv0900-objs = stv0900_core.o stv0900_sw.o
-- 
1.7.9


^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [PATCHv2 5/7] media: ivtv: append $(srctree) to -I parameters
  2012-02-17  8:57   ` [PATCHv2 1/7] " Andy Shevchenko
                       ` (2 preceding siblings ...)
  2012-02-17  8:57     ` [PATCHv2 4/7] media: dvb: " Andy Shevchenko
@ 2012-02-17  8:57     ` Andy Shevchenko
  2012-02-17  8:57     ` [PATCHv2 6/7] media: saa7164: " Andy Shevchenko
                       ` (2 subsequent siblings)
  6 siblings, 0 replies; 11+ messages in thread
From: Andy Shevchenko @ 2012-02-17  8:57 UTC (permalink / raw)
  To: Laurent Pinchart, linux-media; +Cc: Andy Shevchenko

Without this we have got the warnings like following if build with "make W=1
O=/var/tmp":
  cc1: warning: drivers/media/dvb/dvb-core: No such file or directory [enabled by default]

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/media/video/ivtv/Makefile |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/media/video/ivtv/Makefile b/drivers/media/video/ivtv/Makefile
index 71ab76a..77de8a4 100644
--- a/drivers/media/video/ivtv/Makefile
+++ b/drivers/media/video/ivtv/Makefile
@@ -7,8 +7,8 @@ ivtv-objs	:= ivtv-routing.o ivtv-cards.o ivtv-controls.o \
 obj-$(CONFIG_VIDEO_IVTV) += ivtv.o
 obj-$(CONFIG_VIDEO_FB_IVTV) += ivtvfb.o
 
-ccflags-y += -Idrivers/media/video
-ccflags-y += -Idrivers/media/common/tuners
-ccflags-y += -Idrivers/media/dvb/dvb-core
-ccflags-y += -Idrivers/media/dvb/frontends
+ccflags-y += -I$(srctree)/drivers/media/video
+ccflags-y += -I$(srctree)/drivers/media/common/tuners
+ccflags-y += -I$(srctree)/drivers/media/dvb/dvb-core
+ccflags-y += -I$(srctree)/drivers/media/dvb/frontends
 
-- 
1.7.9


^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [PATCHv2 6/7] media: saa7164: append $(srctree) to -I parameters
  2012-02-17  8:57   ` [PATCHv2 1/7] " Andy Shevchenko
                       ` (3 preceding siblings ...)
  2012-02-17  8:57     ` [PATCHv2 5/7] media: ivtv: " Andy Shevchenko
@ 2012-02-17  8:57     ` Andy Shevchenko
  2012-02-17  8:57     ` [PATCHv2 7/7] media: saa7134: " Andy Shevchenko
  2012-02-17 18:19     ` [PATCHv2 1/7] media: video: " Laurent Pinchart
  6 siblings, 0 replies; 11+ messages in thread
From: Andy Shevchenko @ 2012-02-17  8:57 UTC (permalink / raw)
  To: Laurent Pinchart, linux-media; +Cc: Andy Shevchenko

Without this we have got the warnings like following if build with "make W=1
O=/var/tmp":
  cc1: warning: drivers/media/dvb/dvb-core: No such file or directory [enabled by default]

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/media/video/saa7164/Makefile |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/media/video/saa7164/Makefile b/drivers/media/video/saa7164/Makefile
index ecd5811..068443a 100644
--- a/drivers/media/video/saa7164/Makefile
+++ b/drivers/media/video/saa7164/Makefile
@@ -4,9 +4,9 @@ saa7164-objs	:= saa7164-cards.o saa7164-core.o saa7164-i2c.o saa7164-dvb.o \
 
 obj-$(CONFIG_VIDEO_SAA7164) += saa7164.o
 
-ccflags-y += -Idrivers/media/video
-ccflags-y += -Idrivers/media/common/tuners
-ccflags-y += -Idrivers/media/dvb/dvb-core
-ccflags-y += -Idrivers/media/dvb/frontends
+ccflags-y += -I$(srctree)/drivers/media/video
+ccflags-y += -I$(srctree)/drivers/media/common/tuners
+ccflags-y += -I$(srctree)/drivers/media/dvb/dvb-core
+ccflags-y += -I$(srctree)/drivers/media/dvb/frontends
 
 ccflags-y += $(extra-cflags-y) $(extra-cflags-m)
-- 
1.7.9


^ permalink raw reply related	[flat|nested] 11+ messages in thread

* [PATCHv2 7/7] media: saa7134: append $(srctree) to -I parameters
  2012-02-17  8:57   ` [PATCHv2 1/7] " Andy Shevchenko
                       ` (4 preceding siblings ...)
  2012-02-17  8:57     ` [PATCHv2 6/7] media: saa7164: " Andy Shevchenko
@ 2012-02-17  8:57     ` Andy Shevchenko
  2012-02-17 18:19     ` [PATCHv2 1/7] media: video: " Laurent Pinchart
  6 siblings, 0 replies; 11+ messages in thread
From: Andy Shevchenko @ 2012-02-17  8:57 UTC (permalink / raw)
  To: Laurent Pinchart, linux-media; +Cc: Andy Shevchenko

Without this we have got the warnings like following if build with "make W=1
O=/var/tmp":
  cc1: warning: drivers/media/dvb/dvb-core: No such file or directory [enabled by default]

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
 drivers/media/video/saa7134/Makefile |    8 ++++----
 1 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/drivers/media/video/saa7134/Makefile b/drivers/media/video/saa7134/Makefile
index a646ccf..da38993 100644
--- a/drivers/media/video/saa7134/Makefile
+++ b/drivers/media/video/saa7134/Makefile
@@ -10,7 +10,7 @@ obj-$(CONFIG_VIDEO_SAA7134_ALSA) += saa7134-alsa.o
 
 obj-$(CONFIG_VIDEO_SAA7134_DVB) += saa7134-dvb.o
 
-ccflags-y += -Idrivers/media/video
-ccflags-y += -Idrivers/media/common/tuners
-ccflags-y += -Idrivers/media/dvb/dvb-core
-ccflags-y += -Idrivers/media/dvb/frontends
+ccflags-y += -I$(srctree)/drivers/media/video
+ccflags-y += -I$(srctree)/drivers/media/common/tuners
+ccflags-y += -I$(srctree)/drivers/media/dvb/dvb-core
+ccflags-y += -I$(srctree)/drivers/media/dvb/frontends
-- 
1.7.9


^ permalink raw reply related	[flat|nested] 11+ messages in thread

* Re: [PATCHv2 1/7] media: video: append $(srctree) to -I parameters
  2012-02-17  8:57   ` [PATCHv2 1/7] " Andy Shevchenko
                       ` (5 preceding siblings ...)
  2012-02-17  8:57     ` [PATCHv2 7/7] media: saa7134: " Andy Shevchenko
@ 2012-02-17 18:19     ` Laurent Pinchart
  6 siblings, 0 replies; 11+ messages in thread
From: Laurent Pinchart @ 2012-02-17 18:19 UTC (permalink / raw)
  To: Andy Shevchenko; +Cc: linux-media

Hi Andy,

Thanks for the patches.

On Friday 17 February 2012 10:57:07 Andy Shevchenko wrote:
> Without this we have got the warnings like following if build with "make W=1
> O=/var/tmp":
>    CHECK   drivers/media/video/videobuf-vmalloc.c
>    CC [M]  drivers/media/video/videobuf-vmalloc.o
>  +cc1: warning: drivers/media/dvb/dvb-core: No such file or directory
> [enabled by default] +cc1: warning: drivers/media/dvb/frontends: No such
> file or directory [enabled by default] +cc1: warning:
> drivers/media/dvb/dvb-core: No such file or directory [enabled by default]
> +cc1: warning: drivers/media/dvb/frontends: No such file or directory
> [enabled by default] LD      drivers/media/built-in.o
> 
> Some details could be found in [1] as well.
> 
> [1] http://comments.gmane.org/gmane.linux.kbuild.devel/7733
> 
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>

For the whole series,

Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
>  drivers/media/video/Makefile |    6 +++---
>  1 files changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/media/video/Makefile b/drivers/media/video/Makefile
> index 3541388..3bf0aa8 100644
> --- a/drivers/media/video/Makefile
> +++ b/drivers/media/video/Makefile
> @@ -199,6 +199,6 @@ obj-y	+= davinci/
> 
>  obj-$(CONFIG_ARCH_OMAP)	+= omap/
> 
> -ccflags-y += -Idrivers/media/dvb/dvb-core
> -ccflags-y += -Idrivers/media/dvb/frontends
> -ccflags-y += -Idrivers/media/common/tuners
> +ccflags-y += -I$(srctree)/drivers/media/dvb/dvb-core
> +ccflags-y += -I$(srctree)/drivers/media/dvb/frontends
> +ccflags-y += -I$(srctree)/drivers/media/common/tuners

-- 
Regards,

Laurent Pinchart

^ permalink raw reply	[flat|nested] 11+ messages in thread

end of thread, other threads:[~2012-02-17 18:21 UTC | newest]

Thread overview: 11+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-02-15 15:08 [PATCH] media: video: append $(srctree) to -I parameters Andy Shevchenko
2012-02-16  6:22 ` Laurent Pinchart
2012-02-16  9:57   ` Andy Shevchenko
2012-02-17  8:57   ` [PATCHv2 1/7] " Andy Shevchenko
2012-02-17  8:57     ` [PATCHv2 2/7] media: tuners: " Andy Shevchenko
2012-02-17  8:57     ` [PATCHv2 3/7] media: gspca: " Andy Shevchenko
2012-02-17  8:57     ` [PATCHv2 4/7] media: dvb: " Andy Shevchenko
2012-02-17  8:57     ` [PATCHv2 5/7] media: ivtv: " Andy Shevchenko
2012-02-17  8:57     ` [PATCHv2 6/7] media: saa7164: " Andy Shevchenko
2012-02-17  8:57     ` [PATCHv2 7/7] media: saa7134: " Andy Shevchenko
2012-02-17 18:19     ` [PATCHv2 1/7] media: video: " Laurent Pinchart

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox