From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Jacob Chen <jacob-chen@iotwrt.com>
Cc: linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
heiko@sntech.de, robh+dt@kernel.org, mchehab@kernel.org,
linux-media@vger.kernel.org,
laurent.pinchart+renesas@ideasonboard.com,
hans.verkuil@cisco.com, s.nawrocki@samsung.com,
tfiga@chromium.org, nicolas@ndufresne.ca
Subject: Re: [PATCH v2 5/6] ARM: dts: rockchip: enable RGA for rk3288 devices
Date: Sat, 15 Jul 2017 12:16:55 +0300 [thread overview]
Message-ID: <2238838.k7NpPUxaC0@avalon> (raw)
In-Reply-To: <1500101920-24039-6-git-send-email-jacob-chen@iotwrt.com>
Hi Jacob,
Thank you for the patch.
On Saturday 15 Jul 2017 14:58:39 Jacob Chen wrote:
> Signed-off-by: Jacob Chen <jacob-chen@iotwrt.com>
> ---
> arch/arm/boot/dts/rk3288-evb.dtsi | 4 ++++
> arch/arm/boot/dts/rk3288-firefly-reload-core.dtsi | 4 ++++
> arch/arm/boot/dts/rk3288-firefly.dtsi | 4 ++++
> arch/arm/boot/dts/rk3288-miqi.dts | 4 ++++
> arch/arm/boot/dts/rk3288-popmetal.dts | 4 ++++
> arch/arm/boot/dts/rk3288-tinker.dts | 4 ++++
Some boards are missing from this list (Fennec, Phycore, ...) What criteria
have you used to decide on which ones to enable the RGA ? That should be
explained in the commit message.
> 6 files changed, 24 insertions(+)
>
> diff --git a/arch/arm/boot/dts/rk3288-evb.dtsi
> b/arch/arm/boot/dts/rk3288-evb.dtsi index 4905760..ec12162 100644
> --- a/arch/arm/boot/dts/rk3288-evb.dtsi
> +++ b/arch/arm/boot/dts/rk3288-evb.dtsi
> @@ -379,6 +379,10 @@
> };
> };
>
> +&rga {
> + status = "okay";
> +};
> +
> &usbphy {
> status = "okay";
> };
> diff --git a/arch/arm/boot/dts/rk3288-firefly-reload-core.dtsi
> b/arch/arm/boot/dts/rk3288-firefly-reload-core.dtsi index 8134966..fffa92e2
> 100644
> --- a/arch/arm/boot/dts/rk3288-firefly-reload-core.dtsi
> +++ b/arch/arm/boot/dts/rk3288-firefly-reload-core.dtsi
> @@ -283,6 +283,10 @@
> };
> };
>
> +&rga {
> + status = "okay";
> +};
> +
> &tsadc {
> rockchip,hw-tshut-mode = <0>;
> rockchip,hw-tshut-polarity = <0>;
> diff --git a/arch/arm/boot/dts/rk3288-firefly.dtsi
> b/arch/arm/boot/dts/rk3288-firefly.dtsi index f520589..74a6ce5 100644
> --- a/arch/arm/boot/dts/rk3288-firefly.dtsi
> +++ b/arch/arm/boot/dts/rk3288-firefly.dtsi
> @@ -500,6 +500,10 @@
> };
> };
>
> +&rga {
> + status = "okay";
> +};
> +
> &saradc {
> vref-supply = <&vcc_18>;
> status = "okay";
> diff --git a/arch/arm/boot/dts/rk3288-miqi.dts
> b/arch/arm/boot/dts/rk3288-miqi.dts index 21326f3..dc5e6bd 100644
> --- a/arch/arm/boot/dts/rk3288-miqi.dts
> +++ b/arch/arm/boot/dts/rk3288-miqi.dts
> @@ -401,6 +401,10 @@
> };
> };
>
> +&rga {
> + status = "okay";
> +};
> +
> &saradc {
> vref-supply = <&vcc_18>;
> status = "okay";
> diff --git a/arch/arm/boot/dts/rk3288-popmetal.dts
> b/arch/arm/boot/dts/rk3288-popmetal.dts index aa1f9ec..362e5aa 100644
> --- a/arch/arm/boot/dts/rk3288-popmetal.dts
> +++ b/arch/arm/boot/dts/rk3288-popmetal.dts
> @@ -490,6 +490,10 @@
> };
> };
>
> +&rga {
> + status = "okay";
> +};
> +
> &tsadc {
> rockchip,hw-tshut-mode = <0>;
> rockchip,hw-tshut-polarity = <0>;
> diff --git a/arch/arm/boot/dts/rk3288-tinker.dts
> b/arch/arm/boot/dts/rk3288-tinker.dts index 525b0e5..1a8c149 100644
> --- a/arch/arm/boot/dts/rk3288-tinker.dts
> +++ b/arch/arm/boot/dts/rk3288-tinker.dts
> @@ -460,6 +460,10 @@
> status = "okay";
> };
>
> +&rga {
> + status = "okay";
> +};
> +
> &saradc {
> vref-supply = <&vcc18_ldo1>;
> status ="okay";
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2017-07-15 9:16 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-15 6:58 [PATCH v2 0/6] Add Rockchip RGA V4l2 support Jacob Chen
2017-07-15 6:58 ` [PATCH v2 1/6] [media] v4l: add blend modes controls Jacob Chen
2017-07-15 9:31 ` Laurent Pinchart
2017-07-15 6:58 ` [PATCH v2 2/6] [media] rockchip/rga: v4l2 m2m support Jacob Chen
2017-07-15 9:42 ` Laurent Pinchart
2017-07-15 16:49 ` Personnel
2017-07-16 4:19 ` Jacob Chen
2017-07-17 2:43 ` Laurent Pinchart
2017-07-17 3:43 ` Jacob Chen
2017-07-17 2:37 ` Laurent Pinchart
2017-07-17 14:45 ` Nicolas Dufresne
2017-07-19 10:40 ` Jacob Chen
2017-07-15 17:42 ` kbuild test robot
2017-07-15 17:42 ` [PATCH] rockchip/rga: fix semicolon.cocci warnings kbuild test robot
2017-07-15 6:58 ` [PATCH v2 3/6] ARM: dts: rockchip: add RGA device node for RK3288 Jacob Chen
2017-07-15 8:12 ` Heiko Stuebner
2017-07-15 6:58 ` [PATCH v2 4/6] ARM: dts: rockchip: add RGA device node for RK3399 Jacob Chen
2017-07-15 6:58 ` [PATCH v2 5/6] ARM: dts: rockchip: enable RGA for rk3288 devices Jacob Chen
2017-07-15 9:16 ` Laurent Pinchart [this message]
2017-07-16 4:23 ` Jacob Chen
2017-07-17 2:28 ` Laurent Pinchart
2017-07-17 3:09 ` Jacob Chen
2017-07-15 6:58 ` [PATCH v2 6/6] dt-bindings: Document the Rockchip RGA bindings Jacob Chen
2017-07-15 9:23 ` Laurent Pinchart
2017-07-16 16:07 ` Heiko Stuebner
2017-07-17 2:21 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2238838.k7NpPUxaC0@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=devicetree@vger.kernel.org \
--cc=hans.verkuil@cisco.com \
--cc=heiko@sntech.de \
--cc=jacob-chen@iotwrt.com \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=mchehab@kernel.org \
--cc=nicolas@ndufresne.ca \
--cc=robh+dt@kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=tfiga@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).