From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Kruno Mrak <kruno.mrak@matrix-vision.de>
Cc: linux-media@vger.kernel.org, sakari.ailus@iki.fi
Subject: Re: omap3isp: sequence number in v4l2 buffer not incremented
Date: Fri, 10 Feb 2012 18:03:51 +0100 [thread overview]
Message-ID: <2282092.nIujHkTqeG@avalon> (raw)
In-Reply-To: <4F35434E.6020405@matrix-vision.de>
Hi Kruno,
On Friday 10 February 2012 17:18:22 Kruno Mrak wrote:
> Laurent,
>
> thank you for the patch.
> It was a bit tricky to get it work as our kernel is based
> on 2.6.38, but i succeeded.
> The frame_number is incremented now.
Thanks for the confirmation. I'll test the patch with the CCP2 and CSI2
receivers, and I'll then push it to mainline.
> The following changes are not clear to me, are they really necessary to
> get frame_number incremented?
It isn't when using the CCDC parallel input. It removes frame number
incrementation from the CCP2 module, as the frame number is now incremented in
the CCDC module.
> @@ -350,7 +337,6 @@ static void ccp2_lcx_config(struct isp_ccp2_device
> *ccp2,
> ISPCCP2_LC01_IRQSTATUS_LC0_CRC_IRQ |
> ISPCCP2_LC01_IRQSTATUS_LC0_FSP_IRQ |
> ISPCCP2_LC01_IRQSTATUS_LC0_FW_IRQ |
> - ISPCCP2_LC01_IRQSTATUS_LC0_FS_IRQ |
> ISPCCP2_LC01_IRQSTATUS_LC0_FSC_IRQ |
> ISPCCP2_LC01_IRQSTATUS_LC0_SSC_IRQ;
>
> @@ -378,21 +378,17 @@ static void csi2_timing_config(struct isp_device *isp,
> static void csi2_irq_ctx_set(struct isp_device *isp,
> struct isp_csi2_device *csi2, int enable)
> {
> - u32 reg = ISPCSI2_CTX_IRQSTATUS_FE_IRQ;
> int i;
>
> - if (csi2->use_fs_irq)
> - reg |= ISPCSI2_CTX_IRQSTATUS_FS_IRQ;
> -
> for (i = 0; i < 8; i++) {
> - isp_reg_writel(isp, reg, csi2->regs1,
> + isp_reg_writel(isp, ISPCSI2_CTX_IRQSTATUS_FE_IRQ, csi2->regs1,
> ISPCSI2_CTX_IRQSTATUS(i));
> if (enable)
> isp_reg_set(isp, csi2->regs1, ISPCSI2_CTX_IRQENABLE(i),
> - reg);
> + ISPCSI2_CTX_IRQSTATUS_FE_IRQ);
> else
> isp_reg_clr(isp, csi2->regs1, ISPCSI2_CTX_IRQENABLE(i),
> - reg);
> + ISPCSI2_CTX_IRQSTATUS_FE_IRQ);
> }
> }
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2012-02-10 17:03 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-25 15:34 omap3isp: sequence number in v4l2 buffer not incremented Kruno Mrak
2012-02-09 16:08 ` Laurent Pinchart
2012-02-10 16:18 ` Kruno Mrak
2012-02-10 17:03 ` Laurent Pinchart [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-01-16 10:32 Kruno Mrak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2282092.nIujHkTqeG@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=kruno.mrak@matrix-vision.de \
--cc=linux-media@vger.kernel.org \
--cc=sakari.ailus@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).