Re: [PATCH v4 02/14] media: ipu6: Drop MMU hardware initialisation in probe()

[Bingbu Cao <bingbu.cao@linux.intel.com>]

Reviewed-by: Bingbu Cao <bingbu.cao@intel.com>

On 1/8/26 4:16 PM, Sakari Ailus wrote:
> The MMU hardware is initialised and cleaned up in the runtime PM resume
> callbacks. Do not do this in probe().
> 
> Signed-off-by: Sakari Ailus <sakari.ailus@linux.intel.com>
> ---
>  drivers/media/pci/intel/ipu6/ipu6-isys.c | 8 --------
>  1 file changed, 8 deletions(-)
> 
> diff --git a/drivers/media/pci/intel/ipu6/ipu6-isys.c b/drivers/media/pci/intel/ipu6/ipu6-isys.c
> index fc0ec0a4b8f5..226bfae21c16 100644
> --- a/drivers/media/pci/intel/ipu6/ipu6-isys.c
> +++ b/drivers/media/pci/intel/ipu6/ipu6-isys.c
> @@ -1070,10 +1070,6 @@ static int isys_probe(struct auxiliary_device *auxdev,
>  	if (!isys->csi2)
>  		return -ENOMEM;
>  
> -	ret = ipu6_mmu_hw_init(adev->mmu);
> -	if (ret)
> -		return ret;
> -
>  	/* initial sensor type */
>  	isys->sensor_type = isys->pdata->ipdata->sensor_type_start;
>  
> @@ -1125,8 +1121,6 @@ static int isys_probe(struct auxiliary_device *auxdev,
>  	if (ret)
>  		goto free_fw_msg_bufs;
>  
> -	ipu6_mmu_hw_cleanup(adev->mmu);
> -
>  	return 0;
>  
>  free_fw_msg_bufs:
> @@ -1148,8 +1142,6 @@ static int isys_probe(struct auxiliary_device *auxdev,
>  	mutex_destroy(&isys->mutex);
>  	mutex_destroy(&isys->stream_mutex);
>  
> -	ipu6_mmu_hw_cleanup(adev->mmu);
> -
>  	return ret;
>  }
>  
> 

-- 
Best regards,
Bingbu Cao