* [PATCH] media: platform: Drop OF dependency of VIDEO_RENESAS_VSP1
@ 2018-02-26 18:09 Geert Uytterhoeven
2018-02-27 8:42 ` Simon Horman
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Geert Uytterhoeven @ 2018-02-26 18:09 UTC (permalink / raw)
To: Mauro Carvalho Chehab, Laurent Pinchart
Cc: linux-media, linux-renesas-soc, Geert Uytterhoeven
VIDEO_RENESAS_VSP1 depends on ARCH_RENESAS && OF.
As ARCH_RENESAS implies OF, the latter can be dropped.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
drivers/media/platform/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig
index 614fbef08ddcabb0..2b8b1ad0edd9eb31 100644
--- a/drivers/media/platform/Kconfig
+++ b/drivers/media/platform/Kconfig
@@ -448,7 +448,7 @@ config VIDEO_RENESAS_FCP
config VIDEO_RENESAS_VSP1
tristate "Renesas VSP1 Video Processing Engine"
depends on VIDEO_V4L2 && VIDEO_V4L2_SUBDEV_API && HAS_DMA
- depends on (ARCH_RENESAS && OF) || COMPILE_TEST
+ depends on ARCH_RENESAS || COMPILE_TEST
depends on (!ARM64 && !VIDEO_RENESAS_FCP) || VIDEO_RENESAS_FCP
select VIDEOBUF2_DMA_CONTIG
select VIDEOBUF2_VMALLOC
--
2.7.4
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] media: platform: Drop OF dependency of VIDEO_RENESAS_VSP1
2018-02-26 18:09 [PATCH] media: platform: Drop OF dependency of VIDEO_RENESAS_VSP1 Geert Uytterhoeven
@ 2018-02-27 8:42 ` Simon Horman
2018-02-27 9:30 ` Laurent Pinchart
2018-03-06 16:25 ` Mauro Carvalho Chehab
2 siblings, 0 replies; 7+ messages in thread
From: Simon Horman @ 2018-02-27 8:42 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Mauro Carvalho Chehab, Laurent Pinchart, linux-media,
linux-renesas-soc
On Mon, Feb 26, 2018 at 07:09:10PM +0100, Geert Uytterhoeven wrote:
> VIDEO_RENESAS_VSP1 depends on ARCH_RENESAS && OF.
> As ARCH_RENESAS implies OF, the latter can be dropped.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
My reasoning is that ARCH_RENESAS depends on ARCH_MULTI_V7,
which in turn depends on ARCH_MULTIPLATFORM which selects OF via USE_OF
Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] media: platform: Drop OF dependency of VIDEO_RENESAS_VSP1
2018-02-26 18:09 [PATCH] media: platform: Drop OF dependency of VIDEO_RENESAS_VSP1 Geert Uytterhoeven
2018-02-27 8:42 ` Simon Horman
@ 2018-02-27 9:30 ` Laurent Pinchart
2018-03-06 16:25 ` Mauro Carvalho Chehab
2 siblings, 0 replies; 7+ messages in thread
From: Laurent Pinchart @ 2018-02-27 9:30 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: Mauro Carvalho Chehab, linux-media, linux-renesas-soc
Hi Geert,
Thank you for the patch.
On Monday, 26 February 2018 20:09:10 EET Geert Uytterhoeven wrote:
> VIDEO_RENESAS_VSP1 depends on ARCH_RENESAS && OF.
> As ARCH_RENESAS implies OF, the latter can be dropped.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
and taken in my tree.
> ---
> drivers/media/platform/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig
> index 614fbef08ddcabb0..2b8b1ad0edd9eb31 100644
> --- a/drivers/media/platform/Kconfig
> +++ b/drivers/media/platform/Kconfig
> @@ -448,7 +448,7 @@ config VIDEO_RENESAS_FCP
> config VIDEO_RENESAS_VSP1
> tristate "Renesas VSP1 Video Processing Engine"
> depends on VIDEO_V4L2 && VIDEO_V4L2_SUBDEV_API && HAS_DMA
> - depends on (ARCH_RENESAS && OF) || COMPILE_TEST
> + depends on ARCH_RENESAS || COMPILE_TEST
> depends on (!ARM64 && !VIDEO_RENESAS_FCP) || VIDEO_RENESAS_FCP
> select VIDEOBUF2_DMA_CONTIG
> select VIDEOBUF2_VMALLOC
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] media: platform: Drop OF dependency of VIDEO_RENESAS_VSP1
2018-02-26 18:09 [PATCH] media: platform: Drop OF dependency of VIDEO_RENESAS_VSP1 Geert Uytterhoeven
2018-02-27 8:42 ` Simon Horman
2018-02-27 9:30 ` Laurent Pinchart
@ 2018-03-06 16:25 ` Mauro Carvalho Chehab
2018-03-06 16:35 ` Laurent Pinchart
2 siblings, 1 reply; 7+ messages in thread
From: Mauro Carvalho Chehab @ 2018-03-06 16:25 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: Laurent Pinchart, linux-media, linux-renesas-soc
Em Mon, 26 Feb 2018 19:09:10 +0100
Geert Uytterhoeven <geert+renesas@glider.be> escreveu:
> VIDEO_RENESAS_VSP1 depends on ARCH_RENESAS && OF.
> As ARCH_RENESAS implies OF, the latter can be dropped.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> drivers/media/platform/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/Kconfig b/drivers/media/platform/Kconfig
> index 614fbef08ddcabb0..2b8b1ad0edd9eb31 100644
> --- a/drivers/media/platform/Kconfig
> +++ b/drivers/media/platform/Kconfig
> @@ -448,7 +448,7 @@ config VIDEO_RENESAS_FCP
> config VIDEO_RENESAS_VSP1
> tristate "Renesas VSP1 Video Processing Engine"
> depends on VIDEO_V4L2 && VIDEO_V4L2_SUBDEV_API && HAS_DMA
> - depends on (ARCH_RENESAS && OF) || COMPILE_TEST
> + depends on ARCH_RENESAS || COMPILE_TEST
That is not correct!
COMPILE_TEST doesn't depend on OF. With this patch, it will likely
cause build failures with randconfigs.
> depends on (!ARM64 && !VIDEO_RENESAS_FCP) || VIDEO_RENESAS_FCP
> select VIDEOBUF2_DMA_CONTIG
> select VIDEOBUF2_VMALLOC
Thanks,
Mauro
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] media: platform: Drop OF dependency of VIDEO_RENESAS_VSP1
2018-03-06 16:25 ` Mauro Carvalho Chehab
@ 2018-03-06 16:35 ` Laurent Pinchart
2018-03-06 16:37 ` Mauro Carvalho Chehab
0 siblings, 1 reply; 7+ messages in thread
From: Laurent Pinchart @ 2018-03-06 16:35 UTC (permalink / raw)
To: Mauro Carvalho Chehab; +Cc: Geert Uytterhoeven, linux-media, linux-renesas-soc
Hi Mauro,
On Tuesday, 6 March 2018 18:25:15 EET Mauro Carvalho Chehab wrote:
> Em Mon, 26 Feb 2018 19:09:10 +0100 Geert Uytterhoeven escreveu:
> > VIDEO_RENESAS_VSP1 depends on ARCH_RENESAS && OF.
> > As ARCH_RENESAS implies OF, the latter can be dropped.
> >
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > ---
> >
> > drivers/media/platform/Kconfig | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/media/platform/Kconfig
> > b/drivers/media/platform/Kconfig index 614fbef08ddcabb0..2b8b1ad0edd9eb31
> > 100644
> > --- a/drivers/media/platform/Kconfig
> > +++ b/drivers/media/platform/Kconfig
> > @@ -448,7 +448,7 @@ config VIDEO_RENESAS_FCP
> >
> > config VIDEO_RENESAS_VSP1
> >
> > tristate "Renesas VSP1 Video Processing Engine"
> > depends on VIDEO_V4L2 && VIDEO_V4L2_SUBDEV_API && HAS_DMA
> >
> > - depends on (ARCH_RENESAS && OF) || COMPILE_TEST
> > + depends on ARCH_RENESAS || COMPILE_TEST
>
> That is not correct!
>
> COMPILE_TEST doesn't depend on OF. With this patch, it will likely
> cause build failures with randconfigs.
ARCH_RENESAS implies OF, so replacing (ARCH_RENESAS && OF) with ARCH_RENESAS
doesn't change anything. The driver can be compiled with COMPILE_TEST and !OF
both before and after this patch.
> > depends on (!ARM64 && !VIDEO_RENESAS_FCP) || VIDEO_RENESAS_FCP
> > select VIDEOBUF2_DMA_CONTIG
> > select VIDEOBUF2_VMALLOC
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] media: platform: Drop OF dependency of VIDEO_RENESAS_VSP1
2018-03-06 16:35 ` Laurent Pinchart
@ 2018-03-06 16:37 ` Mauro Carvalho Chehab
2018-03-07 8:14 ` Simon Horman
0 siblings, 1 reply; 7+ messages in thread
From: Mauro Carvalho Chehab @ 2018-03-06 16:37 UTC (permalink / raw)
To: Laurent Pinchart; +Cc: Geert Uytterhoeven, linux-media, linux-renesas-soc
Em Tue, 06 Mar 2018 18:35:32 +0200
Laurent Pinchart <laurent.pinchart@ideasonboard.com> escreveu:
> Hi Mauro,
>
> On Tuesday, 6 March 2018 18:25:15 EET Mauro Carvalho Chehab wrote:
> > Em Mon, 26 Feb 2018 19:09:10 +0100 Geert Uytterhoeven escreveu:
> > > VIDEO_RENESAS_VSP1 depends on ARCH_RENESAS && OF.
> > > As ARCH_RENESAS implies OF, the latter can be dropped.
> > >
> > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > > ---
> > >
> > > drivers/media/platform/Kconfig | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/media/platform/Kconfig
> > > b/drivers/media/platform/Kconfig index 614fbef08ddcabb0..2b8b1ad0edd9eb31
> > > 100644
> > > --- a/drivers/media/platform/Kconfig
> > > +++ b/drivers/media/platform/Kconfig
> > > @@ -448,7 +448,7 @@ config VIDEO_RENESAS_FCP
> > >
> > > config VIDEO_RENESAS_VSP1
> > >
> > > tristate "Renesas VSP1 Video Processing Engine"
> > > depends on VIDEO_V4L2 && VIDEO_V4L2_SUBDEV_API && HAS_DMA
> > >
> > > - depends on (ARCH_RENESAS && OF) || COMPILE_TEST
> > > + depends on ARCH_RENESAS || COMPILE_TEST
> >
> > That is not correct!
> >
> > COMPILE_TEST doesn't depend on OF. With this patch, it will likely
> > cause build failures with randconfigs.
>
> ARCH_RENESAS implies OF, so replacing (ARCH_RENESAS && OF) with ARCH_RENESAS
> doesn't change anything. The driver can be compiled with COMPILE_TEST and !OF
> both before and after this patch.
OK!
>
> > > depends on (!ARM64 && !VIDEO_RENESAS_FCP) || VIDEO_RENESAS_FCP
> > > select VIDEOBUF2_DMA_CONTIG
> > > select VIDEOBUF2_VMALLOC
>
Thanks,
Mauro
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] media: platform: Drop OF dependency of VIDEO_RENESAS_VSP1
2018-03-06 16:37 ` Mauro Carvalho Chehab
@ 2018-03-07 8:14 ` Simon Horman
0 siblings, 0 replies; 7+ messages in thread
From: Simon Horman @ 2018-03-07 8:14 UTC (permalink / raw)
To: Mauro Carvalho Chehab
Cc: Laurent Pinchart, Geert Uytterhoeven, linux-media,
linux-renesas-soc
On Tue, Mar 06, 2018 at 01:37:38PM -0300, Mauro Carvalho Chehab wrote:
> Em Tue, 06 Mar 2018 18:35:32 +0200
> Laurent Pinchart <laurent.pinchart@ideasonboard.com> escreveu:
>
> > Hi Mauro,
> >
> > On Tuesday, 6 March 2018 18:25:15 EET Mauro Carvalho Chehab wrote:
> > > Em Mon, 26 Feb 2018 19:09:10 +0100 Geert Uytterhoeven escreveu:
> > > > VIDEO_RENESAS_VSP1 depends on ARCH_RENESAS && OF.
> > > > As ARCH_RENESAS implies OF, the latter can be dropped.
> > > >
> > > > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > > > ---
> > > >
> > > > drivers/media/platform/Kconfig | 2 +-
> > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/drivers/media/platform/Kconfig
> > > > b/drivers/media/platform/Kconfig index 614fbef08ddcabb0..2b8b1ad0edd9eb31
> > > > 100644
> > > > --- a/drivers/media/platform/Kconfig
> > > > +++ b/drivers/media/platform/Kconfig
> > > > @@ -448,7 +448,7 @@ config VIDEO_RENESAS_FCP
> > > >
> > > > config VIDEO_RENESAS_VSP1
> > > >
> > > > tristate "Renesas VSP1 Video Processing Engine"
> > > > depends on VIDEO_V4L2 && VIDEO_V4L2_SUBDEV_API && HAS_DMA
> > > >
> > > > - depends on (ARCH_RENESAS && OF) || COMPILE_TEST
> > > > + depends on ARCH_RENESAS || COMPILE_TEST
> > >
> > > That is not correct!
> > >
> > > COMPILE_TEST doesn't depend on OF. With this patch, it will likely
> > > cause build failures with randconfigs.
> >
> > ARCH_RENESAS implies OF, so replacing (ARCH_RENESAS && OF) with ARCH_RENESAS
> > doesn't change anything. The driver can be compiled with COMPILE_TEST and !OF
> > both before and after this patch.
FWIIW, I think this is a useful cleanup.
> OK!
> >
> > > > depends on (!ARM64 && !VIDEO_RENESAS_FCP) || VIDEO_RENESAS_FCP
> > > > select VIDEOBUF2_DMA_CONTIG
> > > > select VIDEOBUF2_VMALLOC
> >
>
>
>
> Thanks,
> Mauro
>
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2018-03-07 8:14 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-02-26 18:09 [PATCH] media: platform: Drop OF dependency of VIDEO_RENESAS_VSP1 Geert Uytterhoeven
2018-02-27 8:42 ` Simon Horman
2018-02-27 9:30 ` Laurent Pinchart
2018-03-06 16:25 ` Mauro Carvalho Chehab
2018-03-06 16:35 ` Laurent Pinchart
2018-03-06 16:37 ` Mauro Carvalho Chehab
2018-03-07 8:14 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox