From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Sakari Ailus <sakari.ailus@iki.fi>
Cc: linux-media@vger.kernel.org, Hans Verkuil <hverkuil@xs4all.nl>
Subject: Re: [PATCH] omap3isp: ccp2: Don't ignore the regulator_enable() return value
Date: Sat, 08 Jun 2013 09:10:06 +0200 [thread overview]
Message-ID: <2313842.KY3Bh8lkJk@avalon> (raw)
In-Reply-To: <20130607105117.GE3103@valkosipuli.retiisi.org.uk>
Hi Sakari,
Thanks for the review.
On Friday 07 June 2013 13:51:18 Sakari Ailus wrote:
> On Fri, Jun 07, 2013 at 12:35:41PM +0200, Laurent Pinchart wrote:
> > @@ -851,7 +857,11 @@ static int ccp2_s_stream(struct v4l2_subdev *sd, int
> > enable)>
> > ccp2_print_status(ccp2);
> >
> > /* Enable CSI1/CCP2 interface */
> >
> > - ccp2_if_enable(ccp2, 1);
> > + ret = ccp2_if_enable(ccp2, 1);
> > + if (ret < 0) {
> > + omap3isp_csiphy_release(ccp2->phy);
>
> if (ccp2->phy)
> omap3isp_csiphy_release(ccp2->phy);
>
> ?
>
> I don't think 3430 has a separate phy, so it's NULL.
Oops, my bad. Fixed in v2.
> > + return ret;
> > + }
> >
> > break;
> >
> > case ISP_PIPELINE_STREAM_SINGLESHOT:
--
Regards,
Laurent Pinchart
prev parent reply other threads:[~2013-06-08 7:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-07 10:35 [PATCH] omap3isp: ccp2: Don't ignore the regulator_enable() return value Laurent Pinchart
2013-06-07 10:51 ` Sakari Ailus
2013-06-08 7:10 ` Laurent Pinchart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2313842.KY3Bh8lkJk@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=sakari.ailus@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox