public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Joshua Hintze <joshua.hintze@gmail.com>
Cc: linux-media@vger.kernel.org
Subject: Re: Using MT9P031 digital sensor
Date: Mon, 26 Mar 2012 19:38:23 +0200	[thread overview]
Message-ID: <2321523.YMAGzgKbQ4@avalon> (raw)
In-Reply-To: <CAGD8Z76ctw2F669D4PdJpYm4L1caYm=stE3WW_5JNxXpZZwx9g@mail.gmail.com>

Hi Joshua,

On Monday 26 March 2012 09:44:52 Joshua Hintze wrote:
> On Mon, Mar 26, 2012 at 2:25 AM, Laurent Pinchart wrote:
> > On Sunday 25 March 2012 23:13:02 Joshua Hintze wrote:

[snip]

> >> Now I'm working on fixing the white balance. In my office the
> >> incandescent light bulbs give off a yellowish tint late at night. I've
> >> been digging through the omap3isp code to figure out how to enable the
> >> automatic white balance. I was able to find the private IOCTLs for the
> >> previewer and I was able to use VIDIOC_OMAP3ISP_PRV_CFG. Using this IOCTL
> >> I adjusted the OMAP3ISP_PREV_WB, OMAP3ISP_PREV_BLKADJ, and
> >> OMAP3ISP_PREV_RGB2RGB.
> >> 
> >> Since I wasn't sure where to start on adjusting these values I just set
> >> them all to the TRM's default register values. However when I did so a
> >> strange thing occurred. What I saw was all the colors went to a decent
> >> color. I'm curious if anybody can shed some light on the best way to get
> >> a high quality image. Ideally if I could just set a bit for auto white
> >> balance and auto exposure that could be good too.
> > 
> > The ISP doesn't implement automatic white balance. It can apply white
> > balancing (as well as other related processing), but computing values for
> > those parameters needs to be performed in userspace. The ISP statistics
> > engine engine can help speeding up the process, but the AEWB algorithm
> > must be implemented in your application.
> 
> Dang, I'll have to look up some AEWB algorithms.

I will publish sample code soon (likely in a couple of weeks, could be a bit 
before).

> I'm curious why TI would have this register bit then (AEW_EN bit 15 in
> H3A_PCR)?

That bit enables the AEWB statistics collection, not an AEWB algorithm.

> Is this the same for auto focus and auto exposure? Meaning that I'll need to
> get information from the histogram/statistics to adjust focus and exposure
> times?

That's right.

-- 
Regards,

Laurent Pinchart


  reply	other threads:[~2012-03-26 17:37 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-23 19:01 Using MT9P031 digital sensor Joshua Hintze
2012-03-26  5:13 ` Joshua Hintze
2012-03-26  8:25   ` Laurent Pinchart
2012-03-26 15:44     ` Joshua Hintze
2012-03-26 17:38       ` Laurent Pinchart [this message]
2012-03-26 17:43         ` Joshua Hintze
     [not found]   ` <4F708A66.8090303@mlbassoc.com>
2012-03-26 15:37     ` Joshua Hintze
2012-03-26 16:32       ` Gary Thomas
2012-03-26 16:55         ` Joshua Hintze
2012-03-27 14:44         ` jean-philippe francois
2012-03-29 11:33           ` Laurent Pinchart
  -- strict thread matches above, loose matches on Subject: below --
2011-11-01 18:52 Gary Thomas
2011-11-04 10:37 ` Laurent Pinchart
2011-11-08 12:20   ` Gary Thomas
2011-11-08 12:30     ` Javier Martinez Canillas
2011-11-08 12:33       ` Laurent Pinchart
2011-11-08 12:52       ` Gary Thomas
2011-11-08 13:06         ` Laurent Pinchart
2011-11-08 13:38           ` Gary Thomas
2011-11-08 13:40             ` Gary Thomas
2011-11-09  0:54             ` Laurent Pinchart
2011-11-09 11:01               ` Gary Thomas
2011-11-09 16:18                 ` Laurent Pinchart
2011-11-09 16:24                   ` Gary Thomas
2011-11-11 14:26                     ` Laurent Pinchart
2011-11-14 11:42                       ` Gary Thomas
2011-11-16  1:26                         ` Laurent Pinchart
2011-11-16 12:03                           ` Gary Thomas
2011-11-24 11:28                             ` Laurent Pinchart
2011-11-25 11:50                               ` Gary Thomas
2011-11-28 11:07                                 ` Laurent Pinchart
2011-11-28 12:42                                   ` Gary Thomas
2011-11-28 12:49                                     ` Laurent Pinchart
2011-11-28 12:53                                       ` Gary Thomas
2011-11-30 14:13                                       ` Gary Thomas
2011-11-30 14:30                                         ` Laurent Pinchart
2011-11-30 14:38                                           ` Hiremath, Vaibhav
2011-11-30 14:57                                           ` Gary Thomas
2011-11-30 17:00                                             ` Gary Thomas
2011-11-30 23:49                                               ` Laurent Pinchart
2011-11-30 23:42                                             ` Laurent Pinchart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2321523.YMAGzgKbQ4@avalon \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=joshua.hintze@gmail.com \
    --cc=linux-media@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox