From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from perceval.ideasonboard.com ([95.142.166.194]:59562 "EHLO perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755160Ab3GYLnS (ORCPT ); Thu, 25 Jul 2013 07:43:18 -0400 From: Laurent Pinchart To: Sylwester Nawrocki Cc: Laurent Pinchart , linux-media@vger.kernel.org, linux-sh@vger.kernel.org, Hans Verkuil , Sakari Ailus Subject: Re: [PATCH v2 3/5] v4l: Add media format codes for ARGB8888 and AYUV8888 on 32-bit busses Date: Thu, 25 Jul 2013 13:44:12 +0200 Message-ID: <2328654.t4tri5nhxO@avalon> In-Reply-To: <51F04688.6090900@gmail.com> References: <1374072882-14598-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com> <1374072882-14598-4-git-send-email-laurent.pinchart+renesas@ideasonboard.com> <51F04688.6090900@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-media-owner@vger.kernel.org List-ID: Hi Sylwester, On Wednesday 24 July 2013 23:26:32 Sylwester Nawrocki wrote: > On 07/17/2013 04:54 PM, Laurent Pinchart wrote: > > Signed-off-by: Laurent Pinchart > > > > --- > > > > Documentation/DocBook/media/v4l/subdev-formats.xml | 609 ++++++------- > > Documentation/DocBook/media_api.tmpl | 6 + > > include/uapi/linux/v4l2-mediabus.h | 6 +- > > 3 files changed, 254 insertions(+), 367 deletions(-) > > > > diff --git a/Documentation/DocBook/media/v4l/subdev-formats.xml > > b/Documentation/DocBook/media/v4l/subdev-formats.xml index > > 0c2b1f2..9100674 100644 > > --- a/Documentation/DocBook/media/v4l/subdev-formats.xml > > +++ b/Documentation/DocBook/media/v4l/subdev-formats.xml > > @@ -97,31 +97,39 @@ > > [...] > > > + > > + V4L2_MBUS_FMT_ARGB888_1X24 > > This should be V4L2_MBUS_FMT_ARGB888_1X32, right ? Oops, indeed. > > Fix this correction feel free to add: > > Reviewed-by: Sylwester Nawrocki Thank you. > > + 0x100d > > + -- Regards, Laurent Pinchart