From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: "Enric Balletbò i Serra" <eballetbo@gmail.com>
Cc: linux-media@vger.kernel.org
Subject: Re: omap3isp: wrong image after resizer with mt9v034 sensor
Date: Mon, 01 Oct 2012 12:25:40 +0200 [thread overview]
Message-ID: <2377629.Lqpv1qCszQ@avalon> (raw)
In-Reply-To: <CAFqH_51khWJ6RBv707J8AC9YrMhzwqg5QPuo52EYVnBOmTRpFA@mail.gmail.com>
Hi Enric,
On Friday 28 September 2012 17:32:36 Enric Balletbò i Serra wrote:
> 2012/9/28 Laurent Pinchart <laurent.pinchart@ideasonboard.com>:
> > On Friday 28 September 2012 10:21:56 Enric Balletbò i Serra wrote:
> >> 2012/9/28 Laurent Pinchart <laurent.pinchart@ideasonboard.com>:
> >> > On Thursday 27 September 2012 18:05:56 Enric Balletbò i Serra wrote:
> >> >> 2012/9/27 Laurent Pinchart <laurent.pinchart@ideasonboard.com>:
> >> >> > On Wednesday 26 September 2012 16:15:35 Enric Balletbò i Serra
wrote:
[snip]
> >> >> >> Nonetheless, I changed the driver to configure for BGGR pattern.
> >> >> >> Using the Sensor->CCDC->Preview->Resizer pipeline I captured the
> >> >> >> data with yavta and converted using raw2rgbpnm program.
> >> >> >>
> >> >> >> ./raw2rgbpnm -s 752x480 -f UYVY img-000001.uyvy img-000001.pnm
> >> >> >>
> >> >> >> and the result is
> >> >> >>
> >> >> >> http://downloads.isee.biz/pub/files/patterns/img-000002.pnm
> >> >> >> http://downloads.isee.biz/pub/files/patterns/img-000002.bin
> >> >> >>
> >> >> >> The image looks better than older, not perfect, but better. The
> >> >> >> image is only a bit yellowish. Could be this a hardware issue ? We
> >> >> >> are close to ...
> >> >> >
> >> >> > It's like a white balance issue. The OMAP3 ISP hardware doesn't
> >> >> > perform automatic white balance, you will need to implement an AWB
> >> >> > algorithm in software. You can have a look at the omap3-isp-live
> >> >> > project for sample code (http://git.ideasonboard.org/omap3-isp-
> >> >> > live.git).
> >>
> >> So you think the sensor is set well now ?
> >
> > I think so, yes.
> >
> >> The hardware can produce this issue ? Do you know if this algorithm is
> >> implemented in gstreamer ?
> >
> > I don't know, but if it is the implementation will be software-based, and
> > will thus be slow. The OMAP3 ISP can compute AWB-related statistics in
> > hardware and can apply per-color gains to the image. The only software
> > you then need will retrieve the statistics, compute the gains from them
> > and apply the gains. That's what the sample code in omap3-isp-live does.
> > This should at some point be integrated as a libv4l plugin.
>
> So I can use your software to test if it's a white balance issue ?
Yes, but that's really a test application, it might not work out of the box.
> (as the omap3-isp-live has this support if I understood). I'll try this,
> do you can provide some tips on how use the omap3-isp-live ?
Just compile and run it :-)
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2012-10-01 10:25 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-24 8:33 omap3isp: wrong image after resizer with mt9v034 sensor Enric Balletbò i Serra
2012-09-24 12:39 ` Laurent Pinchart
2012-09-24 13:49 ` Enric Balletbò i Serra
2012-09-25 0:43 ` Laurent Pinchart
2012-09-25 7:44 ` Enric Balletbò i Serra
2012-09-25 10:52 ` Laurent Pinchart
2012-09-25 11:23 ` Enric Balletbò i Serra
2012-09-25 11:31 ` Laurent Pinchart
2012-09-26 7:57 ` Enric Balletbò i Serra
2012-09-26 8:49 ` Laurent Pinchart
2012-09-26 14:15 ` Enric Balletbò i Serra
2012-09-27 11:19 ` Laurent Pinchart
[not found] ` <CAFqH_5245L5XqEGy=fpR8VNd9EHwUMZFO=p2NoLF4g4J3K0hCg@mail.gmail.com>
2012-09-27 23:32 ` Laurent Pinchart
[not found] ` <CAFqH_52g8nTTDQDJEzx9E9sC5GoQML7bV-hxjA8q4Q2TcDOTYg@mail.gmail.com>
[not found] ` <1378805.eK71Lgs3H4@avalon>
2012-09-28 15:32 ` Enric Balletbò i Serra
2012-10-01 10:25 ` Laurent Pinchart [this message]
2012-10-01 10:49 ` Enric Balletbò i Serra
2012-10-01 11:03 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2377629.Lqpv1qCszQ@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=eballetbo@gmail.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).