From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: Sakari Ailus <sakari.ailus@iki.fi>, linux-media@vger.kernel.org
Subject: Re: [PATCH 1/1] v4l: drop v4l2_buffer.input and V4L2_BUF_FLAG_INPUT
Date: Mon, 30 Apr 2012 16:27:24 +0200 [thread overview]
Message-ID: <2396617.gGNm1rAEoQ@avalon> (raw)
In-Reply-To: <201204301615.30954.hverkuil@xs4all.nl>
On Monday 30 April 2012 16:15:30 Hans Verkuil wrote:
> On Monday 30 April 2012 16:06:16 Sakari Ailus wrote:
[snip]
> > One option is to keep the reserved fields as array even there was just one
> > of them or if it no longer was there. If so, reserved should have been
> > reserved[1] in the first place. This would make it easier to deal with
> > the changing size of the reserved field.
>
> Definitely. But I think struct v4l2_buffer has been like this for a long
> time (Laurent would know when the input field was added).
That was 8 to 9 years ago. I'm responsible for that terrible idea, so I'd be
happy to see the input field removed ;-)
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2012-04-30 14:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-30 12:40 [PATCH 1/1] v4l: drop v4l2_buffer.input and V4L2_BUF_FLAG_INPUT Sakari Ailus
2012-04-30 12:48 ` Laurent Pinchart
2012-04-30 13:04 ` Sakari Ailus
2012-04-30 13:34 ` Sakari Ailus
2012-04-30 13:48 ` Hans Verkuil
2012-04-30 14:06 ` Sakari Ailus
2012-04-30 14:15 ` Hans Verkuil
2012-04-30 14:27 ` Laurent Pinchart [this message]
2012-05-02 12:40 ` [PATCH v3 " Sakari Ailus
2012-05-28 10:27 ` Hans Verkuil
2012-05-28 11:52 ` Ezequiel Garcia
2012-05-28 16:29 ` Ezequiel Garcia
2012-05-28 17:10 ` Hans Verkuil
2012-05-28 17:25 ` Ezequiel Garcia
2012-05-28 18:00 ` Hans Verkuil
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2396617.gGNm1rAEoQ@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=hverkuil@xs4all.nl \
--cc=linux-media@vger.kernel.org \
--cc=sakari.ailus@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox