From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 23638C77B75 for ; Fri, 21 Apr 2023 12:02:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229884AbjDUMCB (ORCPT ); Fri, 21 Apr 2023 08:02:01 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48022 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229464AbjDUMCA (ORCPT ); Fri, 21 Apr 2023 08:02:00 -0400 Received: from lelv0142.ext.ti.com (lelv0142.ext.ti.com [198.47.23.249]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D7B75A3 for ; Fri, 21 Apr 2023 05:01:58 -0700 (PDT) Received: from lelv0266.itg.ti.com ([10.180.67.225]) by lelv0142.ext.ti.com (8.15.2/8.15.2) with ESMTP id 33LC1i60068310; Fri, 21 Apr 2023 07:01:44 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ti.com; s=ti-com-17Q1; t=1682078504; bh=detvpIPaTZQ7AT0m89sHNMIDW4QLAbELyXBdTBACZkQ=; h=Date:Subject:To:CC:References:From:In-Reply-To; b=rm9qOGF4/Wp1G4ZXnsRDN/35dZuSdl1c18g/B2Iay9+l24XOvLPN3u80Ds0DlsPub NLb70FgAztCfEX4H0MWYoqPKt2LK/5rD1HQG99trkW9kZH6vSMOVO/uGGEpYT3VOr4 yNm/L/7JODPtVIXFso7Y+rHBwoJzJ88TO7K3ytQk= Received: from DLEE100.ent.ti.com (dlee100.ent.ti.com [157.170.170.30]) by lelv0266.itg.ti.com (8.15.2/8.15.2) with ESMTPS id 33LC1i7P067260 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=FAIL); Fri, 21 Apr 2023 07:01:44 -0500 Received: from DLEE111.ent.ti.com (157.170.170.22) by DLEE100.ent.ti.com (157.170.170.30) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16; Fri, 21 Apr 2023 07:01:44 -0500 Received: from lelv0326.itg.ti.com (10.180.67.84) by DLEE111.ent.ti.com (157.170.170.22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_CBC_SHA256_P256) id 15.1.2507.16 via Frontend Transport; Fri, 21 Apr 2023 07:01:44 -0500 Received: from [10.24.69.141] (ileaxei01-snat2.itg.ti.com [10.180.69.6]) by lelv0326.itg.ti.com (8.15.2/8.15.2) with ESMTP id 33LC1gxA029587; Fri, 21 Apr 2023 07:01:43 -0500 Message-ID: <23f2c3af-973c-bf6b-e14d-b35de2db2b02@ti.com> Date: Fri, 21 Apr 2023 17:31:41 +0530 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.2 Subject: Re: [PATCH] media: Accept non-subdev sinks in v4l2_create_fwnode_links_to_pad() To: Laurent Pinchart CC: , Sakari Ailus , References: <20230324103529.8704-1-laurent.pinchart@ideasonboard.com> <4cd24628-fafd-e280-200c-0c443e25cfa9@ti.com> <20230420164537.GD21943@pendragon.ideasonboard.com> Content-Language: en-US From: Vaishnav Achath In-Reply-To: <20230420164537.GD21943@pendragon.ideasonboard.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-EXCLAIMER-MD-CONFIG: e1e8a2fd-e40a-4ac6-ac9b-f7e9cc9ee180 Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Hi Laurent, On 20/04/23 22:15, Laurent Pinchart wrote: > Hi Vaishnav, > > On Thu, Apr 13, 2023 at 06:51:23PM +0530, Vaishnav Achath wrote: >> Hi Laurent, >> >> Thank you for the patch, sorry for the delay in response, >> >> On 24/03/23 16:05, Laurent Pinchart wrote: >>> The v4l2_create_fwnode_links_to_pad() helper requires the sink pad >>> passed to it to belong to a subdev. This requirement can be lifted >>> easily. Make the function usable for non-subdev sinks, which allows >>> using it with video_device sinks. >>> >>> Signed-off-by: Laurent Pinchart >>> --- >>> drivers/media/v4l2-core/v4l2-mc.c | 15 ++++++--------- >>> include/media/v4l2-mc.h | 8 ++++---- >>> 2 files changed, 10 insertions(+), 13 deletions(-) >>> >>> diff --git a/drivers/media/v4l2-core/v4l2-mc.c b/drivers/media/v4l2-core/v4l2-mc.c >>> index b01474717dca..bf0c18100664 100644 >>> --- a/drivers/media/v4l2-core/v4l2-mc.c >>> +++ b/drivers/media/v4l2-core/v4l2-mc.c >>> @@ -313,14 +313,11 @@ int v4l2_create_fwnode_links_to_pad(struct v4l2_subdev *src_sd, >>> struct media_pad *sink, u32 flags) >>> { >>> struct fwnode_handle *endpoint; >>> - struct v4l2_subdev *sink_sd; >>> >>> if (!(sink->flags & MEDIA_PAD_FL_SINK) || >>> !is_media_entity_v4l2_subdev(sink->entity)) >> >> should we drop the second check here also, i.e >> >> !is_media_entity_v4l2_subdev(sink->entity) >> >> to accept non-subdev sinks? is my understanding correct? > > You're absolutely right. The patch has been merged already I'm afraid. > Would you like to submit a fix, or should I do so ? In the latter case, > can I include a Reported-by tag with your name ? > Thank you for confirming, I have send a fix for this as I had tested with the fix while reworking the j721e-csi2rx series, https://lore.kernel.org/all/20230421100430.28962-1-vaishnav.a@ti.com/ Thanks and Regards, Vaishnav >>> return -EINVAL; >>> >>> - sink_sd = media_entity_to_v4l2_subdev(sink->entity); >>> - >>> fwnode_graph_for_each_endpoint(dev_fwnode(src_sd->dev), endpoint) { >>> struct fwnode_handle *remote_ep; >>> int src_idx, sink_idx, ret; >>> @@ -340,7 +337,7 @@ int v4l2_create_fwnode_links_to_pad(struct v4l2_subdev *src_sd, >>> * ask the sink to verify it owns the remote endpoint, >>> * and translate to a sink pad. >>> */ >>> - sink_idx = media_entity_get_fwnode_pad(&sink_sd->entity, >>> + sink_idx = media_entity_get_fwnode_pad(sink->entity, >>> remote_ep, >>> MEDIA_PAD_FL_SINK); >>> fwnode_handle_put(remote_ep); >>> @@ -362,17 +359,17 @@ int v4l2_create_fwnode_links_to_pad(struct v4l2_subdev *src_sd, >>> if (media_entity_find_link(src, sink)) >>> continue; >>> >>> - dev_dbg(sink_sd->dev, "creating link %s:%d -> %s:%d\n", >>> + dev_dbg(src_sd->dev, "creating link %s:%d -> %s:%d\n", >>> src_sd->entity.name, src_idx, >>> - sink_sd->entity.name, sink_idx); >>> + sink->entity->name, sink_idx); >>> >>> ret = media_create_pad_link(&src_sd->entity, src_idx, >>> - &sink_sd->entity, sink_idx, flags); >>> + sink->entity, sink_idx, flags); >>> if (ret) { >>> - dev_err(sink_sd->dev, >>> + dev_err(src_sd->dev, >>> "link %s:%d -> %s:%d failed with %d\n", >>> src_sd->entity.name, src_idx, >>> - sink_sd->entity.name, sink_idx, ret); >>> + sink->entity->name, sink_idx, ret); >>> >>> fwnode_handle_put(endpoint); >>> return ret; >>> diff --git a/include/media/v4l2-mc.h b/include/media/v4l2-mc.h >>> index c181685923d5..b39586dfba35 100644 >>> --- a/include/media/v4l2-mc.h >>> +++ b/include/media/v4l2-mc.h >>> @@ -87,17 +87,17 @@ int v4l_vb2q_enable_media_source(struct vb2_queue *q); >>> >>> /** >>> * v4l2_create_fwnode_links_to_pad - Create fwnode-based links from a >>> - * source subdev to a sink subdev pad. >>> + * source subdev to a sink pad. >>> * >>> * @src_sd: pointer to a source subdev >>> - * @sink: pointer to a subdev sink pad >>> + * @sink: pointer to a sink pad >>> * @flags: the link flags >>> * >>> * This function searches for fwnode endpoint connections from a source >>> * subdevice to a single sink pad, and if suitable connections are found, >>> * translates them into media links to that pad. The function can be >>> - * called by the sink subdevice, in its v4l2-async notifier subdev bound >>> - * callback, to create links from a bound source subdevice. >>> + * called by the sink, in its v4l2-async notifier bound callback, to create >>> + * links from a bound source subdevice. >>> * >>> * The @flags argument specifies the link flags. The caller shall ensure that >>> * the flags are valid regardless of the number of links that may be created. > -- Regards, Vaishnav