Re: [PATCH v9 10/11] media: qcom: iris: use new firmware name for SM8250

[Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>]

On Sat, Mar 21, 2026 at 07:56:47AM -0700, Rob Clark wrote:
> On Sat, Mar 21, 2026 at 7:45 AM Dmitry Baryshkov
> <dmitry.baryshkov@oss.qualcomm.com> wrote:
> >
> > The linux-firmware is providing the vpuNN_pM.mbn firmware for SM8250
> > since August of 2024. Stop using the legacy firmware name
> > (vpu-1.0/venus.mbn) and switch to the standard firmware name schema
> > (vpu/vpu20_p4.mbn).
> 
> drive-by... how useful is it at all to list signed fw name in the
> driver, when it's going to have to be overridden by dts for basically
> everyone that isnt' a qc employee?  On the GPU side, we stopped
> listing zap fw names for this reason.

True, that would be a good idea for the next platforms. Fot the existing
ones we have to support existing DTs, which don't list the firmware
name.

> 
> BR,
> -R
> 
> > Reviewed-by: Vikash Garodia <vikash.garodia@oss.qualcomm.com>
> > Signed-off-by: Dmitry Baryshkov <dmitry.baryshkov@oss.qualcomm.com>
> > ---
> >  drivers/media/platform/qcom/iris/iris_platform_vpu2.c | 2 +-
> >  1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/media/platform/qcom/iris/iris_platform_vpu2.c b/drivers/media/platform/qcom/iris/iris_platform_vpu2.c
> > index ab2a19aa9c36..692fbc2aab56 100644
> > --- a/drivers/media/platform/qcom/iris/iris_platform_vpu2.c
> > +++ b/drivers/media/platform/qcom/iris/iris_platform_vpu2.c
> > @@ -111,7 +111,7 @@ const struct iris_platform_data sm8250_data = {
> >         .opp_clk_tbl = sm8250_opp_clk_table,
> >         /* Upper bound of DMA address range */
> >         .dma_mask = 0xe0000000 - 1,
> > -       .fwname = "qcom/vpu-1.0/venus.mbn",
> > +       .fwname = "qcom/vpu/vpu20_p4.mbn",
> >         .inst_iris_fmts = iris_fmts_vpu2_dec,
> >         .inst_iris_fmts_size = ARRAY_SIZE(iris_fmts_vpu2_dec),
> >         .inst_caps = &platform_inst_cap_vpu2,
> >
> > --
> > 2.47.3
> >
> >

-- 
With best wishes
Dmitry