From: Alexander Stein <alexander.stein@ew.tq-group.com>
To: linux-media@vger.kernel.org,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc: Sakari Ailus <sakari.ailus@iki.fi>,
Manivannan Sadhasivam <mani@kernel.org>,
Dave Stevenson <dave.stevenson@raspberrypi.com>
Subject: Re: [PATCH v2 17/20] media: i2c: imx290: Move registers with fixed value to init array
Date: Mon, 17 Oct 2022 07:52:00 +0200 [thread overview]
Message-ID: <2651531.mvXUDI8C0e@steina-w> (raw)
In-Reply-To: <20221016061523.30127-18-laurent.pinchart@ideasonboard.com>
Hello Laurent,
thanks for the updated series.
Am Sonntag, 16. Oktober 2022, 08:15:20 CEST schrieb Laurent Pinchart:
> Registers 0x3012, 0x3013 and 0x3480 are not documented and are set in
> the per-mode register arrays with values indentical for all modes. Move
> them to the common array.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> ---
> drivers/media/i2c/imx290.c | 8 ++------
> 1 file changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/media/i2c/imx290.c b/drivers/media/i2c/imx290.c
> index 93eab6c96ca0..0b34d60f8ce2 100644
> --- a/drivers/media/i2c/imx290.c
> +++ b/drivers/media/i2c/imx290.c
> @@ -192,6 +192,7 @@ static const struct imx290_regval
> imx290_global_init_settings[] = { { IMX290_REG_8BIT(0x300f), 0x00 },
> { IMX290_REG_8BIT(0x3010), 0x21 },
> { IMX290_REG_8BIT(0x3012), 0x64 },
> + { IMX290_REG_8BIT(0x3013), 0x00 },
> { IMX290_REG_8BIT(0x3016), 0x09 },
> { IMX290_REG_8BIT(0x3070), 0x02 },
> { IMX290_REG_8BIT(0x3071), 0x11 },
> @@ -230,6 +231,7 @@ static const struct imx290_regval
> imx290_global_init_settings[] = { { IMX290_REG_8BIT(0x33b0), 0x50 },
> { IMX290_REG_8BIT(0x33b2), 0x1a },
> { IMX290_REG_8BIT(0x33b3), 0x04 },
> + { IMX290_REG_8BIT(0x3480), 0x49 },
> };
>
> static const struct imx290_regval imx290_1080p_settings[] = {
> @@ -239,15 +241,12 @@ static const struct imx290_regval
> imx290_1080p_settings[] = { { IMX290_OPB_SIZE_V, 10 },
> { IMX290_X_OUT_SIZE, 1920 },
> { IMX290_Y_OUT_SIZE, 1080 },
> - { IMX290_REG_8BIT(0x3012), 0x64 },
> - { IMX290_REG_8BIT(0x3013), 0x00 },
> { IMX290_INCKSEL1, 0x18 },
> { IMX290_INCKSEL2, 0x03 },
> { IMX290_INCKSEL3, 0x20 },
> { IMX290_INCKSEL4, 0x01 },
> { IMX290_INCKSEL5, 0x1a },
> { IMX290_INCKSEL6, 0x1a },
> - { IMX290_REG_8BIT(0x3480), 0x49 },
> /* data rate settings */
> { IMX290_REPETITION, 0x10 },
> { IMX290_TCLKPOST, 87 },
> @@ -267,15 +266,12 @@ static const struct imx290_regval
> imx290_720p_settings[] = { { IMX290_OPB_SIZE_V, 4 },
> { IMX290_X_OUT_SIZE, 1280 },
> { IMX290_Y_OUT_SIZE, 720 },
> - { IMX290_REG_8BIT(0x3012), 0x64 },
> - { IMX290_REG_8BIT(0x3013), 0x00 },
> { IMX290_INCKSEL1, 0x20 },
> { IMX290_INCKSEL2, 0x00 },
> { IMX290_INCKSEL3, 0x20 },
> { IMX290_INCKSEL4, 0x01 },
> { IMX290_INCKSEL5, 0x1a },
> { IMX290_INCKSEL6, 0x1a },
> - { IMX290_REG_8BIT(0x3480), 0x49 },
> /* data rate settings */
> { IMX290_REPETITION, 0x10 },
> { IMX290_TCLKPOST, 79 },
Acked-by: Alexander Stein <alexander.stein@ew.tq-group.com>
next prev parent reply other threads:[~2022-10-17 5:52 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-16 6:15 [PATCH v2 00/20] media: i2c: imx290: Miscellaneous improvements Laurent Pinchart
2022-10-16 6:15 ` [PATCH v2 01/20] media: dt-bindings: Convert imx290.txt to YAML Laurent Pinchart
2022-10-16 15:05 ` Krzysztof Kozlowski
2022-10-17 13:57 ` Dave Stevenson
2022-10-25 14:12 ` Sakari Ailus
2022-10-16 6:15 ` [PATCH v2 02/20] media: i2c: imx290: Use device lock for the control handler Laurent Pinchart
2022-10-16 6:15 ` [PATCH v2 03/20] media: i2c: imx290: Print error code when I2C transfer fails Laurent Pinchart
2022-10-16 6:15 ` [PATCH v2 04/20] media: i2c: imx290: Replace macro with explicit ARRAY_SIZE() Laurent Pinchart
2022-10-16 6:15 ` [PATCH v2 05/20] media: i2c: imx290: Drop imx290_write_buffered_reg() Laurent Pinchart
2022-10-16 6:15 ` [PATCH v2 06/20] media: i2c: imx290: Drop regmap cache Laurent Pinchart
2022-10-16 6:15 ` [PATCH v2 07/20] media: i2c: imx290: Specify HMAX values in decimal Laurent Pinchart
2022-10-16 6:15 ` [PATCH v2 08/20] media: i2c: imx290: Support variable-sized registers Laurent Pinchart
2022-10-16 6:15 ` [PATCH v2 09/20] media: i2c: imx290: Correct register sizes Laurent Pinchart
2022-10-16 6:15 ` [PATCH v2 10/20] media: i2c: imx290: Simplify error handling when writing registers Laurent Pinchart
2022-10-16 6:15 ` [PATCH v2 11/20] media: i2c: imx290: Define more register macros Laurent Pinchart
2022-10-17 6:07 ` Alexander Stein
2022-10-17 8:35 ` [PATCH v2.1 " Laurent Pinchart
2022-10-16 6:15 ` [PATCH v2 12/20] media: i2c: imx290: Add exposure time control Laurent Pinchart
2022-10-16 6:15 ` [PATCH v2 13/20] media: i2c: imx290: Fix max gain value Laurent Pinchart
2022-10-16 6:15 ` [PATCH v2 14/20] media: i2c: imx290: Split control initialization to separate function Laurent Pinchart
2022-10-16 6:15 ` [PATCH v2 15/20] media: i2c: imx290: Implement HBLANK and VBLANK controls Laurent Pinchart
2022-10-16 6:15 ` [PATCH v2 16/20] media: i2c: imx290: Create controls for fwnode properties Laurent Pinchart
2022-10-16 6:15 ` [PATCH v2 17/20] media: i2c: imx290: Move registers with fixed value to init array Laurent Pinchart
2022-10-17 5:52 ` Alexander Stein [this message]
2022-10-16 6:15 ` [PATCH v2 18/20] media: i2c: imx290: Factor out format retrieval to separate function Laurent Pinchart
2022-10-17 5:55 ` Alexander Stein
2022-10-17 8:37 ` Laurent Pinchart
2022-10-16 6:15 ` [PATCH v2 19/20] media: i2c: imx290: Add crop selection targets support Laurent Pinchart
2022-10-16 6:15 ` [PATCH v2 20/20] media: i2c: imx290: Replace GAIN control with ANALOGUE_GAIN Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2651531.mvXUDI8C0e@steina-w \
--to=alexander.stein@ew.tq-group.com \
--cc=dave.stevenson@raspberrypi.com \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=mani@kernel.org \
--cc=sakari.ailus@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox