Re: [PATCH v2 1/3] dt-bindings: media: camss: qcom,msm8996-camss: Add CAMSS power domain

Conor Dooley
2023-05-26T19:46:18Z

[-- Attachment #1: Type: text/plain, Size: 1999 bytes --]

Yo Yassine,

On Fri, May 26, 2023 at 09:07:10PM +0300, Yassine Oudjana wrote:
> From: Yassine Oudjana <y.oudjana@protonmail.com>
>
> Add the CAMSS power domain which is needed for the proper operation of
> CAMSS, and add power-domain-names to ease fetching it as well as the other
> power domains.
>
> Signed-off-by: Yassine Oudjana <y.oudjana@protonmail.com>
> Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> ---
> .../bindings/media/qcom,msm8996-camss.yaml | 13 ++++++++++++-
> 1 file changed, 12 insertions(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/media/qcom,msm8996-camss.yaml b/Documentation/devicetree/bindings/media/qcom,msm8996-camss.yaml
> index 8a10aa1cafc5..27c9a11f0df9 100644
> --- a/Documentation/devicetree/bindings/media/qcom,msm8996-camss.yaml
> +++ b/Documentation/devicetree/bindings/media/qcom,msm8996-camss.yaml
> @@ -85,6 +85,13 @@ properties:
> items:
> - description: VFE0 GDSC - Video Front End, Global Distributed Switch Controller.
> - description: VFE1 GDSC - Video Front End, Global Distributed Switch Controller.
> + - description: CAMSS GDSC - Camera Subsystem, Global Distributed Switch Controller.
> +
> + power-domain-names:
> + items:
> + - const: vfe0
> + - const: vfe1
> + - const: camss
>
> ports:
> $ref: /schemas/graph.yaml#/properties/ports
> @@ -209,6 +216,7 @@ required:
> - interrupts
> - iommus
> - power-domains
> + - power-domain-names

Why is this now required?

Thanks,
Conor.

> - reg
> - reg-names
> - vdda-supply
> @@ -326,7 +334,10 @@ examples:
> <&vfe_smmu 3>;
>
> power-domains = <&mmcc VFE0_GDSC>,
> - <&mmcc VFE1_GDSC>;
> + <&mmcc VFE1_GDSC>,
> + <&mmcc CAMSS_GDSC>;
> +
> + power-domain-names = "vfe0", "vfe1", "camss";
>
> reg = <0x00a34000 0x1000>,
> <0x00a00030 0x4>,
> --
> 2.40.1
>

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]