Re: [PATCH] mt9v032: Provide link frequency control

[Laurent Pinchart <laurent.pinchart@ideasonboard.com>]

Hi Hans,

Thanks for the review.

On Thursday 26 July 2012 15:16:04 Hans Verkuil wrote:
> On Thu 26 July 2012 14:56:56 Laurent Pinchart wrote:
> > Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > ---
> > 
> >  drivers/media/video/mt9v032.c |   48 ++++++++++++++++++++++++++++++++----
> >  include/media/mt9v032.h       |    3 ++
> >  2 files changed, 46 insertions(+), 5 deletions(-)
> > 
> > diff --git a/drivers/media/video/mt9v032.c b/drivers/media/video/mt9v032.c
> > index 2203a6f..39217b8 100644
> > --- a/drivers/media/video/mt9v032.c
> > +++ b/drivers/media/video/mt9v032.c

[snip]

> > @@ -505,6 +514,16 @@ static int mt9v032_s_ctrl(struct v4l2_ctrl *ctrl)
> >  		return mt9v032_write(client, MT9V032_TOTAL_SHUTTER_WIDTH,
> >  				     ctrl->val);
> > 
> > +	case V4L2_CID_PIXEL_RATE:
> > +	case V4L2_CID_LINK_FREQ:
> > +		if (mt9v032->link_freq == NULL)
> > +			break;
> > +
> > +		freq = mt9v032->pdata->link_freqs[mt9v032->link_freq->val];
> > +		mt9v032->pixel_rate->cur.val = freq;
> 
> That should be 'mt9v032->pixel_rate->val = freq;'.
> 
> It used to be cur.val some time ago, but that was changed. You never set
> cur.val anymore inside a s_ctrl handler.

Thanks. I'll fix that.

-- 
Regards,

Laurent Pinchart