From mboxrd@z Thu Jan  1 00:00:00 1970
Return-path: <linux-media-owner@vger.kernel.org>
Received: from perceval.ideasonboard.com ([95.142.166.194]:41156 "EHLO
	perceval.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751120Ab2FRLDe (ORCPT
	<rfc822;linux-media@vger.kernel.org>);
	Mon, 18 Jun 2012 07:03:34 -0400
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Mauro Carvalho Chehab <mchehab@redhat.com>
Cc: Hans Verkuil <hverkuil@xs4all.nl>, linux-media@vger.kernel.org,
	Mauro Carvalho Chehab <mchehab@infradead.org>,
	Hans de Goede <hdegoede@redhat.com>,
	Andy Walls <awalls@md.metrocast.net>,
	Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
	Pawel Osciak <pawel@osciak.com>,
	Tomasz Stanislawski <t.stanislaws@samsung.com>,
	Hans Verkuil <hans.verkuil@cisco.com>
Subject: Re: [RFCv1 PATCH 18/32] v4l2-ioctl.c: finalize table conversion.
Date: Mon, 18 Jun 2012 13:03:42 +0200
Message-ID: <2682562.0KUfoWevuF@avalon>
In-Reply-To: <4FDF07FB.1080802@redhat.com>
References: <1339323954-1404-1-git-send-email-hverkuil@xs4all.nl> <10390224.oHYD7VJvJs@avalon> <4FDF07FB.1080802@redhat.com>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Sender: linux-media-owner@vger.kernel.org
List-ID: <linux-media.vger.kernel.org>

Hi Mauro,

On Monday 18 June 2012 07:50:35 Mauro Carvalho Chehab wrote:
> Em 18-06-2012 06:46, Laurent Pinchart escreveu:
> > On Sunday 10 June 2012 12:25:40 Hans Verkuil wrote:
> >> From: Hans Verkuil <hans.verkuil@cisco.com>
> >> 
> >> Signed-off-by: Hans Verkuil <hans.verkuil@cisco.com>
> >> ---
> >> 
> >>   drivers/media/video/v4l2-ioctl.c |   35
> >>   +++++++++++++----------------------
> >> 
> >> 1 file changed, 13 insertions(+), 22 deletions(-)
> >> 
> >> diff --git a/drivers/media/video/v4l2-ioctl.c
> >> b/drivers/media/video/v4l2-ioctl.c index 0de31c4..6c91674 100644
> >> --- a/drivers/media/video/v4l2-ioctl.c
> >> +++ b/drivers/media/video/v4l2-ioctl.c
> >> @@ -870,6 +870,11 @@ static void v4l_print_newline(const void *arg)
> >> 
> >>   	pr_cont("\n");
> >>   
> >>   }
> >> 
> >> +static void v4l_print_default(const void *arg)
> >> +{
> >> +	pr_cont("non-standard ioctl\n");
> > 
> > I'd say "driver-specific ioctl" instead. "non-standard" may sound like an
> > error to users.
> 
> This message is useless as-is, as it provides no glue about what ioctl was
> called. You should either remove it or print the ioctl number, in hexa.

I think the ioctl number is already printed by the caller of 
v4l_print_default.

-- 
Regards,

Laurent Pinchart