public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
	linux-media@vger.kernel.org, linux-sh@vger.kernel.org
Subject: Re: [PATCH v2 17/32] v4l: vsp1: Fix typo in VI6_DISP_IRQ_STA_DST register name
Date: Sun, 06 Dec 2015 00:20:35 +0200	[thread overview]
Message-ID: <2694247.f6vaztlhDB@avalon> (raw)
In-Reply-To: <56635B69.3000800@cogentembedded.com>

Hi Sergio,

On Sunday 06 December 2015 00:47:21 Sergei Shtylyov wrote:
> On 12/5/2015 5:12 AM, Laurent Pinchart wrote:
> > Rename the VI6_DISP_IRQ_STA_DSE register
> 
>     Register bit, perhaps?

Indeed. I know I can count on you to catch even such small issues :-)

I'll fix it for the next version (or the pull request if no issue that require 
a new review round is found).

> > to VI6_DISP_IRQ_STA_DST to fix
> > a typo and match the datasheet.
> > 
> > Signed-off-by: Laurent Pinchart
> > <laurent.pinchart+renesas@ideasonboard.com>
> > ---
> > 
> >   drivers/media/platform/vsp1/vsp1_regs.h | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/drivers/media/platform/vsp1/vsp1_regs.h
> > b/drivers/media/platform/vsp1/vsp1_regs.h index
> > 25b48738b147..8173ceaab9f9 100644
> > --- a/drivers/media/platform/vsp1/vsp1_regs.h
> > +++ b/drivers/media/platform/vsp1/vsp1_regs.h
> > @@ -46,7 +46,7 @@
> > 
> >   #define VI6_DISP_IRQ_ENB_LNEE(n)	(1 << (n))
> >   
> >   #define VI6_DISP_IRQ_STA		0x007c
> > 
> > -#define VI6_DISP_IRQ_STA_DSE		(1 << 8)
> > +#define VI6_DISP_IRQ_STA_DST		(1 << 8)
> > 
> >   #define VI6_DISP_IRQ_STA_MAE		(1 << 5)
> >   #define VI6_DISP_IRQ_STA_LNE(n)		(1 << (n))
> 
> MBR, Sergei

-- 
Regards,

Laurent Pinchart


  reply	other threads:[~2015-12-05 22:20 UTC|newest]

Thread overview: 42+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-12-05  2:12 [PATCH v2 00/32] VSP: Add R-Car Gen3 support Laurent Pinchart
2015-12-05  2:12 ` [PATCH v2 01/32] v4l: vsp1: Change the type of the rwpf field in struct vsp1_video Laurent Pinchart
2015-12-05  2:12 ` [PATCH v2 02/32] v4l: vsp1: Store the memory format in struct vsp1_rwpf Laurent Pinchart
2015-12-05  2:12 ` [PATCH v2 03/32] v4l: vsp1: Move video operations to vsp1_rwpf Laurent Pinchart
2015-12-05  2:12 ` [PATCH v2 04/32] v4l: vsp1: Rename vsp1_video_buffer to vsp1_vb2_buffer Laurent Pinchart
2015-12-05  2:12 ` [PATCH v2 05/32] v4l: vsp1: Move video device out of struct vsp1_rwpf Laurent Pinchart
2015-12-05  2:12 ` [PATCH v2 06/32] v4l: vsp1: Make rwpf operations independent of video device Laurent Pinchart
2015-12-05  2:12 ` [PATCH v2 07/32] v4l: vsp1: Support VSP1 instances without any UDS Laurent Pinchart
2015-12-05  2:12 ` [PATCH v2 08/32] v4l: vsp1: Move vsp1_video pointer from vsp1_entity to vsp1_rwpf Laurent Pinchart
2015-12-05  2:12 ` [PATCH v2 09/32] v4l: vsp1: Remove struct vsp1_pipeline num_video field Laurent Pinchart
2015-12-05  2:12 ` [PATCH v2 10/32] v4l: vsp1: Decouple pipeline end of frame processing from vsp1_video Laurent Pinchart
2015-12-05  2:12 ` [PATCH v2 11/32] v4l: vsp1: Split pipeline management code from vsp1_video.c Laurent Pinchart
2015-12-05  2:12 ` [PATCH v2 12/32] v4l: vsp1: Rename video pipeline functions to use vsp1_video prefix Laurent Pinchart
2015-12-05  2:12 ` [PATCH v2 13/32] v4l: vsp1: Extract pipeline initialization code into a function Laurent Pinchart
2015-12-05  2:12 ` [PATCH v2 14/32] v4l: vsp1: Reuse local variable instead of recomputing it Laurent Pinchart
2015-12-05  2:12 ` [PATCH v2 15/32] v4l: vsp1: Extract link creation to separate function Laurent Pinchart
2015-12-05  2:12 ` [PATCH v2 16/32] v4l: vsp1: Document the vsp1_pipeline structure Laurent Pinchart
2015-12-05  2:12 ` [PATCH v2 17/32] v4l: vsp1: Fix typo in VI6_DISP_IRQ_STA_DST register name Laurent Pinchart
2015-12-05 21:47   ` Sergei Shtylyov
2015-12-05 22:20     ` Laurent Pinchart [this message]
2015-12-05  2:12 ` [PATCH v2 18/32] v4l: vsp1: Set the SRU CTRL0 register when starting the stream Laurent Pinchart
2015-12-05  2:12 ` [PATCH v2 19/32] v4l: vsp1: Remove unused module read functions Laurent Pinchart
2015-12-05  2:12 ` [PATCH v2 20/32] v4l: vsp1: Move entity route setup function to vsp1_entity.c Laurent Pinchart
2015-12-05  2:12 ` [PATCH v2 21/32] v4l: vsp1: Make number of BRU inputs configurable Laurent Pinchart
2015-12-05  2:12 ` [PATCH v2 22/32] v4l: vsp1: Make the BRU optional Laurent Pinchart
2015-12-05  2:12 ` [PATCH v2 23/32] v4l: vsp1: Move format info to vsp1_pipe.c Laurent Pinchart
2015-12-05  2:12 ` [PATCH v2 24/32] v4l: vsp1: Make the userspace API optional Laurent Pinchart
2015-12-05  2:12 ` [PATCH v2 25/32] v4l: vsp1: Make pipeline inputs array index by RPF index Laurent Pinchart
2015-12-05  2:13 ` [PATCH v2 26/32] v4l: vsp1: Set the alpha value manually in RPF and WPF s_stream handlers Laurent Pinchart
2015-12-05  2:13 ` [PATCH v2 27/32] v4l: vsp1: Don't validate links when the userspace API is disabled Laurent Pinchart
2015-12-05  2:13 ` [PATCH v2 28/32] v4l: vsp1: Add VSP+DU support Laurent Pinchart
2015-12-05  2:13 ` [PATCH v2 29/32] v4l: vsp1: Disconnect unused RPFs from the DRM pipeline Laurent Pinchart
2015-12-05  2:13 ` [PATCH v2 30/32] v4l: vsp1: Implement atomic update for the DRM driver Laurent Pinchart
2015-12-05  2:13 ` [PATCH v2 31/32] v4l: vsp1: Add support for the R-Car Gen3 VSP2 Laurent Pinchart
2015-12-05  2:13 ` [PATCH v2 32/32] v4l: vsp1: Add display list support Laurent Pinchart
2015-12-05 10:57 ` [PATCH v2 00/32] VSP: Add R-Car Gen3 support Geert Uytterhoeven
2015-12-05 22:54   ` Laurent Pinchart
2015-12-11  8:43     ` Khiem Nguyen
2015-12-13 18:53       ` Laurent Pinchart
2015-12-14  1:58         ` Khiem Nguyen
2015-12-16  8:39     ` Geert Uytterhoeven
2015-12-16 10:37       ` Laurent Pinchart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2694247.f6vaztlhDB@avalon \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=laurent.pinchart+renesas@ideasonboard.com \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-sh@vger.kernel.org \
    --cc=sergei.shtylyov@cogentembedded.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox