From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from galahad.ideasonboard.com ([185.26.127.97]:56252 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751369AbdHQNvU (ORCPT ); Thu, 17 Aug 2017 09:51:20 -0400 From: Laurent Pinchart To: Javier Martinez Canillas Cc: Philipp Zabel , Linux Kernel , Mauro Carvalho Chehab , Hans Verkuil , Linux Media Mailing List Subject: Re: [RFT PATCH] [media] partial revert of "[media] tvp5150: add HW input connectors support" Date: Thu, 17 Aug 2017 16:51:44 +0300 Message-ID: <2696279.xCvGOK2H1o@avalon> In-Reply-To: References: <1481643559-19666-1-git-send-email-javier@osg.samsung.com> <1502975140.2927.1.camel@pengutronix.de> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-media-owner@vger.kernel.org List-ID: Hello, On Thursday 17 Aug 2017 15:49:51 Javier Martinez Canillas wrote: > On Thu, Aug 17, 2017 at 3:05 PM, Philipp Zabel wrote: > > On Tue, 2016-12-13 at 12:39 -0300, Javier Martinez Canillas wrote: > >> Commit f7b4b54e6364 ("[media] tvp5150: add HW input connectors support") > >> added input signals support for the tvp5150, but the approach was found > >> to be incorrect so the corresponding DT binding commit 82c2ffeb217a > >> ("[media] tvp5150: document input connectors DT bindings") was reverted. > >> > >> This left the driver with an undocumented (and wrong) DT parsing logic, > >> so lets get rid of this code as well until the input connectors support > >> is implemented properly. > >> > >> It's a partial revert due other patches added on top of mentioned commit > >> not allowing the commit to be reverted cleanly anymore. But all the code > >> related to the DT parsing logic and input entities creation are removed. > >> > >> > Suggested-by: Laurent Pinchart > >> > Signed-off-by: Javier Martinez Canillas > > > > what is the state of this patch? Was it forgotten or was the revert > > deemed unnecessary? > > I think that was just forgotten. That code still needs to be reverted > since the DT patch was also reverted. Yes, I think it was just forgotten. > Albeit the code is harmless since should be a no-op if a connectors DT > node isn't found. -- Regards, Laurent Pinchart