From: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
To: Sakari Ailus <sakari.ailus@iki.fi>
Cc: jacopo@jmondi.org, paul.j.murphy@intel.com,
daniele.alessandrelli@intel.com, mchehab@kernel.org,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
dmitry.baryshkov@linaro.org, konrad.dybcio@somainline.org,
andrey.konovalov@linaro.org
Subject: Re: [PATCH 2/2] media: i2c: imx412: Add imx577 compatible string
Date: Tue, 14 Jun 2022 07:43:42 -0700 [thread overview]
Message-ID: <26dc329e-b663-e779-a30f-b495206ced48@linaro.org> (raw)
In-Reply-To: <Yqh4ewFMP5QcO/ta@valkosipuli.retiisi.eu>
On 14/06/2022 05:00, Sakari Ailus wrote:
> Thanks for the patch.
>
> Surely the sensors still have some differences.
They do, they absolutely do, the imx577 has a whole bunch of extra modes.
We don't have any reference code or access to documentation for those modes.
My reference is the qualcomm camx code for the rb5 board, which includes
a imx577 sensor. That stack uses the same init code as for the 412.
So for that baseline mode, the imx412 driver works perfectly.
> Even if the same registers would work as-is (the imx577 might still benefit
> from different MSRs?), the user should know which sensor it is. I.e. please
> set the media entity name accordingly. See e.g. the CCS driver for an
> example.
Agreed, I'll do that.
---
bod
next prev parent reply other threads:[~2022-06-14 14:44 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-07 13:40 [PATCH 0/2] Add imx577 compatible to imx412 Bryan O'Donoghue
2022-06-07 13:40 ` [PATCH 1/2] media: dt-bindings: imx412: Add imx577 compatible string Bryan O'Donoghue
2022-06-09 20:15 ` Rob Herring
2022-06-14 7:48 ` Kieran Bingham
2022-06-07 13:40 ` [PATCH 2/2] media: i2c: " Bryan O'Donoghue
2022-06-14 7:47 ` Kieran Bingham
2022-06-14 8:02 ` Alessandrelli, Daniele
2022-06-14 12:00 ` Sakari Ailus
2022-06-14 14:43 ` Bryan O'Donoghue [this message]
2022-06-07 21:56 ` [PATCH 0/2] Add imx577 compatible to imx412 Kieran Bingham
2022-06-07 22:01 ` Bryan O'Donoghue
2022-06-14 12:05 ` Sakari Ailus
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26dc329e-b663-e779-a30f-b495206ced48@linaro.org \
--to=bryan.odonoghue@linaro.org \
--cc=andrey.konovalov@linaro.org \
--cc=daniele.alessandrelli@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.baryshkov@linaro.org \
--cc=jacopo@jmondi.org \
--cc=konrad.dybcio@somainline.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=paul.j.murphy@intel.com \
--cc=sakari.ailus@iki.fi \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox