From: Krzysztof Kozlowski <krzk@kernel.org>
To: Richard Acayan <mailingradian@gmail.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Tianshu Qiu <tian.shu.qiu@intel.com>,
linux-media@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-msm@vger.kernel.org
Subject: Re: [PATCH 4/5] arm64: dts: qcom: sdm670-google-sargo: add imx355 front camera
Date: Tue, 1 Jul 2025 15:10:15 +0200 [thread overview]
Message-ID: <274ddf4e-2fab-4428-8207-e06522800982@kernel.org> (raw)
In-Reply-To: <20250630225944.320755-11-mailingradian@gmail.com>
On 01/07/2025 00:59, Richard Acayan wrote:
> +&cci_i2c1 {
> + camera@1a {
> + compatible = "sony,imx355";
> + reg = <0x1a>;
> +
> + clocks = <&camcc CAM_CC_MCLK2_CLK>;
> + clock-names = "mclk";
> +
> + clock-frequency = <19200000>;
No, drop. This is not a suitable property for DT I2C devices.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-07-01 13:10 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-06-30 22:59 [PATCH 0/5] media: i2c: IMX355 for the Pixel 3a Richard Acayan
2025-06-30 22:59 ` [PATCH 1/5] dt-bindings: media: i2c: Add Sony IMX355 Richard Acayan
2025-07-01 13:06 ` Krzysztof Kozlowski
2025-06-30 22:59 ` [PATCH 2/5] media: i2c: imx355: Support device tree probing and resource management Richard Acayan
2025-07-01 12:43 ` Bryan O'Donoghue
2025-07-01 13:08 ` Krzysztof Kozlowski
2025-06-30 22:59 ` [PATCH 3/5] media: i2c: imx355: Add power management for managed resources Richard Acayan
2025-07-01 12:48 ` Bryan O'Donoghue
2025-06-30 22:59 ` [PATCH 4/5] arm64: dts: qcom: sdm670-google-sargo: add imx355 front camera Richard Acayan
2025-07-01 10:52 ` Konrad Dybcio
2025-07-01 12:23 ` Bryan O'Donoghue
2025-07-01 23:15 ` Richard Acayan
2025-07-02 0:48 ` Bryan O'Donoghue
2025-07-01 13:10 ` Krzysztof Kozlowski [this message]
2025-06-30 22:59 ` [PATCH 5/5] arm64: dts: qcom: sdm670-google-sargo: Add front camera rotation/orientation Richard Acayan
2025-07-01 10:53 ` Konrad Dybcio
2025-07-01 13:11 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=274ddf4e-2fab-4428-8207-e06522800982@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mailingradian@gmail.com \
--cc=mchehab@kernel.org \
--cc=robh@kernel.org \
--cc=sakari.ailus@linux.intel.com \
--cc=tian.shu.qiu@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox