Re: [virtio-dev] Re: [PATCH v2 1/1] virtio-video: Add virtio video device specification

Dmitry Sepp
2020-01-06T09:29:15Z

Hi,

On Montag, 6. Januar 2020 09:33:35 CET Gerd Hoffmann wrote:
> Hi,
>
> > > We also see the need to add a max_streams value to this structure so as
> > > to
> > > explicitly provide a limit on the number of streams the guest can
> > > create.
> >
> > What would be the advantage over just trying to create one and
> > failing? The maximum number would be only meaningful for the special
> > case when the streams are always only created by one user space
> > process. Otherwise, if several processes do that, they are not aware
> > of each other and the number could be higher than they can actually
> > create, because other processes could have some streams created
> > already.
>
> Also the number of streams might not be fixed but depend on stream
> parameters, i.e. hardware can decode one hd or two sd streams ...
>
Ok, you are right. We'd better return an error from the device side.

Regards,
Dmitry.

> cheers,
> Gerd