From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Cc: linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH v6 9/9] v4l: vsp1: Reduce display list body size
Date: Sun, 20 May 2018 10:04:43 +0300 [thread overview]
Message-ID: <2794710.jCN7UpUv5u@avalon> (raw)
In-Reply-To: <e0ad4e839ffffb002ced5e960b43f5a54cd0260e.1519850924.git-series.kieran.bingham+renesas@ideasonboard.com>
Hi Kieran,
On Wednesday, 28 February 2018 22:52:43 EEST Kieran Bingham wrote:
> The display list originally allocated a body of 256 entries to store all
> of the register lists required for each frame.
>
> This has now been separated into fragments for constant stream setup, and
> runtime updates.
>
> Empirical testing shows that the body0 now uses a maximum of 41
> registers for each frame, for both DRM and Video API pipelines thus a
> rounded 64 entries provides a suitable allocation.
>
> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Just wondering, why have you dropped this from new versions of the patch
series ?
> ---
> drivers/media/platform/vsp1/vsp1_dl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/media/platform/vsp1/vsp1_dl.c
> b/drivers/media/platform/vsp1/vsp1_dl.c index a762e840d147..6b5743a431a2
> 100644
> --- a/drivers/media/platform/vsp1/vsp1_dl.c
> +++ b/drivers/media/platform/vsp1/vsp1_dl.c
> @@ -21,7 +21,7 @@
> #include "vsp1.h"
> #include "vsp1_dl.h"
>
> -#define VSP1_DL_NUM_ENTRIES 256
> +#define VSP1_DL_NUM_ENTRIES 64
>
> #define VSP1_DLH_INT_ENABLE (1 << 1)
> #define VSP1_DLH_AUTO_START (1 << 0)
--
Regards,
Laurent Pinchart
prev parent reply other threads:[~2018-05-20 7:04 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-02-28 20:52 [PATCH v6 0/9] vsp1: TLB optimisation and DL caching Kieran Bingham
2018-02-28 20:52 ` [PATCH v6 1/9] v4l: vsp1: Reword uses of 'fragment' as 'body' Kieran Bingham
2018-02-28 20:52 ` [PATCH v6 2/9] v4l: vsp1: Protect bodies against overflow Kieran Bingham
2018-02-28 20:52 ` [PATCH v6 3/9] v4l: vsp1: Provide a body pool Kieran Bingham
2018-02-28 20:52 ` [PATCH v6 4/9] v4l: vsp1: Convert display lists to use new " Kieran Bingham
2018-02-28 20:52 ` [PATCH v6 5/9] v4l: vsp1: Use reference counting for bodies Kieran Bingham
2018-02-28 20:52 ` [PATCH v6 6/9] v4l: vsp1: Refactor display list configure operations Kieran Bingham
2018-02-28 20:52 ` [PATCH v6 7/9] v4l: vsp1: Adapt entities to configure into a body Kieran Bingham
2018-02-28 20:52 ` [PATCH v6 8/9] v4l: vsp1: Move video configuration to a cached dlb Kieran Bingham
2018-02-28 20:52 ` [PATCH v6 9/9] v4l: vsp1: Reduce display list body size Kieran Bingham
2018-05-20 7:04 ` Laurent Pinchart [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2794710.jCN7UpUv5u@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=kieran.bingham+renesas@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox