public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Hans Verkuil <hverkuil+cisco@kernel.org>
To: HAYOU YASSINE <yassine.hayou@gmail.com>
Cc: linux-media@vger.kernel.org
Subject: Re: [PATCH 0/2] edid-decode: ARVR parsers and DisplayID sanity checks
Date: Fri, 30 Jan 2026 15:11:06 +0100	[thread overview]
Message-ID: <27bad1ad-ec8e-4574-aafe-5fa9d3e8d057@kernel.org> (raw)
In-Reply-To: <CANAm-cducmYzMhLRz0Yf8CcC8i0yUjscZ6VgXycxJdU-e-JX4w@mail.gmail.com>

Hi Yassine,

On 23/01/2026 16:26, HAYOU YASSINE wrote:
> Hi,
> 
> This patch series includes two improvements to edid-decode:
> 
> Patch 1/2: Implements full parsing for DisplayID 2.1 AR/VR data blocks
> - Tag 0x2c (ARVR_HMD): 79-byte block with optics, lens adjustment,
>   field of view, center of projection, and streams per layer fields
> - Tag 0x2d (ARVR_Layer): 20-byte block with HMD identification,
>   layer configuration, lens distortion, and scaling support
> - Includes comprehensive sanity checks for both blocks
> 
> Patch 2/2: Adds validation checks for DisplayID data blocks
> - Tag 0x20 (Product ID): Validates payload length, week range, and model year
> - Tag 0x21 (Display Parameters v2): Validates pixel format, chromaticity
>   coordinates, luminance information, and gamma EOTF range
> - Tag 0x22 (Type VII Timing): Validates pixel clock max, image dimensions max,
>   and negative blanking periods
> - Tag 0x24 (Type IX Timing): Validates image dimensions max and refresh rate max
> - Tag 0x25 (Dynamic Video Timing Range Limits): Validates pixel clock and
>   refresh rate ranges with revision-specific limits
> 
> These patches improve edid-decode's ability to parse and validate DisplayID
> data according to the VESA DisplayID Standard Version 2.1a, helping identify
> corrupted or invalid EDID data early and providing better error reporting
> for debugging display issues.
> 
> Please review.

I've been going over these patches, and they look good to me. Nice to see
this implemented.

Do you have an EDID that has the ARVR data blocks? If you do, then that
might be a good one to add to the data directory with example EDIDs.

If possible, I'd like to check the output with such an EDID first before I commit
the first patch.

Regards,

	Hans

> 
> Thanks,
> Yassine


  reply	other threads:[~2026-01-30 14:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-01-23 15:26 [PATCH 0/2] edid-decode: ARVR parsers and DisplayID sanity checks HAYOU YASSINE
2026-01-30 14:11 ` Hans Verkuil [this message]
2026-02-01 18:46   ` HAYOU YASSINE
2026-02-02  8:09     ` Hans Verkuil

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=27bad1ad-ec8e-4574-aafe-5fa9d3e8d057@kernel.org \
    --to=hverkuil+cisco@kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=yassine.hayou@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox