From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ed1-f41.google.com (mail-ed1-f41.google.com [209.85.208.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8FF1E20B1C for ; Thu, 4 Jan 2024 10:04:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="e4o8+k6B" Received: by mail-ed1-f41.google.com with SMTP id 4fb4d7f45d1cf-556ea884968so396224a12.3 for ; Thu, 04 Jan 2024 02:04:33 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1704362672; x=1704967472; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=d1rX6LIIBT0bJ+f5LqsiiirLWt5Scgx/ZLAmvrn5Vnc=; b=e4o8+k6Bf3LLU3kjQwSwGH8y7byUnT6pPVISLOBiz4E8N+65IYlHyZAKsTKyWGf5M1 lI/FCyPb6vaMCqDxXd1ClacEiEZ0hfr7QRI0YfYXv3YvQAKzaX7T9i9DsYLSnTeRaMz+ 03xptOYXf6WO0tv+XGheh/fQfndSrVMs9jS3JM1Q4KyZ63j1dj8EPAug0gu/kl2JB6U8 cOUiPo63qzz8/1/Kbd6RHpdjrbc8KOQ4kunUk33RkClDgbYrLfQapz4N+aT4PocUpG+Y rRBPZfohde2zCE1rZpS+4k/m/YMgwVzijdTmxdMpflCEcklrd+gbnY8mxgPSkDW0XFyf 1ayQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1704362672; x=1704967472; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=d1rX6LIIBT0bJ+f5LqsiiirLWt5Scgx/ZLAmvrn5Vnc=; b=rccTFaORmE6xfb5NhTtRUdw5lduISEF5viuGkkziYgT40r8EWS71g1X+IHRdVfGV2p FrOCxElRCYwEIwn4g2Nm/T3s5BYDCzHUnyhdpDBUADbmn/b+7rmNB8t5k4U50fiyv/fX qCiK50LD0qrdgg6xoMTSxb1Tw3GQ/Zl8ykFlCi47xhXb9mucg9TJsc+S8HKsptFzv6tE O/QysAQ5tE3C+pew+f0SljyRGMRHW8OIUQ5a7dsY8HmA1WxaIzRPVCZ9suTzmy6ocPfg fukoqxR9FFCrmvEdTvmsdbrRhQBObeBm9NJ5jw1Ue29LxUEeWEb+OJdreG99JlDwDmNX oE7A== X-Gm-Message-State: AOJu0Yyx4g7Vx9b80ucSMMa6pZHS/ZWD1b7q7T0OK4QJt4Y2zIXtISQc z0JhifV8IEY/xr+Fpw12MzUGcCQ+2JVOPQ== X-Google-Smtp-Source: AGHT+IEWjOWS+iJS3VKXtHcdRKJTlTSCqeub68dLNbBbnnO+iXKNUFFkecaVunXmV7+mtf/AHSr0rQ== X-Received: by 2002:a50:9b09:0:b0:553:6c38:148a with SMTP id o9-20020a509b09000000b005536c38148amr255183edi.39.1704362671711; Thu, 04 Jan 2024 02:04:31 -0800 (PST) Received: from localhost ([102.140.209.237]) by smtp.gmail.com with ESMTPSA id en22-20020a056402529600b00553830eb2fcsm18450686edb.64.2024.01.04.02.04.30 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 04 Jan 2024 02:04:31 -0800 (PST) Date: Thu, 4 Jan 2024 13:04:27 +0300 From: Dan Carpenter To: Hidenori Kobayashi Cc: Sakari Ailus , Bingbu Cao , Tianshu Qiu , Mauro Carvalho Chehab , Greg Kroah-Hartman , linux-media@vger.kernel.org, linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org Subject: Re: [PATCH] media: staging: ipu3-imgu: Set fields before media_entity_pads_init() Message-ID: <27f1c487-78cc-4e56-ba79-1434aba131fd@moroto.mountain> References: <20231228093926.748001-1-hidenorik@chromium.org> Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20231228093926.748001-1-hidenorik@chromium.org> On Thu, Dec 28, 2023 at 06:39:25PM +0900, Hidenori Kobayashi wrote: > The pad's flags is checked in media_entity_pads_init(), so it has to be > initialized beforehand. The ops initialization is also moved together > for readability. > How does this bug look like to a user? What is the Fixes tag? Does this need to be backported to stable? regards, dan carpenter