From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from galahad.ideasonboard.com ([185.26.127.97]:52040 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752057AbcIOR5G (ORCPT ); Thu, 15 Sep 2016 13:57:06 -0400 From: Laurent Pinchart To: Ulrich Hecht Cc: hans.verkuil@cisco.com, niklas.soderlund@ragnatech.se, linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org, magnus.damm@gmail.com, william.towle@codethink.co.uk Subject: Re: [PATCH v9 2/2] media: rcar-vin: use sink pad index for DV timings Date: Thu, 15 Sep 2016 20:57:49 +0300 Message-ID: <2806955.uYoIn4sQcH@avalon> In-Reply-To: <20160915173324.24539-3-ulrich.hecht+renesas@gmail.com> References: <20160915173324.24539-1-ulrich.hecht+renesas@gmail.com> <20160915173324.24539-3-ulrich.hecht+renesas@gmail.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-media-owner@vger.kernel.org List-ID: Hi Ulrich, Thank you for the patch. On Thursday 15 Sep 2016 19:33:24 Ulrich Hecht wrote: > Signed-off-by: Ulrich Hecht With a commit message explaining why this is needed, Acked-by: Laurent Pinchart > --- > drivers/media/platform/rcar-vin/rcar-v4l2.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/platform/rcar-vin/rcar-v4l2.c > b/drivers/media/platform/rcar-vin/rcar-v4l2.c index f35005c..2bbe6d4 100644 > --- a/drivers/media/platform/rcar-vin/rcar-v4l2.c > +++ b/drivers/media/platform/rcar-vin/rcar-v4l2.c > @@ -550,7 +550,7 @@ static int rvin_enum_dv_timings(struct file *file, void > *priv_fh, int pad, ret; > > pad = timings->pad; > - timings->pad = vin->src_pad_idx; > + timings->pad = vin->sink_pad_idx; > > ret = v4l2_subdev_call(sd, pad, enum_dv_timings, timings); > > @@ -604,7 +604,7 @@ static int rvin_dv_timings_cap(struct file *file, void > *priv_fh, int pad, ret; > > pad = cap->pad; > - cap->pad = vin->src_pad_idx; > + cap->pad = vin->sink_pad_idx; > > ret = v4l2_subdev_call(sd, pad, dv_timings_cap, cap); -- Regards, Laurent Pinchart