From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Sylwester Nawrocki <s.nawrocki@samsung.com>
Cc: linux-media@vger.kernel.org, a.hajda@samsung.com,
sakari.ailus@iki.fi, hverkuil@xs4all.nl,
kyungmin.park@samsung.com, sw0312.kim@samsung.com
Subject: Re: [PATCH RFC 1/5] V4L: Add V4L2_MBUS_FMT_S5C_UYVY_JPEG_1X8 media bus format
Date: Tue, 25 Sep 2012 13:42:13 +0200 [thread overview]
Message-ID: <2823843.qYtB3rcnKu@avalon> (raw)
In-Reply-To: <1348498546-2652-2-git-send-email-s.nawrocki@samsung.com>
Hi Sylwester,
On Monday 24 September 2012 16:55:42 Sylwester Nawrocki wrote:
> This patch adds media bus pixel code for the interleaved JPEG/UYVY
> image format used by S5C73MX Samsung cameras. This interleaved image
> data is transferred on MIPI-CSI2 bus as User Defined Byte-based Data.
>
> It also defines an experimental vendor and device specific media bus
> formats section and adds related DocBook documentation.
>
> Signed-off-by: Sylwester Nawrocki <s.nawrocki@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
> ---
> Documentation/DocBook/media/v4l/compat.xml | 4 ++
> Documentation/DocBook/media/v4l/subdev-formats.xml | 45 +++++++++++++++++++
> include/linux/v4l2-mediabus.h | 5 +++
> 3 files changed, 54 insertions(+)
>
> diff --git a/Documentation/DocBook/media/v4l/compat.xml
> b/Documentation/DocBook/media/v4l/compat.xml index 98e8d08..5d2480b 100644
> --- a/Documentation/DocBook/media/v4l/compat.xml
> +++ b/Documentation/DocBook/media/v4l/compat.xml
> @@ -2605,6 +2605,10 @@ ioctls.</para>
> <listitem>
> <para>Support for frequency band enumeration: &VIDIOC-ENUM-FREQ-BANDS;
> ioctl.</para> </listitem>
> + <listitem>
> + <para>Vendor and device specific media bus pixel formats.
> + <xref linkend="v4l2-mbus-vendor-spec-fmts" />.</para>
> + </listitem>
> </itemizedlist>
> </section>
>
> diff --git a/Documentation/DocBook/media/v4l/subdev-formats.xml
> b/Documentation/DocBook/media/v4l/subdev-formats.xml index 49c532e..d7aa870
> 100644
> --- a/Documentation/DocBook/media/v4l/subdev-formats.xml
> +++ b/Documentation/DocBook/media/v4l/subdev-formats.xml
> @@ -2565,5 +2565,50 @@
> </tgroup>
> </table>
> </section>
> +
> + <section id="v4l2-mbus-vendor-spec-fmts">
> + <title>Vendor and Device Specific Formats</title>
> +
> + <note>
> + <title> Experimental </title>
I don't think you need spaces across the title.
> + <para>This is an <link linkend="experimental">experimental</link>
> +interface and may change in the future.</para>
> + </note>
> +
> + <para> This section lists complex data formats that are either vendor
> or
> + device specific. These formats comprise raw and compressed image data
> + and optional meta-data within a single frame.
That's currently true, but we could have other strange vendor-specific formats
that don't interleave raw and compressed frames.
> + </para>
> +
> + <para>The following table lists the existing vendor and device
> specific
> + formats.</para>
> +
> + <table pgwide="0" frame="none"
> id="v4l2-mbus-pixelcode-vendor-specific"> + <title>Vendor and device
> specific formats</title>
> + <tgroup cols="3">
> + <colspec colname="id" align="left" />
> + <colspec colname="code" align="left"/>
> + <colspec colname="remarks" align="left"/>
> + <thead>
> + <row>
> + <entry>Identifier</entry>
> + <entry>Code</entry>
> + <entry>Comments</entry>
> + </row>
> + </thead>
> + <tbody valign="top">
> + <row id="V4L2-MBUS-FMT-S5C-UYVY-JPG-1X8">
> + <entry>V4L2_MBUS_FMT_S5C_UYVY_JPG_1X8</entry>
> + <entry>0x8001</entry>
> + <entry>
> + Interleaved raw UYVY and JPEG image format with embedded
> + meta-data, produced by S3C73M3 camera sensors.
> + </entry>
> + </row>
> + </tbody>
> + </tgroup>
> + </table>
> + </section>
> +
> </section>
> </section>
> diff --git a/include/linux/v4l2-mediabus.h b/include/linux/v4l2-mediabus.h
> index 5ea7f75..b98c566 100644
> --- a/include/linux/v4l2-mediabus.h
> +++ b/include/linux/v4l2-mediabus.h
> @@ -92,6 +92,11 @@ enum v4l2_mbus_pixelcode {
>
> /* JPEG compressed formats - next is 0x4002 */
> V4L2_MBUS_FMT_JPEG_1X8 = 0x4001,
> +
> + /* Vendor specific formats - next is 0x8002 */
Anything wrong with 0x5000 as a base value ? :-)
> +
> + /* S5C73M3 interleaved UYVY and JPEG */
> + V4L2_MBUS_FMT_S5C_UYVY_JPEG_1X8 = 0x8001,
> };
>
> /**
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2012-09-25 11:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-09-24 14:55 [PATCH RFC v2 0/5] s5p-fimc: Add interleaved image data capture support Sylwester Nawrocki
2012-09-24 14:55 ` [PATCH RFC 1/5] V4L: Add V4L2_MBUS_FMT_S5C_UYVY_JPEG_1X8 media bus format Sylwester Nawrocki
2012-09-25 11:42 ` Laurent Pinchart [this message]
2012-09-25 14:39 ` Sylwester Nawrocki
2012-10-09 13:36 ` Vincent ABRIOU
2012-10-09 17:09 ` Sylwester Nawrocki
2012-10-15 18:35 ` Sakari Ailus
2012-11-06 10:02 ` Vincent ABRIOU
2012-09-24 14:55 ` [PATCH RFC 2/5] V4L: Add V4L2_PIX_FMT_S5C_UYVY_JPG fourcc definition Sylwester Nawrocki
2012-09-25 11:44 ` Laurent Pinchart
2012-09-25 14:47 ` Sylwester Nawrocki
2012-09-24 14:55 ` [PATCH RFC 3/5] s5p-csis: Add support for non-image data packets capture Sylwester Nawrocki
2012-09-24 14:55 ` [PATCH RFC 4/5] s5p-fimc: Add support for V4L2_PIX_FMT_S5C_UYVY_JPG fourcc Sylwester Nawrocki
2012-09-24 14:55 ` [PATCH RFC 5/5] m5mols: Implement .get_frame_desc subdev callback Sylwester Nawrocki
2012-09-24 15:10 ` [PATCH RFC v2 0/5] s5p-fimc: Add interleaved image data capture support Sylwester Nawrocki
2012-09-25 11:37 ` Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2823843.qYtB3rcnKu@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=a.hajda@samsung.com \
--cc=hverkuil@xs4all.nl \
--cc=kyungmin.park@samsung.com \
--cc=linux-media@vger.kernel.org \
--cc=s.nawrocki@samsung.com \
--cc=sakari.ailus@iki.fi \
--cc=sw0312.kim@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).