public inbox for linux-media@vger.kernel.org
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Hans Verkuil <hverkuil@xs4all.nl>
Cc: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
	linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH 1/6] v4l: vsp1: Remove WPF vertical flip support on VSP2-B[CD] and VSP2-D
Date: Fri, 23 Jun 2017 13:30:17 +0300	[thread overview]
Message-ID: <2834844.GxJxlkDrrf@avalon> (raw)
In-Reply-To: <e499dfd0-50fd-a45b-6807-a87224d0ddf5@xs4all.nl>

Hi Hans,

On Friday 23 Jun 2017 11:10:45 Hans Verkuil wrote:
> On 06/19/17 13:18, Hans Verkuil wrote:
> > On 06/19/2017 01:16 PM, Laurent Pinchart wrote:
> >> On Thursday 15 Jun 2017 10:53:33 Hans Verkuil wrote:
> >>> On 06/15/17 10:24, Laurent Pinchart wrote:
> >>>> The WPF vertical flip is only supported on Gen3 SoCs on the VSP2-I.
> >>>> Don't enable it on other VSP2 instances.
> >>>> 
> >>>> Signed-off-by: Laurent Pinchart
> >>>> <laurent.pinchart+renesas@ideasonboard.com>
> >>> 
> >>> Should this go to older kernels as well? Or is that not needed?
> >> 
> >> Now that I have access to the hardware again, after further testing, it
> >> looks like vertical flip is implemented in the VSP2-B[CD] and VSP2-D
> >> even though the datasheet states otherwise. Let's ignore this patch for
> >> now, I'll try to double-check with Renesas.
> > 
> > Patches 2-6 are OK, though? If they are, then I'll pick them up.
> 
> Ping! Please let me know if patches 2-6 are OK for me to pick up. I'll make
> a final pull request today, after that they'll be postponed until 4.14.

I've received confirmation that the feature is actually implemented. The bug 
was in the datasheet, not in the driver. I've thus marked the patch as 
rejected in patchwork.

-- 
Regards,

Laurent Pinchart

  reply	other threads:[~2017-06-23 10:29 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-06-15  8:24 [PATCH 0/6] Renesas R-Car VSP: Add H3 ES2.0 support Laurent Pinchart
2017-06-15  8:24 ` [PATCH 1/6] v4l: vsp1: Remove WPF vertical flip support on VSP2-B[CD] and VSP2-D Laurent Pinchart
2017-06-15  8:53   ` Hans Verkuil
2017-06-19 11:16     ` Laurent Pinchart
2017-06-19 11:18       ` Hans Verkuil
2017-06-23  9:10         ` Hans Verkuil
2017-06-23 10:30           ` Laurent Pinchart [this message]
2017-06-15  8:24 ` [PATCH 2/6] v4l: vsp1: Add support for the BRS entity Laurent Pinchart
2017-06-15  8:24 ` [PATCH 3/6] v4l: vsp1: Add support for new VSP2-BS, VSP2-DL and VSP2-D instances Laurent Pinchart
2017-06-15  8:24 ` [PATCH 4/6] v4l: vsp1: Add pipe index argument to the VSP-DU API Laurent Pinchart
2017-06-15  8:24 ` [PATCH 5/6] v4l: vsp1: Fill display list headers without holding dlm spinlock Laurent Pinchart
2017-06-15  8:24 ` [PATCH 6/6] v4l: vsp1: Add support for header display lists in continuous mode Laurent Pinchart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2834844.GxJxlkDrrf@avalon \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=hverkuil@xs4all.nl \
    --cc=laurent.pinchart+renesas@ideasonboard.com \
    --cc=linux-media@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox