* [PATCH] yavta: Add support for intel ipu3 specific raw formats
@ 2018-01-02 3:02 tian.shu.qiu
2018-01-02 11:11 ` Sakari Ailus
0 siblings, 1 reply; 3+ messages in thread
From: tian.shu.qiu @ 2018-01-02 3:02 UTC (permalink / raw)
To: linux-media; +Cc: Laurent Pinchart, Sakari Ailus, Qiu, Tianshu
From: Tianshu Qiu <tian.shu.qiu@intel.com>
Add support for these pixel formats:
V4L2_PIX_FMT_IPU3_SBGGR10
V4L2_PIX_FMT_IPU3_SGBRG10
V4L2_PIX_FMT_IPU3_SGRBG10
V4L2_PIX_FMT_IPU3_SRGGB10
Signed-off-by: Tianshu Qiu <tian.shu.qiu@intel.com>
---
include/linux/videodev2.h | 5 +++++
yavta.c | 4 ++++
2 files changed, 9 insertions(+)
diff --git a/include/linux/videodev2.h b/include/linux/videodev2.h
index b1e36ee553da..6f7cd9622ea8 100644
--- a/include/linux/videodev2.h
+++ b/include/linux/videodev2.h
@@ -659,6 +659,11 @@ struct v4l2_pix_format {
#define V4L2_PIX_FMT_MT21C v4l2_fourcc('M', 'T', '2', '1') /* Mediatek compressed block mode */
#define V4L2_PIX_FMT_INZI v4l2_fourcc('I', 'N', 'Z', 'I') /* Intel Planar Greyscale 10-bit and Depth 16-bit */
+#define V4L2_PIX_FMT_IPU3_SBGGR10 v4l2_fourcc('i', 'p', '3', 'b') /* IPU3 packed 10-bit BGGR bayer */
+#define V4L2_PIX_FMT_IPU3_SGBRG10 v4l2_fourcc('i', 'p', '3', 'g') /* IPU3 packed 10-bit GBRG bayer */
+#define V4L2_PIX_FMT_IPU3_SGRBG10 v4l2_fourcc('i', 'p', '3', 'G') /* IPU3 packed 10-bit GRBG bayer */
+#define V4L2_PIX_FMT_IPU3_SRGGB10 v4l2_fourcc('i', 'p', '3', 'r') /* IPU3 packed 10-bit RGGB bayer */
+
/* SDR formats - used only for Software Defined Radio devices */
#define V4L2_SDR_FMT_CU8 v4l2_fourcc('C', 'U', '0', '8') /* IQ u8 */
#define V4L2_SDR_FMT_CU16LE v4l2_fourcc('C', 'U', '1', '6') /* IQ u16le */
diff --git a/yavta.c b/yavta.c
index afe96331a520..524e549efd08 100644
--- a/yavta.c
+++ b/yavta.c
@@ -220,6 +220,10 @@ static struct v4l2_format_info {
{ "SGBRG10P", V4L2_PIX_FMT_SGBRG10P, 1 },
{ "SGRBG10P", V4L2_PIX_FMT_SGRBG10P, 1 },
{ "SRGGB10P", V4L2_PIX_FMT_SRGGB10P, 1 },
+ { "IPU3_GRBG10", V4L2_PIX_FMT_IPU3_SGRBG10, 1 },
+ { "IPU3_RGGB10", V4L2_PIX_FMT_IPU3_SRGGB10, 1 },
+ { "IPU3_BGGR10", V4L2_PIX_FMT_IPU3_SBGGR10, 1 },
+ { "IPU3_GBRG10", V4L2_PIX_FMT_IPU3_SGBRG10, 1 },
{ "SBGGR12", V4L2_PIX_FMT_SBGGR12, 1 },
{ "SGBRG12", V4L2_PIX_FMT_SGBRG12, 1 },
{ "SGRBG12", V4L2_PIX_FMT_SGRBG12, 1 },
--
2.7.4
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] yavta: Add support for intel ipu3 specific raw formats
2018-01-02 3:02 [PATCH] yavta: Add support for intel ipu3 specific raw formats tian.shu.qiu
@ 2018-01-02 11:11 ` Sakari Ailus
2018-01-02 11:30 ` Laurent Pinchart
0 siblings, 1 reply; 3+ messages in thread
From: Sakari Ailus @ 2018-01-02 11:11 UTC (permalink / raw)
To: tian.shu.qiu; +Cc: linux-media, Laurent Pinchart, Sakari Ailus
Hi Tian Shu,
Thanks for the patch.
On Tue, Jan 02, 2018 at 11:02:37AM +0800, tian.shu.qiu@intel.com wrote:
> From: Tianshu Qiu <tian.shu.qiu@intel.com>
>
> Add support for these pixel formats:
>
> V4L2_PIX_FMT_IPU3_SBGGR10
> V4L2_PIX_FMT_IPU3_SGBRG10
> V4L2_PIX_FMT_IPU3_SGRBG10
> V4L2_PIX_FMT_IPU3_SRGGB10
>
> Signed-off-by: Tianshu Qiu <tian.shu.qiu@intel.com>
> ---
> include/linux/videodev2.h | 5 +++++
> yavta.c | 4 ++++
> 2 files changed, 9 insertions(+)
>
> diff --git a/include/linux/videodev2.h b/include/linux/videodev2.h
> index b1e36ee553da..6f7cd9622ea8 100644
> --- a/include/linux/videodev2.h
> +++ b/include/linux/videodev2.h
> @@ -659,6 +659,11 @@ struct v4l2_pix_format {
> #define V4L2_PIX_FMT_MT21C v4l2_fourcc('M', 'T', '2', '1') /* Mediatek compressed block mode */
> #define V4L2_PIX_FMT_INZI v4l2_fourcc('I', 'N', 'Z', 'I') /* Intel Planar Greyscale 10-bit and Depth 16-bit */
>
> +#define V4L2_PIX_FMT_IPU3_SBGGR10 v4l2_fourcc('i', 'p', '3', 'b') /* IPU3 packed 10-bit BGGR bayer */
> +#define V4L2_PIX_FMT_IPU3_SGBRG10 v4l2_fourcc('i', 'p', '3', 'g') /* IPU3 packed 10-bit GBRG bayer */
> +#define V4L2_PIX_FMT_IPU3_SGRBG10 v4l2_fourcc('i', 'p', '3', 'G') /* IPU3 packed 10-bit GRBG bayer */
> +#define V4L2_PIX_FMT_IPU3_SRGGB10 v4l2_fourcc('i', 'p', '3', 'r') /* IPU3 packed 10-bit RGGB bayer */
> +
Could you update the kernel headers in a separate patch? This should
include all headers as they're produced by make headers_install .
> /* SDR formats - used only for Software Defined Radio devices */
> #define V4L2_SDR_FMT_CU8 v4l2_fourcc('C', 'U', '0', '8') /* IQ u8 */
> #define V4L2_SDR_FMT_CU16LE v4l2_fourcc('C', 'U', '1', '6') /* IQ u16le */
> diff --git a/yavta.c b/yavta.c
> index afe96331a520..524e549efd08 100644
> --- a/yavta.c
> +++ b/yavta.c
> @@ -220,6 +220,10 @@ static struct v4l2_format_info {
> { "SGBRG10P", V4L2_PIX_FMT_SGBRG10P, 1 },
> { "SGRBG10P", V4L2_PIX_FMT_SGRBG10P, 1 },
> { "SRGGB10P", V4L2_PIX_FMT_SRGGB10P, 1 },
> + { "IPU3_GRBG10", V4L2_PIX_FMT_IPU3_SGRBG10, 1 },
> + { "IPU3_RGGB10", V4L2_PIX_FMT_IPU3_SRGGB10, 1 },
> + { "IPU3_BGGR10", V4L2_PIX_FMT_IPU3_SBGGR10, 1 },
> + { "IPU3_GBRG10", V4L2_PIX_FMT_IPU3_SGBRG10, 1 },
> { "SBGGR12", V4L2_PIX_FMT_SBGGR12, 1 },
> { "SGBRG12", V4L2_PIX_FMT_SGBRG12, 1 },
> { "SGRBG12", V4L2_PIX_FMT_SGRBG12, 1 },
--
Regards,
Sakari Ailus
e-mail: sakari.ailus@iki.fi
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] yavta: Add support for intel ipu3 specific raw formats
2018-01-02 11:11 ` Sakari Ailus
@ 2018-01-02 11:30 ` Laurent Pinchart
0 siblings, 0 replies; 3+ messages in thread
From: Laurent Pinchart @ 2018-01-02 11:30 UTC (permalink / raw)
To: Sakari Ailus; +Cc: tian.shu.qiu, linux-media, Sakari Ailus
Hello,
On Tuesday, 2 January 2018 13:11:39 EET Sakari Ailus wrote:
> On Tue, Jan 02, 2018 at 11:02:37AM +0800, tian.shu.qiu@intel.com wrote:
> > From: Tianshu Qiu <tian.shu.qiu@intel.com>
> >
> > Add support for these pixel formats:
> >
> > V4L2_PIX_FMT_IPU3_SBGGR10
> > V4L2_PIX_FMT_IPU3_SGBRG10
> > V4L2_PIX_FMT_IPU3_SGRBG10
> > V4L2_PIX_FMT_IPU3_SRGGB10
> >
> > Signed-off-by: Tianshu Qiu <tian.shu.qiu@intel.com>
> > ---
> >
> > include/linux/videodev2.h | 5 +++++
> > yavta.c | 4 ++++
> > 2 files changed, 9 insertions(+)
> >
> > diff --git a/include/linux/videodev2.h b/include/linux/videodev2.h
> > index b1e36ee553da..6f7cd9622ea8 100644
> > --- a/include/linux/videodev2.h
> > +++ b/include/linux/videodev2.h
> > @@ -659,6 +659,11 @@ struct v4l2_pix_format {
> >
> > #define V4L2_PIX_FMT_MT21C v4l2_fourcc('M', 'T', '2', '1') /* Mediatek
> > compressed block mode */ #define V4L2_PIX_FMT_INZI v4l2_fourcc('I',
> > 'N', 'Z', 'I') /* Intel Planar Greyscale 10-bit and Depth 16-bit */>
> > +#define V4L2_PIX_FMT_IPU3_SBGGR10 v4l2_fourcc('i', 'p', '3', 'b') /*
> > IPU3 packed 10-bit BGGR bayer */ +#define V4L2_PIX_FMT_IPU3_SGBRG10
> > v4l2_fourcc('i', 'p', '3', 'g') /* IPU3 packed 10-bit GBRG bayer */
> > +#define V4L2_PIX_FMT_IPU3_SGRBG10 v4l2_fourcc('i', 'p', '3', 'G') /*
> > IPU3 packed 10-bit GRBG bayer */ +#define V4L2_PIX_FMT_IPU3_SRGGB10
> > v4l2_fourcc('i', 'p', '3', 'r') /* IPU3 packed 10-bit RGGB bayer */ +
>
> Could you update the kernel headers in a separate patch? This should
> include all headers as they're produced by make headers_install .
I was going to mention that :-)
Take the most recent upstream kernel that contains the above formats (it can
be an -rc release if they're not in a stable kernel yet, but it has to come
from Linus' tree), run make headers_install, and update all the headers in
include/linux/. Then commit the result with a message similar to
commit 2fb40d5f40e95e792f6d9f6fd57856697c9091c0
Author: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Date: Mon Oct 24 15:59:44 2016 +0300
Update headers from upstream kernel
Upstream commit 3907fae86ebabd622bd8265285d5b612d5958948
Signed-off-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > /* SDR formats - used only for Software Defined Radio devices */
> > #define V4L2_SDR_FMT_CU8 v4l2_fourcc('C', 'U', '0', '8') /* IQ
> > u8 */ #define V4L2_SDR_FMT_CU16LE v4l2_fourcc('C', 'U', '1', '6')
> > /* IQ u16le */>
> > diff --git a/yavta.c b/yavta.c
> > index afe96331a520..524e549efd08 100644
> > --- a/yavta.c
> > +++ b/yavta.c
> > @@ -220,6 +220,10 @@ static struct v4l2_format_info {
> > { "SGBRG10P", V4L2_PIX_FMT_SGBRG10P, 1 },
> > { "SGRBG10P", V4L2_PIX_FMT_SGRBG10P, 1 },
> > { "SRGGB10P", V4L2_PIX_FMT_SRGGB10P, 1 },
> > + { "IPU3_GRBG10", V4L2_PIX_FMT_IPU3_SGRBG10, 1 },
> > + { "IPU3_RGGB10", V4L2_PIX_FMT_IPU3_SRGGB10, 1 },
> > + { "IPU3_BGGR10", V4L2_PIX_FMT_IPU3_SBGGR10, 1 },
> > + { "IPU3_GBRG10", V4L2_PIX_FMT_IPU3_SGBRG10, 1 },
> > { "SBGGR12", V4L2_PIX_FMT_SBGGR12, 1 },
> > { "SGBRG12", V4L2_PIX_FMT_SGBRG12, 1 },
> > { "SGRBG12", V4L2_PIX_FMT_SGRBG12, 1 },
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-01-02 11:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2018-01-02 3:02 [PATCH] yavta: Add support for intel ipu3 specific raw formats tian.shu.qiu
2018-01-02 11:11 ` Sakari Ailus
2018-01-02 11:30 ` Laurent Pinchart
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).