Re: I2C transfer logs for Antti's DS3103 driver and DVBSky's DS3103 driver

[David Howells <dhowells@redhat.com>]

Antti Palosaari <crope@iki.fi> wrote:

> > But you don't give me the option of _not_ setting it.  The dvbsky driver
> > sets it to 0x35 in its init_tab[] - as does yours - and then leaves it
> > alone.
> 
> So what? Do you understand meaning of init tables?

Yes.  You misunderstand what I'm saying.  You unconditionally write cfg->agc
to port 0x33 in m88ds3103_set_frontend() after loading the init tables.  Why
do you need to do that at all if the default is fine?  You don't give me the
option of saying that I want to stick with the default and not change it.

> Just set correct value there and it should be OK.
> +       .agc = 0x99,

Why is 0x99 correct?  The default is 0x35 and the dvbsky driver does not alter
it from that.

Btw, setting it to 0x99 has no obvious effect over leaving it as the default.

> > Whilst that may be so, something clears it between one call to
> > m88ds3103_set_frontend() and the next, so you probably need to
> > unconditionally reload the program init table.
> 
> It is programmed conditionally to avoid I/O.

Obviously.

Nonetheless, register 0x76 seems to change its value between passes through
your code without you touching it inbetween:-/

David