Linux Media Controller development
 help / color / mirror / Atom feed
From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: William Manley <will@williammanley.net>
Cc: linux-media@vger.kernel.org, m.chehab@samsung.com
Subject: Re: [PATCH] [media] uvcvideo: Add GUID for BGR 8:8:8
Date: Thu, 18 Dec 2014 23:23:26 +0200	[thread overview]
Message-ID: <2873589.uTjIvfEhRn@avalon> (raw)
In-Reply-To: <5488F136.6050907@williammanley.net>

Hi William,

On Thursday 11 December 2014 01:19:50 William Manley wrote:
> On 10/12/14 23:54, Laurent Pinchart wrote:
> > On Monday 08 December 2014 18:57:58 William Manley wrote:
> >> The Magewell XI100DUSB-HDMI[1] video capture device reports the pixel
> >> format "e436eb7d-524f-11ce-9f53-0020af0ba770".  This is its GUID for
> >> BGR 8:8:8.
> >> 
> >> The UVC 1.5 spec[2] only defines GUIDs for YUY2, NV12, M420 and I420.
> >> This seems to be an extension documented in the Microsoft Windows Media
> >> Format SDK[3] - or at least the Media Format SDK was the only hit that
> >> Google gave when searching for the GUID.  This Media Format SDK defines
> >> this GUID as corresponding to `MEDIASUBTYPE_RGB24`.  Note though, the
> >> XI100DUSB outputs BGR e.g. byte-reversed.  I don't know if its the
> >> capture device in error or Microsoft mean BGR when they say RGB.
> > 
> > I believe Microsoft defines RGB as BGR. They do at least in BMP
> > (https://en.wikipedia.org/wiki/BMP_file_format), probably because they
> > consider the RGB pixel to be stored in little-endian format.
> 
> Thanks, that's helpful.
> 
> > Acked-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > 
> > I'll apply the patch to my tree and submit it for v3.20.
> 
> Great
> 
> > Could you please send me the output of 'lsusb -v' for your device, if
> > possible running as root ?
> 
> lsusb output attached.

Thank you. I've updated the supported devices list.

-- 
Regards,

Laurent Pinchart


      reply	other threads:[~2014-12-18 21:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-12-08 18:57 [PATCH] [media] uvcvideo: Add GUID for BGR 8:8:8 William Manley
2014-12-10 23:54 ` Laurent Pinchart
2014-12-11  1:19   ` William Manley
2014-12-18 21:23     ` Laurent Pinchart [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2873589.uTjIvfEhRn@avalon \
    --to=laurent.pinchart@ideasonboard.com \
    --cc=linux-media@vger.kernel.org \
    --cc=m.chehab@samsung.com \
    --cc=will@williammanley.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox