Linux Media Controller development
 help / color / mirror / Atom feed
From: Shuah Khan <skhan@linuxfoundation.org>
To: Hans Verkuil <hverkuil@xs4all.nl>,
	Matthew Majewski <mattwmajewski@gmail.com>,
	Uwe Kleine-Konig <u.kleine-koenig@baylibre.com>
Cc: Mauro Carvalho Chehab <mchehab@kernel.org>,
	linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
	Shuah Khan <skhan@linuxfoundation.org>
Subject: Re: [PATCH] media: vim2m: print device name after registering device
Date: Thu, 6 Mar 2025 09:01:38 -0700	[thread overview]
Message-ID: <287521e2-afaf-4ed9-bcd6-bac610aab564@linuxfoundation.org> (raw)
In-Reply-To: <06766086-b148-436c-b6d4-975c26493233@xs4all.nl>

On 3/6/25 01:37, Hans Verkuil wrote:
> Hi Shuah,
> 
> On 20/02/2025 17:27, Shuah Khan wrote:
>> On 2/20/25 08:29, Matthew Majewski wrote:
>>> On Wed, 2025-02-19 at 17:21 -0700, Shuah Khan wrote:
>>>> On 2/19/25 14:58, Uwe Kleine-Konig wrote:
>>>>> On Wed, Feb 19, 2025 at 02:05:01PM -0500, Matthew Majewski wrote:
>>>>>> Move the v4l2_info() call displaying the video device name after
>>>>>> the
>>>>>> device is actually registered.
>>>>>>
>>>>>> This fixes a bug where the driver was always displaying
>>>>>> "/dev/video0"
>>>>>> since it was reading from the vfd before it was registered.
>>>>>>
>>>>>> Signed-off-by: Matthew Majewski <mattwmajewski@gmail.com>
>>>>>
>>>>> A Fixes: tag would be great.
>>>>
>>>> Matthew, there is no need to resend the patch. Just send me the
>>>> Fixes tag and I will update the repo.
>>>>
>>>>
>>>
>>> Ok, here is the fixes tag:
>>>
>>> Fixes: cf7f34777a5b4100a ("media: vim2m: Register video device after
>>> setting up internals")
>>>
>>
>> Thank you. commit is now updated.
>>
>> thanks,
>> -- Shuah
>>
> 
> Please post your PR today, if possible. Otherwise it might slip to the
> v6.16. Alternatively, I can take this patch myself.

Thanks for the reminder - I have to send a vimc PR

Please take this through your tree.

> 
> Also, why did you pick up this vim2m patch? I was a bit surprised by that.

By mistake - Blame it on jet lag - sorry. Explains why Matthew sent series
for my review.

thanks,
-- Shuah

      reply	other threads:[~2025-03-06 16:01 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-02-19 19:05 [PATCH] media: vim2m: print device name after registering device Matthew Majewski
2025-02-19 21:11 ` Shuah Khan
2025-02-19 21:58 ` Uwe Kleine-Konig
2025-02-20  0:21   ` Shuah Khan
2025-02-20 15:29     ` Matthew Majewski
2025-02-20 16:27       ` Shuah Khan
2025-03-06  8:37         ` Hans Verkuil
2025-03-06 16:01           ` Shuah Khan [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=287521e2-afaf-4ed9-bcd6-bac610aab564@linuxfoundation.org \
    --to=skhan@linuxfoundation.org \
    --cc=hverkuil@xs4all.nl \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mattwmajewski@gmail.com \
    --cc=mchehab@kernel.org \
    --cc=u.kleine-koenig@baylibre.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox