From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mout.kundenserver.de ([212.227.17.13]:59504 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753136AbcKGNFI (ORCPT ); Mon, 7 Nov 2016 08:05:08 -0500 From: Arnd Bergmann To: Sean Young Cc: linux-media@vger.kernel.org, Geert Uytterhoeven , linux-kernel@vger.kernel.org, Mauro Carvalho Chehab Subject: Re: [PATCH] [media] dib0700: fix nec repeat handling Date: Mon, 07 Nov 2016 14:04:58 +0100 Message-ID: <2878306.lrpKj4PiIm@wuerfel> In-Reply-To: <20161102164509.GA10912@gofer.mess.org> References: <1476366699-21611-1-git-send-email-geert@linux-m68k.org> <7477306.RsW9ioQisc@wuerfel> <20161102164509.GA10912@gofer.mess.org> MIME-Version: 1.0 Content-Transfer-Encoding: 8BIT Content-Type: text/plain; charset="UTF-8" Sender: linux-media-owner@vger.kernel.org List-ID: On Wednesday, November 2, 2016 4:45:09 PM CET Sean Young wrote: > On Sat, Oct 29, 2016 at 11:04:32PM +0200, Arnd Bergmann wrote: > > On Thursday, October 13, 2016 10:28:44 PM CEST Sean Young wrote: > > > When receiving a nec repeat, ensure the correct scancode is repeated > > > rather than a random value from the stack. This removes the need > > > for the bogus uninitialized_var() and also fixes the warnings: > > > > > > drivers/media/usb/dvb-usb/dib0700_core.c: In function ‘dib0700_rc_urb_completion’: > > > drivers/media/usb/dvb-usb/dib0700_core.c:679: warning: ‘protocol’ may be used uninitialized in this function > > > > > > Signed-off-by: Sean Young > > > --- > > > drivers/media/usb/dvb-usb/dib0700_core.c | 5 +++-- > > > 1 file changed, 3 insertions(+), 2 deletions(-) > > > > Acked-by: Arnd Bergmann > > Cc: stable@vger.kernel.org > > Fixes: 2ceeca0499d7 ("[media] rc: split nec protocol into its three variants") > > Fixes: d3c501d1938c ("V4L/DVB: dib0700: Fix RC protocol logic to properly handle NEC/NECx and RC-5") > > > > > > The warning is gone for me too, so this obsoletes both > > https://patchwork.linuxtv.org/patch/37494/ and > > https://patchwork.kernel.org/patch/9380747/ > > > > Can we get this patch merged into v4.9 soonish? The warning > > is currently disabled, but I'd like to make sure it gets turned > > on again by default, and we should fix all the actual bugs in > > the process. > > So after writing the patch and submitting it, I've bought the hardware on > ebay. Without this patch you get random scancodes on nec repeats, which > the patch indeed fixes. > > Tested-by: Sean Young Awesome, thanks for testing! > Note that this has been broken forever, so it is not a regression, so > does it belong in stable? I think it does, it doesn't have to be a regression to qualify for stable kernels, and it is clearly a bugfix. Arnd